EdifactParser::createWithDefaultSegments() - Code Metrics - Inspection of "Improving the examples" - Chemaclass/EdifactParser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1c5d16...a9efcd )

by Chema

created 2020-09-18 15:59 UTC

EdifactParser::createWithDefaultSegments() A

↳ Parent: EdifactParser

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	3
rs	10
ccs	2
cts	2
cp	1
crap	1

<?php

declare(strict_types=1);

namespace EdifactParser;

use EDI\Parser;
use EdifactParser\Exception\InvalidFile;
use EdifactParser\Segments\SegmentFactory;
use EdifactParser\Segments\SegmentFactoryInterface;

/** @psalm-immutable */
final class EdifactParser
{
    private SegmentFactoryInterface $segmentFactory;

    public static function createWithDefaultSegments(): self
    {
        return new self(SegmentFactory::withDefaultSegments());
    }

    public function __construct(SegmentFactoryInterface $segmentFactory)
    {
        $this->segmentFactory = $segmentFactory;
    }

    /** @codeCoverageIgnore */
    private function __clone()
    {
    }

    /** @return TransactionMessage[] */
    public function parse(string $fileContent): array
    {
        $parser = new Parser($fileContent);
        $errors = $parser->errors();

        if ($errors) {

            throw InvalidFile::withErrors($errors);
        }

        $segmentList = SegmentList::factory($this->segmentFactory);
        $segments = $segmentList->fromRaw($parser->get());

        return TransactionMessage::groupSegmentsByMessage(...$segments);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace EdifactParser;
6
7		use EDI\Parser;
8		use EdifactParser\Exception\InvalidFile;
9		use EdifactParser\Segments\SegmentFactory;
10		use EdifactParser\Segments\SegmentFactoryInterface;
11
12		/** @psalm-immutable */
13		final class EdifactParser
14		{
15		private SegmentFactoryInterface $segmentFactory;
16
17	3	public static function createWithDefaultSegments(): self
18		{
19	3	return new self(SegmentFactory::withDefaultSegments());
20		}
21
22	4	public function __construct(SegmentFactoryInterface $segmentFactory)
23		{
24	4	$this->segmentFactory = $segmentFactory;
25	4	}
26
27		/** @codeCoverageIgnore */
28		private function __clone()
29		{
30		}
31
32		/** @return TransactionMessage[] */
33	4	public function parse(string $fileContent): array
34		{
35	4	$parser = new Parser($fileContent);
36	4	$errors = $parser->errors();
37
38	4	if ($errors) {
		0 ignored issues – show Bug Best Practice introduced 2019-11-09 11:48 UTC by Report Bug Copy Issue Report The expression `$errors` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
39	1	throw InvalidFile::withErrors($errors);
40		}
41
42	3	$segmentList = SegmentList::factory($this->segmentFactory);
43	3	$segments = $segmentList->fromRaw($parser->get());
44
45	3	return TransactionMessage::groupSegmentsByMessage(...$segments);
46		}
47		}
48

Chemaclass / EdifactParser

Push — master ( 1c5d16...a9efcd )

EdifactParser::createWithDefaultSegments() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like