EdifactParser::__invoke() - Code Metrics - Inspection of "Refactor: apply dependency inversion" - Chemaclass/EdifactParser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#3)

by Chema

created 2020-05-28 18:09 UTC

EdifactParser::__invoke() A

↳ Parent: EdifactParser

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace EdifactParser;

use EDI\Parser;
use EdifactParser\Exception\InvalidFile;
use EdifactParser\Segments\SegmentFactory;
use EdifactParser\Segments\SegmentFactoryInterface;

/** @psalmphp-immutable */
final class EdifactParser
{
    private SegmentFactoryInterface $segmentFactory;

    public static function create(?SegmentFactoryInterface $segmentFactory = null): self
    {
        return new self($segmentFactory ?? new SegmentFactory());
    }

    private function __construct(SegmentFactoryInterface $segmentFactory)
    {
        $this->segmentFactory = $segmentFactory;
    }

    public function __invoke(string $fileContent): TransactionResult
    {
        return $this->parse($fileContent);
    }

    public function parse(string $fileContent): TransactionResult
    {
        $parser = new Parser($fileContent);
        $errors = $parser->errors();

        if ($errors) {

            throw InvalidFile::withErrors($errors);
        }

        $segmentedValues = SegmentedValues::factory($this->segmentFactory)->fromRaw($parser->get());

        return TransactionResult::fromSegmentedValues($segmentedValues);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace EdifactParser;
6
7		use EDI\Parser;
8		use EdifactParser\Exception\InvalidFile;
9		use EdifactParser\Segments\SegmentFactory;
10		use EdifactParser\Segments\SegmentFactoryInterface;
11
12		/** @psalmphp-immutable */
13		final class EdifactParser
14		{
15		private SegmentFactoryInterface $segmentFactory;
16
17	4	public static function create(?SegmentFactoryInterface $segmentFactory = null): self
18		{
19	4	return new self($segmentFactory ?? new SegmentFactory());
20		}
21
22	4	private function __construct(SegmentFactoryInterface $segmentFactory)
23		{
24	4	$this->segmentFactory = $segmentFactory;
25	4	}
26
27	1	public function __invoke(string $fileContent): TransactionResult
28		{
29	1	return $this->parse($fileContent);
30		}
31
32	4	public function parse(string $fileContent): TransactionResult
33		{
34	4	$parser = new Parser($fileContent);
35	4	$errors = $parser->errors();
36
37	4	if ($errors) {
		0 ignored issues – show Bug Best Practice introduced 2019-11-09 11:48 UTC by Report Bug Copy Issue Report The expression `$errors` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
38	1	throw InvalidFile::withErrors($errors);
39		}
40
41	3	$segmentedValues = SegmentedValues::factory($this->segmentFactory)->fromRaw($parser->get());
42
43	3	return TransactionResult::fromSegmentedValues($segmentedValues);
44		}
45		}
46

Chemaclass / EdifactParser

Pull Request — master (#3)

EdifactParser::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like