Chekote\NounStore\Key\IsPossessiveTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	possessiveNouns()	0	6	1
A	nonPossessiveNouns()	0	4	1
A	testReturnsTrueForPossessiveNoun()	0	5	1
A	testReturnsFalseForNonPossessiveNoun()	0	5	1
A	setUp()	0	6	1

<?php namespace Chekote\NounStore\Key;

use Chekote\Phake\Phake;

/**
 * @covers \Chekote\NounStore\Key::isPossessive()
 */
class IsPossessiveTest extends KeyTest
{
  public function setUp()
  {
    parent::setUp();

    /* @noinspection PhpUndefinedMethodInspection */
    Phake::when($this->key)->isPossessive(Phake::anyParameters())->thenCallParent();

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Phake::when() does only seem to accept Phake_IMock, maybe add an additional type check?

  }

  /**
   * @dataProvider possessiveNouns
   */
  public function testReturnsTrueForPossessiveNoun($noun) {
    /* @noinspection PhpUndefinedMethodInspection */
    $this->assertTrue(
        Phake::makeVisible($this->key)->isPossessive($noun),

The method isPossessive() does not exist on Chekote\Phake\Proxies\VisibilityProxy. Since you implemented __call, consider adding a @method annotation.

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Chekote\Phake\Phake::makeVisible() does only seem to accept Phake_IMock, maybe add an additional type check?

        "'$noun' should be considered a possessive noun"
    );
  }

  /**
   * Data provider of possessive nouns
   *
   * @return string[]
   */
  public function possessiveNouns() {
    return [

The expression return array(array('Customer's Car'), array('8th Customer's Car'), array('Customer's 2nd Car'), array('7th Customer's 4th Car')) returns the type array<integer,array<integer,string>> which is incompatible with the documented return type string[].

        ["Customer's Car"],
        ["8th Customer's Car"],
        ["Customer's 2nd Car"],
        ["7th Customer's 4th Car"],
    ];
  }

  /**
   * @dataProvider nonPossessiveNouns
   */
  public function testReturnsFalseForNonPossessiveNoun($noun) {
    /* @noinspection PhpUndefinedMethodInspection */
    $this->assertFalse(
        Phake::makeVisible($this->key)->isPossessive($noun),

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Chekote\Phake\Phake::makeVisible() does only seem to accept Phake_IMock, maybe add an additional type check?

        "'$noun' should not be considered a possessive noun"
    );
  }

  /**
   * Data provider of non possessive nouns
   *
   * @return string[]
   */
  public function nonPossessiveNouns() {
    return [

The expression return array(array('Item'), array('1st Item')) returns the type array<integer,array<integer,string>> which is incompatible with the documented return type string[].

        ['Item'],
        ['1st Item'],
    ];
  }
}