GetTest::testInvalidArgumentExceptionBubblesUpFromKeyExists() - Code Metrics - Inspection of "Drop support for index args." - Chekote/noun-store - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 3.0 (#30)

by Donald

created 2018-08-20 14:48 UTC

testInvalidArgumentExceptionBubblesUpFromKeyExists() A

↳ Parent: GetTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	5
dl	0
loc	11
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php namespace Chekote\NounStore\Store;

use Chekote\NounStore\Key\KeyTest;
use Chekote\Phake\Phake;
use InvalidArgumentException;

/**
 * @covers \Chekote\NounStore\Store::get()
 */
class GetTest extends StoreTest
{
    public function setUp()
    {
        parent::setUp();

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::when($this->store)->get(Phake::anyParameters())->thenCallParent();
        Phake::when(/** @scrutinizer ignore-type */ $this->store)->get(Phake::anyParameters())->thenCallParent();
    }

    public function testKeyIsParsedAndParsedValuesAreUsed()
    {
        $key = '2nd ' . StoreTest::KEY;
        $parsedKey = StoreTest::KEY;
        $parsedIndex = 1;

        /* @noinspection PhpUndefinedMethodInspection */
        {
            Phake::expect($this->store, 1)->keyExists($key)->thenReturn(true);
            Phake::expect($this->store, 1)->/** @scrutinizer ignore-call */ keyExists($key)->thenReturn(true);
            Phake::expect($this->key, 1)->parse($key)->thenReturn([$parsedKey, $parsedIndex]);
            Phake::expect(/** @scrutinizer ignore-type */ $this->key, 1)->parse($key)->thenReturn([$parsedKey, $parsedIndex]);
        }

        $this->assertEquals(StoreTest::SECOND_VALUE, $this->store->get($key));
        $this->assertEquals(StoreTest::SECOND_VALUE, $this->store->/** @scrutinizer ignore-call */ get($key));
    }

    public function testInvalidArgumentExceptionBubblesUpFromKeyExists()
    {
        $exception = new InvalidArgumentException('Key syntax is invalid');

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::expect($this->store, 1)->keyExists(KeyTest::INVALID_KEY)->thenThrow($exception);
        Phake::expect(/** @scrutinizer ignore-type */ $this->store, 1)->keyExists(KeyTest::INVALID_KEY)->thenThrow($exception);

        $this->expectException(get_class($exception));
        $this->expectExceptionMessage($exception->getMessage());

        $this->store->get(KeyTest::INVALID_KEY);
    }

    // If the Key service is behaving properly, this should never actually be possible. But we test the behavior
    // here to ensure that our method behaves correctly should the impossible ever occur.
    public function testInvalidArgumentExceptionBubblesUpFromParse()
    {
        $exception = new InvalidArgumentException('Key syntax is invalid');

        /* @noinspection PhpUndefinedMethodInspection */
        {
            Phake::expect($this->store, 1)->keyExists(KeyTest::INVALID_KEY)->thenReturn(true);
            Phake::expect(/** @scrutinizer ignore-type */ $this->store, 1)->keyExists(KeyTest::INVALID_KEY)->thenReturn(true);
            Phake::expect($this->key, 1)->parse(KeyTest::INVALID_KEY)->thenThrow($exception);
            Phake::expect(/** @scrutinizer ignore-type */ $this->key, 1)->parse(KeyTest::INVALID_KEY)->thenThrow($exception);
        }

        $this->expectException(get_class($exception));
        $this->expectExceptionMessage($exception->getMessage());

        $this->store->get(KeyTest::INVALID_KEY);
    }

    public function testReturnsNullWhenKeyDoesNotExist()
    {
        $key = '3rd ' . StoreTest::KEY;

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::expect($this->store, 1)->keyExists($key)->thenReturn(false);
        Phake::expect(/** @scrutinizer ignore-type */ $this->store, 1)->keyExists($key)->thenReturn(false);

        $this->assertNull($this->store->get($key));
    }

    public function testLastItemIsReturnedWhenParsedIndexIsNull()
    {
        $key = StoreTest::KEY;
        $parsedKey = $key;
        $parsedIndex = null;

        /* @noinspection PhpUndefinedMethodInspection */
        {
            Phake::expect($this->store, 1)->keyExists($key)->thenReturn(true);
            Phake::expect(/** @scrutinizer ignore-type */ $this->store, 1)->keyExists($key)->thenReturn(true);
            Phake::expect($this->key, 1)->parse($key)->thenReturn([$parsedKey, $parsedIndex]);
            Phake::expect(/** @scrutinizer ignore-type */ $this->key, 1)->parse($key)->thenReturn([$parsedKey, $parsedIndex]);
        }

        $this->assertEquals(StoreTest::SECOND_VALUE, $this->store->get($key));
    }

    public function testIndexItemIsReturnedWhenParsedIndexIsNotNull()
    {
        $key = '1st ' . StoreTest::KEY;
        $parsedKey = StoreTest::KEY;
        $parsedIndex = 0;

        /* @noinspection PhpUndefinedMethodInspection */
        {
            Phake::expect($this->store, 1)->keyExists($key)->thenReturn(true);
            Phake::expect(/** @scrutinizer ignore-type */ $this->store, 1)->keyExists($key)->thenReturn(true);
            Phake::expect($this->key, 1)->parse($key)->thenReturn([$parsedKey, $parsedIndex]);
            Phake::expect(/** @scrutinizer ignore-type */ $this->key, 1)->parse($key)->thenReturn([$parsedKey, $parsedIndex]);
        }

        $this->assertEquals(StoreTest::FIRST_VALUE, $this->store->get($key));
    }
}


Chekote / noun-store

Pull Request — 3.0 (#30)

testInvalidArgumentExceptionBubblesUpFromKeyExists() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like