Chekote\NounStore\Store\SetTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testSetOnceStoresValue()	0	13	1
A	setUp()	0	6	1
A	testSetTwiceForSameKeyStoresMultipleValues()	0	15	1

<?php namespace Chekote\NounStore\Store;

use Chekote\NounStore\Store;
use Chekote\Phake\Phake;
use ReflectionClass;

class SetTest extends StoreTest
{
    public function setUp()
    {
        parent::setUp();

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::when($this->store)->set(Phake::anyParameters())->thenCallParent();

It seems like $this->store can also be of type Chekote\NounStore\Store; however, parameter $mock of Phake::when() does only seem to accept Phake_IMock, maybe add an additional type check?

    }

    /**
     * Tests that calling store::set once stores the value correctly.
     */
    public function testSetOnceStoresValue()
    {
        $key = 'My Key';
        $value = 'My Value';

        $class = new ReflectionClass(Store::class);
        $nouns = $class->getProperty('nouns');
        $nouns->setAccessible(true);

        $this->store->set($key, $value);

The method set() does not exist on Phake_IMock.

        $this->assertCount(1, $nouns->getValue($this->store)[$key]);
        $this->assertEquals($value, $nouns->getValue($this->store)[$key][0]);
    }

    /**
     * Tests that calling store::set twice for the same key stores both values correctly.
     */
    public function testSetTwiceForSameKeyStoresMultipleValues()
    {
        $key = 'My Key';
        $value1 = 'My Value';
        $value2 = 'My Second Value';

        $this->store->set($key, $value1);
        $this->store->set($key, $value2);

        $store = Phake::makeVisible($this->store);

It seems like $this->store can also be of type Chekote\NounStore\Store; however, parameter $mock of Chekote\Phake\Phake::makeVisible() does only seem to accept Phake_IMock, maybe add an additional type check?

        /* @noinspection PhpUndefinedFieldInspection */
        {
            $this->assertCount(2, $store->nouns[$key]);

The property nouns does not exist on Chekote\Phake\Proxies\VisibilityProxy. Since you implemented __get, consider adding a @property annotation.

            $this->assertEquals($value1, $store->nouns[$key][0]);
            $this->assertEquals($value2, $store->nouns[$key][1]);
        }
    }
}