Unit\Chekote\NounStore\Store\SetTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testSetOnceStoresValue()	0	12	1
A	testSetTwiceForSameKeyStoresMultipleValues()	0	15	1
A	setUp()	0	6	1

<?php namespace Unit\Chekote\NounStore\Store;

use Unit\Chekote\Phake\Phake;

class SetTest extends StoreTest
{
    public function setUp()
    {
        parent::setUp();

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::when($this->store)->set(Phake::anyParameters())->thenCallParent();

It seems like $this->store can also be of type Chekote\NounStore\Store; however, parameter $mock of Phake::when() does only seem to accept Phake_IMock, maybe add an additional type check?

    }

    /**
     * Tests that calling store::set once stores the value correctly.
     */
    public function testSetOnceStoresValue()
    {
        $key = 'My Key';
        $value = 'My Value';

        $this->store->set($key, $value);

The method set() does not exist on Phake_IMock.

        $store = Phake::makeVisible($this->store);

It seems like $this->store can also be of type Chekote\NounStore\Store; however, parameter $mock of Unit\Chekote\Phake\Phake::makeVisible() does only seem to accept Phake_IMock, maybe add an additional type check?

        /* @noinspection PhpUndefinedFieldInspection */
        {
            $this->assertCount(1, $store->nouns[$key]);

The property nouns does not exist on Unit\Chekote\Phake\Proxies\VisibilityProxy. Since you implemented __get, consider adding a @property annotation.

            $this->assertEquals($value, $store->nouns[$key][0]);
        }
    }

    /**
     * Tests that calling store::set twice for the same key stores both values correctly.
     */
    public function testSetTwiceForSameKeyStoresMultipleValues()
    {
        $key = 'My Key';
        $value1 = 'My Value';
        $value2 = 'My Second Value';

        $this->store->set($key, $value1);
        $this->store->set($key, $value2);

        $store = Phake::makeVisible($this->store);

It seems like $this->store can also be of type Chekote\NounStore\Store; however, parameter $mock of Unit\Chekote\Phake\Phake::makeVisible() does only seem to accept Phake_IMock, maybe add an additional type check?

        /* @noinspection PhpUndefinedFieldInspection */
        {
            $this->assertCount(2, $store->nouns[$key]);

The property nouns does not exist on Unit\Chekote\Phake\Proxies\VisibilityProxy. Since you implemented __get, consider adding a @property annotation.

            $this->assertEquals($value1, $store->nouns[$key][0]);
            $this->assertEquals($value2, $store->nouns[$key][1]);
        }
    }
}