Unit\Chekote\NounStore\Store\KeyValueContainsTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testReturn()	0	10	1
A	returnDataProvider()	0	6	1
A	testInvalidArgumentExceptionBubblesUpFromGet()	0	11	1
A	setUp()	0	6	1

<?php namespace Unit\Chekote\NounStore\Store;

use Unit\Chekote\NounStore\Key\KeyTest;
use Unit\Chekote\Phake\Phake;
use InvalidArgumentException;

/**
 * @covers \Chekote\NounStore\Store::keyValueContains()
 */
class KeyValueContainsTest extends StoreTest
{
    public function setUp()
    {
        parent::setUp();

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::when($this->store)->keyValueContains(Phake::anyParameters())->thenCallParent();

It seems like $this->store can also be of type Chekote\NounStore\Store; however, parameter $mock of Phake::when() does only seem to accept Phake_IMock, maybe add an additional type check?

    }

    public function testInvalidArgumentExceptionBubblesUpFromGet()
    {
        $exception = new InvalidArgumentException('Key syntax is invalid');

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::expect($this->store, 1)->get(KeyTest::INVALID_KEY)->thenThrow($exception);

It seems like $this->store can also be of type Chekote\NounStore\Store; however, parameter $mock of Unit\Chekote\Phake\Phake::expect() does only seem to accept Phake_IMock, maybe add an additional type check?

The method get() does not exist on Unit\Chekote\Phake\Expectation. Since you implemented __call, consider adding a @method annotation.

        $this->expectException(get_class($exception));
        $this->expectExceptionMessage($exception->getMessage());

        $this->store->keyValueContains(KeyTest::INVALID_KEY, "Doesn't matter");

The method keyValueContains() does not exist on Phake_IMock.

    }

    public function returnDataProvider()
    {
        return [
            // storedValue,      checkedValue, expectedResult
            [ 'This is a value', 'is a',       true           ],
            [ 'This is a value', 'words',      false          ],
        ];
    }

    /**
     * @dataProvider returnDataProvider
     * @param string $storedValue    the value that should be in the store and will be returned by the mocked get()
     * @param string $checkedValue   the value that will be passed to keyValueContains()
     * @param bool   $expectedResult the expected results from keyExists()
     */
    public function testReturn($storedValue, $checkedValue, $expectedResult)
    {
        $key = StoreTest::KEY;
        $parsedKey = $key;
        $parsedIndex = null;

The assignment to $parsedIndex is dead and can be removed.

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::expect($this->store, 1)->get($parsedKey)->thenReturn($storedValue);

It seems like $this->store can also be of type Chekote\NounStore\Store; however, parameter $mock of Unit\Chekote\Phake\Phake::expect() does only seem to accept Phake_IMock, maybe add an additional type check?

        $this->assertEquals($expectedResult, $this->store->keyValueContains($key, $checkedValue));
    }
}