Chekote\NounStore\Key\ParseTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	6	1
A	testInvalidArgumentExceptionBubblesUpFromProcessMatches()	0	11	1
A	testInvalidKeyThrowsInvalidArgumentException()	0	6	1
A	testValidKeyIsProcessed()	0	12	1

<?php namespace Chekote\NounStore\Key;

use Chekote\NounStore\Key;
use Chekote\Phake\Phake;
use InvalidArgumentException;

/**
 * @covers \Chekote\NounStore\Key::parse()
 */
class ParseTest extends KeyTest
{
    public function setUp()
    {
        parent::setUp();

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::when($this->key)->parse(Phake::anyParameters())->thenCallParent();

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Phake::when() does only seem to accept Phake_IMock, maybe add an additional type check?

    }

    public function testInvalidKeyThrowsInvalidArgumentException()
    {
        $this->expectException(InvalidArgumentException::class);
        $this->expectExceptionMessage('Key is not valid. Must match pattern ' . Key::REGEX_KEY);

        $this->key->parse("'''''");

The method parse() does not exist on Phake_IMock.

    }

    public function testValidKeyIsProcessed()
    {
        $key = "10th thing's address";
        $index = null;

        $pregResult = ["10th thing's address", '10th ', '10', 'thing', "'s address", 'address'];
        $processResult = ['thing', 9, 'address'];

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::expect($this->key, 1)->processMatches($index, $pregResult)->thenReturn($processResult);

The method processMatches() does not exist on Chekote\Phake\Expectation. Since you implemented __call, consider adding a @method annotation.

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Chekote\Phake\Phake::expect() does only seem to accept Phake_IMock, maybe add an additional type check?

        $this->assertEquals($processResult, $this->key->parse($key, $index));
    }

    public function testInvalidArgumentExceptionBubblesUpFromProcessMatches()
    {
        $exception = new InvalidArgumentException('nth must be equal to or larger than 1');

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::expect($this->key, 1)->processMatches(Phake::anyParameters())->thenThrow($exception);

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Chekote\Phake\Phake::expect() does only seem to accept Phake_IMock, maybe add an additional type check?

        $this->expectException(get_class($exception));
        $this->expectExceptionMessage($exception->getMessage());

        $this->key->parse('0th thing');
    }
}