KeyValueContainsTest::parseExceptionScenariosDataProvider() - Code Metrics - Inspection of "Convert all tests to London TDD style" - Chekote/noun-store - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#16)

by Donald

created 2018-01-15 22:20 UTC

A

↳ Parent: KeyValueContainsTest::testInvalidArgumentExceptionBubblesUpFromParse()

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	2
nc	1
nop	0

<?php namespace Chekote\NounStore\Store;

use Chekote\Phake\Phake;
use InvalidArgumentException;

/**
 * @covers \Chekote\NounStore\Store::keyValueContains()
 */
class KeyValueContainsTest extends StoreTest
{
    public function setUp()
    {
        parent::setUp();

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::when($this->store)->keyValueContains(Phake::anyParameters())->thenCallParent();
        Phake::when(/** @scrutinizer ignore-type */ $this->store)->keyValueContains(Phake::anyParameters())->thenCallParent();
    }

    public function testKeyIsParsedAndParsedValuesAreUsed()
    {
        $key = '2nd ' . StoreTest::KEY;
        $index = null;
        $parsedKey = StoreTest::KEY;
        $parsedIndex = 1;
        $value = substr(self::SECOND_VALUE, 0, 2);

        /** @noinspection PhpUndefinedMethodInspection */
        {
            Phake::when($this->key)->parse($key, $index)->thenReturn([$parsedKey, $parsedIndex]);
            Phake::when(/** @scrutinizer ignore-type */ $this->key)->parse($key, $index)->thenReturn([$parsedKey, $parsedIndex]);
            Phake::when($this->store)->get($parsedKey, $parsedIndex)->thenReturn(self::SECOND_VALUE);
            Phake::when(/** @scrutinizer ignore-type */ $this->store)->get($parsedKey, $parsedIndex)->thenReturn(self::SECOND_VALUE);
        }

        $this->assertTrue($this->store->keyValueContains($key, $value, $index));
        $this->assertTrue($this->store->/** @scrutinizer ignore-call */ keyValueContains($key, $value, $index));

        /** @noinspection PhpUndefinedMethodInspection */
        {
            Phake::verify($this->key)->parse($key, $index);
            Phake::verify(/** @scrutinizer ignore-type */ $this->key)->parse($key, $index);
            Phake::verify($this->store)->get($parsedKey, $parsedIndex);
            Phake::verify(/** @scrutinizer ignore-type */ $this->store)->get($parsedKey, $parsedIndex);
        }
    }

    public function testInvalidArgumentExceptionBubblesUpFromParse()
    {
        $key = '10th Thing';
        $index = 5;
        $exception = new InvalidArgumentException(
            "$index was provided for index param when key '$key' contains an nth value, but they do not match"
        );

        /** @noinspection PhpUndefinedMethodInspection */
        Phake::when($this->key)->parse($key, $index)->thenThrow($exception);
        Phake::when(/** @scrutinizer ignore-type */ $this->key)->parse($key, $index)->thenThrow($exception);

        $this->assertException($exception, function () use ($key, $index) {
            $this->store->keyValueContains($key, "Doesn't matter", $index);
        });

        /** @noinspection PhpUndefinedMethodInspection */
        Phake::verify($this->key)->parse($key, $index);
        Phake::verify(/** @scrutinizer ignore-type */ $this->key)->parse($key, $index);
    }

    public function returnDataProvider() {
        return [
        //    storedValue,       checkedValue, expectedResult
            [ 'This is a value', 'is a',       true           ],
            [ 'This is a value', 'words',      false          ],
        ];
    }

    /**
     * @dataProvider returnDataProvider
     * @param string $storedValue    the value that should be in the store and will be returned by the mocked get()
     * @param string $checkedValue   the value that will be passed to keyValueContains()
     * @param bool   $expectedResult the expected results from keyExists()
     */
    public function testReturn($storedValue, $checkedValue, $expectedResult)
    {
        $key = StoreTest::KEY;
        $index = null;
        $parsedKey = $key;
        $parsedIndex = $index;

        /** @noinspection PhpUndefinedMethodInspection */
        {
            Phake::when($this->key)->parse($key, $index)->thenReturn([$parsedKey, $parsedIndex]);
            Phake::when(/** @scrutinizer ignore-type */ $this->key)->parse($key, $index)->thenReturn([$parsedKey, $parsedIndex]);
            Phake::when($this->store)->get($parsedKey, $parsedIndex)->thenReturn($storedValue);
            Phake::when(/** @scrutinizer ignore-type */ $this->store)->get($parsedKey, $parsedIndex)->thenReturn($storedValue);
        }

        $this->assertEquals($expectedResult, $this->store->keyValueContains($key, $checkedValue, $index));

        /** @noinspection PhpUndefinedMethodInspection */
        {
            Phake::verify($this->key)->parse($key, $index);
            Phake::verify(/** @scrutinizer ignore-type */ $this->key)->parse($key, $index);
            Phake::verify($this->store)->get($parsedKey, $parsedIndex);
            Phake::verify(/** @scrutinizer ignore-type */ $this->store)->get($parsedKey, $parsedIndex);
        }
    }
}


Chekote / noun-store

Pull Request — master (#16)

A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like