Chekote\NounStore\Key\SplitPossessionsTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	nouns()	0	9	1
A	testSuccessScenario()	0	6	1
A	setUp()	0	6	1

<?php namespace Chekote\NounStore\Key;

use Chekote\Phake\Phake;
//use InvalidArgumentException;

50% of this comment could be valid code. Did you maybe forget this after debugging?

/**
 * @covers \Chekote\NounStore\Key::splitPossessions()
 */
class SplitPossessionsTest extends KeyTest
{
    public function setUp()
    {
        parent::setUp();

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::when($this->key)->splitPossessions(Phake::anyParameters())->thenCallParent();

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Phake::when() does only seem to accept Phake_IMock, maybe add an additional type check?

    }

    /**
     * @dataProvider nouns
     */
    public function testSuccessScenario($key, array $parts)
    {
        /* @noinspection PhpUndefinedMethodInspection */
        $this->assertSame(
            $parts,
            Phake::makeVisible($this->key)->splitPossessions($key)

The method splitPossessions() does not exist on Chekote\Phake\Proxies\VisibilityProxy. Since you implemented __call, consider adding a @method annotation.

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Chekote\Phake\Phake::makeVisible() does only seem to accept Phake_IMock, maybe add an additional type check?

        );
    }

    /**
     * Data provider of possessive nouns and their component nouns.
     *
     * @return array[]
     */
    public function nouns()
    {
        return [
            ["Customer",                       ['Customer'                        ]],
            ["Customer's Car",                 ['Customer',     'Car'             ]],
            ["8th Customer's Car",             ['8th Customer', 'Car'             ]],
            ["Customer's 2nd Car",             ['Customer',     '2nd Car'         ]],
            ["7th Customer's 4th Car",         ['7th Customer', '4th Car'         ]],
            ["7th Customer's 4th Car's Wheel", ['7th Customer', '4th Car', 'Wheel']],
        ];
    }
}