Chekote\NounStore\Store\KeyExistsTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	6	1
A	testReturn()	0	6	1
A	testInvalidArgumentExceptionBubblesUpFromParse()	0	15	1
A	returnDataProvider()	0	8	1

<?php namespace Chekote\NounStore\Store;

use Chekote\Phake\Phake;
use InvalidArgumentException;

/**
 * @covers \Chekote\NounStore\Store::keyExists()
 */
class KeyExistsTest extends StoreTest
{
    public function setUp()
    {
        parent::setUp();

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::when($this->store)->keyExists(Phake::anyParameters())->thenCallParent();

It seems like $this->store can also be of type Chekote\NounStore\Store; however, parameter $mock of Phake::when() does only seem to accept Phake_IMock, maybe add an additional type check?

    }

    public function testInvalidArgumentExceptionBubblesUpFromParse()
    {
        $key = '10th Thing';
        $index = 5;
        $exception = new InvalidArgumentException(
            "$index was provided for index param when key '$key' contains an nth value, but they do not match"
        );

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::expect($this->key, 1)->parse($key, $index)->thenThrow($exception);

The method parse() does not exist on Chekote\Phake\Expectation. Since you implemented __call, consider adding a @method annotation.

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Chekote\Phake\Phake::expect() does only seem to accept Phake_IMock, maybe add an additional type check?

        $this->expectException(get_class($exception));
        $this->expectExceptionMessage($exception->getMessage());

        $this->store->keyExists($key, $index);

The method keyExists() does not exist on Phake_IMock.

    }

    public function returnDataProvider()
    {
        return [
        //    key,            index, expectedResult
            [ 'No such key',   null, false ], // missing key
            [ StoreTest::KEY,     2, false ], // missing index
            [ StoreTest::KEY,  null, true  ], // present key
            [ StoreTest::KEY,     1, true  ], // present index
        ];
    }

    /**
     * @dataProvider returnDataProvider
     * @param string $key            the key to pass to keyExists, and which will be returned from the mocked parse()
     * @param int    $index          the index to pass to KeyExists, and which will be returned from the mocked parse()
     * @param bool   $expectedResult the expected results from keyExists()
     */
    public function testReturn(string $key, ?int $index, bool $expectedResult)
    {
        /* @noinspection PhpUndefinedMethodInspection */
        Phake::expect($this->key, 1)->parse($key, $index)->thenReturn([$key, $index]);

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Chekote\Phake\Phake::expect() does only seem to accept Phake_IMock, maybe add an additional type check?

        $this->assertEquals($expectedResult, $this->store->keyExists($key, $index));
    }
}