Chekote\NounStore\Key\BuildTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	6	1
A	testNullIndexReturnsUnmodifiedKey()	0	5	1
A	testInvalidArgumentExceptionBubblesUpFromGetOrdinal()	0	15	1
A	testNonNullIndexReturnsModifiedKey()	0	10	1

<?php namespace Chekote\NounStore\Key;

use Chekote\Phake\Phake;
use InvalidArgumentException;

/**
 * @covers \Chekote\NounStore\Key::build()
 */
class BuildTest extends KeyTest
{
    public function setUp()
    {
        parent::setUp();

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::when($this->key)->build(Phake::anyParameters())->thenCallParent();

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Phake::when() does only seem to accept Phake_IMock, maybe add an additional type check?

    }

    public function testNullIndexReturnsUnmodifiedKey()
    {
        $key = 'Thing';

        $this->assertEquals($key, $this->key->build($key, null));

The method build() does not exist on Phake_IMock.

    }

    public function testNonNullIndexReturnsModifiedKey()
    {
        $key = 'Thing';
        $index = 9;
        $nth = $index + 1;

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::expect($this->key, 1)->getOrdinal($nth)->thenReturn('th');

The method getOrdinal() does not exist on Chekote\Phake\Expectation. Since you implemented __call, consider adding a @method annotation.

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Chekote\Phake\Phake::expect() does only seem to accept Phake_IMock, maybe add an additional type check?

        $this->assertEquals('10th Thing', $this->key->build($key, $index));
    }

    public function testInvalidArgumentExceptionBubblesUpFromGetOrdinal()
    {
        $key = 'Thing';
        $index = -2;
        $nth = $index + 1;

        $exception = new InvalidArgumentException('$nth must be a positive number');

        /* @noinspection PhpUndefinedMethodInspection */
        Phake::expect($this->key, 1)->getOrdinal($nth)->thenThrow($exception);

It seems like $this->key can also be of type Chekote\NounStore\Key; however, parameter $mock of Chekote\Phake\Phake::expect() does only seem to accept Phake_IMock, maybe add an additional type check?

        $this->expectException(get_class($exception));
        $this->expectExceptionMessage($exception->getMessage());

        $this->key->build($key, $index);
    }
}