Cellcote / laravel-proxify

src/ApiProxyServiceProvider.php

<?php

/**
 * @package   cellcote/laravel-proxify
 * @author    Michele Andreoli <michi.andreoli[at]gmail.com>
 * @copyright Copyright (c) Michele Andreoli
 * @author    Rik Schreurs <rik.schreurs[at]mail.com>
 * @copyright Copyright (c) Rik Schreurs
 * @license   http://mit-license.org/
 * @link      https://github.com/cellcote/laravel-proxify
 */

namespace Cellcote\LaravelProxify;

use Illuminate\Support\ServiceProvider;
use Illuminate\Http\JsonResponse;
use Cellcote\LaravelProxify\Exceptions\ProxyException;

class ApiProxyServiceProvider extends ServiceProvider {

    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var bool
     */
    protected $defer = false;

    /**
     * Bootstrap the application events.
     *
     * @return void
     */
    public function boot() {
        $this->publishes([
            __DIR__ . '/config/proxy.php' => config_path('proxy.php'),
        ]);

    }

    /**
     * Register the service provider.
     *
     * @return void
     */
    public function register() {
        //$this->registerErrorHandlers();

84% of this comment could be valid code. Did you maybe forget this after debugging?

        $this->registerApiProxy();
    }

    /**
     * Register ApiProxy with the IoC container
     * @return void
     */
    public function registerApiProxy() {
        $this->app->bindShared('api-proxy.proxy', function($app) {
            $params = $app['config']['proxy'];
            $proxy = new Proxy($params);
            return $proxy;
        });

        $this->app->bind('Cellcote\LaravelProxify\Proxy', function($app) {
            return $app['api-proxy.proxy'];
        });
    }

    /**
     * Get the services provided by the provider.
     *
     * @return string[]
     */
    public function provides() {
        return array('api-proxy.proxy');
    }

    /**
     * Register the ApiProxy error handlers
     * @return void
     */
    private function registerErrorHandlers() {

This method is not used, and could be removed.

        $this->app->error(function(ProxyException $ex) {

The method error() does not seem to exist on object<Illuminate\Contracts\Foundation\Application>.

            if (\Request::ajax() && \Request::wantsJson()) {
                return new JsonResponse([
                    'error' => $ex->errorType,
                    'error_description' => $ex->getMessage()
                ], $ex->httpStatusCode, $ex->getHttpHeaders()
                );
            }

            return \View::make('api-proxy-laravel::proxy_error', array(
                'header' => $ex->getHttpHeaders()[0],
                'code' => $ex->httpStatusCode,
                'error' => $ex->errorType,
                'message' => $ex->getMessage()
            ));
        });
    }

}