Parsedown::inlineImage() - Code Metrics - Inspection of "Add image resize feature" - Cecilapp/Cecil - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature-assets ( 7e7631 )

by Arnaud

created 2020-02-17 15:22 UTC

Parsedown::inlineImage() B

↳ Parent: Parsedown

Complexity

Conditions	6
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	40
rs	8.6577
c	0
b	0
f	0
cc	6
nc	6
nop	1

<?php
/*
 * Copyright (c) Arnaud Ligny <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Cecil\Converter;

use Cecil\Config;
use Cecil\Util;
use Intervention\Image\ImageManagerStatic as Image;
use ParsedownExtra;

class Parsedown extends ParsedownExtra
{
    // https://regex101.com/r/EhIh5N/2
    const PATTERN = '(.*)(\?|\&)([^=]+)\=([^&]+)';
    private $config;

    function __construct(Config $config = null)

    {
        $this->config = $config;
    }

    protected function inlineImage($excerpt)
    {
        $image = parent::inlineImage($excerpt);

        if (!isset($image)) {
            return null;
        }

        preg_match(
            '/'.self::PATTERN.'/s',
            $image['element']['attributes']['src'],
            $matches
        );

        if (!$matches) {

            return $image;
        }

        if (key_exists(3, $matches) && $matches[3] == 'resize') {
            $image['element']['attributes']['src'] = $matches[1];
            $resize = $matches[4];
        }

        if ($this->config === null) {
            return $image;
        }

        Util::getFS()->mkdir($this->config->getOutputPath().'/assets');

        Image::make($this->config->getStaticPath().'/'.$image['element']['attributes']['src'])
            ->resize($resize, null, function ($constraint) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                $constraint->aspectRatio();
                $constraint->upsize();
            })
            ->save($this->config->getOutputPath(). '/assets'.$image['element']['attributes']['src']);

        $image['element']['attributes']['src'] = '/assets'.$image['element']['attributes']['src'];

        return $image;
    }
}


1			<?php
2			/*
3			* Copyright (c) Arnaud Ligny <[email protected]>
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8
9			namespace Cecil\Converter;
10
11			use Cecil\Config;
12			use Cecil\Util;
13			use Intervention\Image\ImageManagerStatic as Image;
14			use ParsedownExtra;
15
16			class Parsedown extends ParsedownExtra
17			{
18			// https://regex101.com/r/EhIh5N/2
19			const PATTERN = '(.*)(\?\|\&)([^=]+)\=([^&]+)';
20			private $config;
21
22			function __construct(Config $config = null)
			0 ignored issues – show Best Practice introduced 2020-02-17 15:26 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
23			{
24			$this->config = $config;
25			}
26
27			protected function inlineImage($excerpt)
28			{
29			$image = parent::inlineImage($excerpt);
30
31			if (!isset($image)) {
32			return null;
33			}
34
35			preg_match(
36			'/'.self::PATTERN.'/s',
37			$image['element']['attributes']['src'],
38			$matches
39			);
40
41			if (!$matches) {
			0 ignored issues – show Bug Best Practice introduced 2020-02-17 15:26 UTC by Report Bug Copy Issue Report The expression `$matches` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
42			return $image;
43			}
44
45			if (key_exists(3, $matches) && $matches[3] == 'resize') {
46			$image['element']['attributes']['src'] = $matches[1];
47			$resize = $matches[4];
48			}
49
50			if ($this->config === null) {
51			return $image;
52			}
53
54			Util::getFS()->mkdir($this->config->getOutputPath().'/assets');
55
56			Image::make($this->config->getStaticPath().'/'.$image['element']['attributes']['src'])
57			->resize($resize, null, function ($constraint) {
			0 ignored issues – show Bug introduced 2020-02-17 15:26 UTC by Report Bug Copy Issue Report The variable `$resize` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
58			$constraint->aspectRatio();
59			$constraint->upsize();
60			})
61			->save($this->config->getOutputPath(). '/assets'.$image['element']['attributes']['src']);
62
63			$image['element']['attributes']['src'] = '/assets'.$image['element']['attributes']['src'];
64
65			return $image;
66			}
67			}
68

Cecilapp / Cecil

Push — feature-assets ( 7e7631 )

Parsedown::inlineImage() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like