NewPage::execute() - Code Metrics - Inspection of "Merge branch 'master' into Assets/Image" - Cecilapp/Cecil - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — Assets/Image ( bd550f...7a290d )

by Arnaud

created 2020-02-25 11:50 UTC

NewPage::execute() B

↳ Parent: NewPage

Complexity

Conditions	10
Paths	59

Size

Total Lines	61
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	10
eloc	40
nc	59
nop	2
dl	0
loc	61
rs	7.6666
c	2
b	0
f	0

How to fix Long Method Complexity

<?php
/*
 * This file is part of the Cecil/Cecil package.
 *
 * Copyright (c) Arnaud Ligny <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Cecil\Command;

use Cecil\Util\Plateform;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputDefinition;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;
use Symfony\Component\Process\Process;

class NewPage extends Command
{
    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setName('new:page')
            ->setDescription('Create a new page')
            ->setDefinition(
                new InputDefinition([
                    new InputArgument('name', InputArgument::REQUIRED, 'New page name'),
                    new InputArgument('path', InputArgument::OPTIONAL, 'Use the given path as working directory'),
                    new InputOption('force', 'f', InputOption::VALUE_NONE, 'Override the file if already exist'),
                    new InputOption('open', 'o', InputOption::VALUE_NONE, 'Open editor automatically'),
                    new InputOption('prefix', 'p', InputOption::VALUE_NONE, 'Add date (`YYYY-MM-DD`) as a prefix'),
                ])
            )
            ->setHelp('Create a new page file (with a default title and the current date).');
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $name = (string) $input->getArgument('name');
        $force = $input->getOption('force');
        $open = $input->getOption('open');
        $prefix = $input->getOption('prefix');

        try {
            $nameParts = pathinfo($name);
            $dirname = $nameParts['dirname'];
            $filename = $nameParts['filename'];
            $date = date('Y-m-d');
            $title = $filename;
            // date prefix?
            $datePrefix = '';
            if ($prefix) {
                $datePrefix = sprintf('%s-', $date);
            }
            // path
            $fileRelativePath = sprintf(
                '%s/%s%s%s.md',
                $this->getBuilder($output)->getConfig()->get('content.dir'),
                /** @scrutinizer ignore-type */ $this->getBuilder($output)->getConfig()->get('content.dir'),
                !$dirname ?: $dirname.'/',
                $datePrefix,
                $filename
            );
            $filePath = $this->getPath().'/'.$fileRelativePath;

            // file already exists?
            if ($this->fs->exists($filePath) && !$force) {
                $helper = $this->getHelper('question');
                $question = new ConfirmationQuestion(
                    sprintf('This page already exists. Do you want to override it? [y/n]', $this->getpath()),
                    false
                );
                if (!$helper->ask($input, $output, $question)) {
                    return;
                }
            }

            // create new file
            $fileContent = str_replace(
                ['%title%', '%date%'],
                [$title, $date],
                $this->findModel(sprintf('%s%s', !$dirname ?: $dirname.'/', $filename))
            );
            $this->fs->dumpFile($filePath, $fileContent);
            $output->writeln(sprintf('File "%s" created.', $fileRelativePath));

            // open editor?
            if ($open) {
                if (!$this->hasEditor($output)) {
                    $output->writeln('<comment>No editor configured.</comment>');
                }
                $this->openEditor($output, $filePath);
            }
        } catch (\Exception $e) {
            throw new \Exception(sprintf($e->getMessage()));
        }

        return 0;
    }

    /**
     * Find the page model and return its content.
     *
     * @param string $name
     *
     * @return string
     */
    protected function findModel(string $name): string
    {
        $section = strstr($name, '/', true);
        if ($section && file_exists($model = sprintf('%s/models/%s.md', $this->getPath(), $section))) {
            return file_get_contents($model);
        }
        if (file_exists($model = sprintf('%s/models/default.md', $this->getPath()))) {
            return file_get_contents($model);
        }

        return <<<'EOT'
---
title: '%title%'
date: '%date%'
draft: true
---

_[Your content here]_
EOT;
    }

    /**
     * Editor is configured?
     *
     * @param OutputInterface $output
     *
     * @return bool
     */
    protected function hasEditor(OutputInterface $output): bool
    {
        return (bool) $this->getBuilder($output)->getConfig()->get('editor');
    }

    /**
     * Open new file in editor (if configured).
     *
     * @param OutputInterface $output
     * @param string          $filePath
     *
     * @return void
     */
    protected function openEditor(OutputInterface $output, string $filePath)
    {
        if ($editor = $this->getBuilder($output)->getConfig()->get('editor')) {
            $command = sprintf('%s "%s"', $editor, $filePath);
            $command = sprintf('%s "%s"', /** @scrutinizer ignore-type */ $editor, $filePath);
            // Typora 4TW!
            if ($editor == 'typora') {
                if (Plateform::getOS() == Plateform::OS_OSX) {
                    $command = sprintf('open -a typora "%s"', $filePath);
                }
            }
            $process = Process::fromShellCommandline($command);
            $process->run();
            if (!$process->isSuccessful()) {
                throw new \Exception(sprintf('Can\'t run "%s".', $command));
            }
        }
    }
}


Cecilapp / Cecil

Push — Assets/Image ( bd550f...7a290d )

NewPage::execute() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like