DataLoad::process() - Code Metrics - Inspection of "Data loader support more file formats" - Cecilapp/Cecil - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature-data-loader ( e79fec )

by Arnaud

created 2020-01-29 12:12 UTC

DataLoad::process() B

↳ Parent: DataLoad

Complexity

Conditions	8
Paths	12

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	71
rs	7.3882
c	0
b	0
f	0
cc	8
nc	12
nop	0

How to fix Long Method

<?php
/*
 * Copyright (c) Arnaud Ligny <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Cecil\Step;

use Symfony\Component\Finder\Finder;
use Symfony\Component\Serializer\Encoder\JsonEncoder;
use Symfony\Component\Serializer\Encoder\XmlEncoder;
use Symfony\Component\Serializer\Encoder\YamlEncoder;
use Symfony\Component\Serializer\Encoder\CsvEncoder;
use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;
use Symfony\Component\Serializer\Serializer;
use Symfony\Component\Yaml\Yaml;

/**
 * Load data files.
 */
class DataLoad extends AbstractStep
{
    /**
     * {@inheritdoc}
     */
    public function init($options)
    {
        if (is_dir($this->builder->getConfig()->getDataPath())) {
            $this->process = true;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function process()
    {
        call_user_func_array($this->builder->getMessageCb(), ['DATA', 'Loading data']);

        $data = Finder::create()
            ->files()
            ->in($this->builder->getConfig()->getDataPath())
            ->name('/\.('.implode('|', $this->builder->getConfig()->get('data.ext')).')$/')
            ->sortByName(true);
        $max = count($data);
        $count = 0;

        // JSON
        $serializerJson = new Serializer([new ObjectNormalizer()], [new JsonEncoder()]);
        // XML
        $serializerXml = new Serializer([new ObjectNormalizer()], [new XmlEncoder()]);
        // YAML
        $serializerYaml = new Serializer([new ObjectNormalizer()], [new YamlEncoder()]);
        // CSV
        $serializerCsv = new Serializer([new ObjectNormalizer()], [new CsvEncoder()]);

        /* @var $file \Symfony\Component\Finder\SplFileInfo */
        foreach ($data as $file) {
            $count++;
            set_error_handler(
                function ($severity, $message, $file, $line) {
                    throw new \ErrorException($message, 0, $severity, $file, $line, null);
                }
            );
            $dataFile = $file->getContents();
            restore_error_handler();

            switch ($file->getExtension()) {
                case 'json':
                    $dataArray = $serializerJson->decode($dataFile, 'json');
                    break;
                case 'xml':
                    $dataArray = $serializerXml->decode($dataFile, 'xml');
                    break;
                case 'yml':
                case 'yaml':
                    $dataArray = $serializerYaml->decode($dataFile, 'yaml');
                    break;
                case 'csv':
                    $dataArray = $serializerCsv->decode($dataFile, 'csv');
                    break;
                default:
                    return;
                    break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            }

            $basename = $file->getBasename('.'.$file->getExtension());
            $subpath = \Cecil\Util::getFS()->makePathRelative(
                $file->getPath(),
                $this->builder->getConfig()->getDataPath()
            );
            $subpath = trim($subpath, './');
            $array = [];
            $path = $subpath ? $subpath.'/'.$basename : $basename;
            $this->pathToArray($array, $path, $dataArray);

            $dataArray = array_merge_recursive(
                $this->builder->getData(),
                $array
            );
            $this->builder->setData($dataArray);

            $message = sprintf('"%s" loaded', $path);
            call_user_func_array($this->builder->getMessageCb(), ['DATA_PROGRESS', $message, $count, $max]);
        }
    }

    private function pathToArray(&$arr, $path, $value, $separator = '/')
    {
        $keys = explode($separator, $path);

        foreach ($keys as $key) {
            $arr = &$arr[$key];
        }

        $arr = $value;
    }
}


1			<?php
2			/*
3			* Copyright (c) Arnaud Ligny <[email protected]>
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8
9			namespace Cecil\Step;
10
11			use Symfony\Component\Finder\Finder;
12			use Symfony\Component\Serializer\Encoder\JsonEncoder;
13			use Symfony\Component\Serializer\Encoder\XmlEncoder;
14			use Symfony\Component\Serializer\Encoder\YamlEncoder;
15			use Symfony\Component\Serializer\Encoder\CsvEncoder;
16			use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;
17			use Symfony\Component\Serializer\Serializer;
18			use Symfony\Component\Yaml\Yaml;
19
20			/**
21			* Load data files.
22			*/
23			class DataLoad extends AbstractStep
24			{
25			/**
26			* {@inheritdoc}
27			*/
28			public function init($options)
29			{
30			if (is_dir($this->builder->getConfig()->getDataPath())) {
31			$this->process = true;
32			}
33			}
34
35			/**
36			* {@inheritdoc}
37			*/
38			public function process()
39			{
40			call_user_func_array($this->builder->getMessageCb(), ['DATA', 'Loading data']);
41
42			$data = Finder::create()
43			->files()
44			->in($this->builder->getConfig()->getDataPath())
45			->name('/\.('.implode('\|', $this->builder->getConfig()->get('data.ext')).')$/')
46			->sortByName(true);
47			$max = count($data);
48			$count = 0;
49
50			// JSON
51			$serializerJson = new Serializer([new ObjectNormalizer()], [new JsonEncoder()]);
52			// XML
53			$serializerXml = new Serializer([new ObjectNormalizer()], [new XmlEncoder()]);
54			// YAML
55			$serializerYaml = new Serializer([new ObjectNormalizer()], [new YamlEncoder()]);
56			// CSV
57			$serializerCsv = new Serializer([new ObjectNormalizer()], [new CsvEncoder()]);
58
59			/* @var $file \Symfony\Component\Finder\SplFileInfo */
60			foreach ($data as $file) {
61			$count++;
62			set_error_handler(
63			function ($severity, $message, $file, $line) {
64			throw new \ErrorException($message, 0, $severity, $file, $line, null);
65			}
66			);
67			$dataFile = $file->getContents();
68			restore_error_handler();
69
70			switch ($file->getExtension()) {
71			case 'json':
72			$dataArray = $serializerJson->decode($dataFile, 'json');
73			break;
74			case 'xml':
75			$dataArray = $serializerXml->decode($dataFile, 'xml');
76			break;
77			case 'yml':
78			case 'yaml':
79			$dataArray = $serializerYaml->decode($dataFile, 'yaml');
80			break;
81			case 'csv':
82			$dataArray = $serializerCsv->decode($dataFile, 'csv');
83			break;
84			default:
85			return;
86			break;
			0 ignored issues – show Unused Code introduced 2020-01-29 12:14 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
87			}
88
89			$basename = $file->getBasename('.'.$file->getExtension());
90			$subpath = \Cecil\Util::getFS()->makePathRelative(
91			$file->getPath(),
92			$this->builder->getConfig()->getDataPath()
93			);
94			$subpath = trim($subpath, './');
95			$array = [];
96			$path = $subpath ? $subpath.'/'.$basename : $basename;
97			$this->pathToArray($array, $path, $dataArray);
98
99			$dataArray = array_merge_recursive(
100			$this->builder->getData(),
101			$array
102			);
103			$this->builder->setData($dataArray);
104
105			$message = sprintf('"%s" loaded', $path);
106			call_user_func_array($this->builder->getMessageCb(), ['DATA_PROGRESS', $message, $count, $max]);
107			}
108			}
109
110			private function pathToArray(&$arr, $path, $value, $separator = '/')
111			{
112			$keys = explode($separator, $path);
113
114			foreach ($keys as $key) {
115			$arr = &$arr[$key];
116			}
117
118			$arr = $value;
119			}
120			}
121

Cecilapp / Cecil

Push — feature-data-loader ( e79fec )

DataLoad::process() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like