Git::runGitCommand() - Code Metrics - Inspection of "Cleaning utils" - Cecilapp/Cecil - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — utils ( 4b317d )

by Arnaud

created 2020-02-25 10:10 UTC

Git::runGitCommand() A

↳ Parent: Git

Complexity

Conditions	3
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.6333
c	0
b	0
f	0
cc	3
nc	5
nop	1

<?php
/*
 * This file is part of the Cecil/Cecil package.
 *
 * Copyright (c) Arnaud Ligny <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Cecil\Util;

use Symfony\Component\Process\Process;

class Git

{
    /**
     * Runs a Git command on the repository.
     *
     * @param string $command The command.
     *
     * @throws \RuntimeException If the command failed.
     *
     * @return string The trimmed output from the command.
     */
    public static function runGitCommand(string $command): string
    {
        try {
            $process = new Process($command, __DIR__);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            if (0 === $process->run()) {
                return trim($process->getOutput());
            }

            throw new \RuntimeException(
                sprintf(
                    'The tag or commit hash could not be retrieved from "%s": %s',
                    __DIR__,
                    $process->getErrorOutput()
                )
            );
        } catch (\RuntimeException $exception) {
            throw new \RuntimeException('Process error');
        }
    }
}


1			<?php
2			/*
3			* This file is part of the Cecil/Cecil package.
4			*
5			* Copyright (c) Arnaud Ligny <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace Cecil\Util;
12
13			use Symfony\Component\Process\Process;
14
15			class Git
			0 ignored issues – show Coding Style introduced 2020-02-25 10:12 UTC by Report Bug Copy Issue Report `Git` does not seem to conform to the naming convention (`Utils?$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
16			{
17			/**
18			* Runs a Git command on the repository.
19			*
20			* @param string $command The command.
21			*
22			* @throws \RuntimeException If the command failed.
23			*
24			* @return string The trimmed output from the command.
25			*/
26			public static function runGitCommand(string $command): string
27			{
28			try {
29			$process = new Process($command, __DIR__);
			0 ignored issues – show Documentation introduced 2018-12-12 01:15 UTC by Report Bug Copy Issue Report `$command` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30			if (0 === $process->run()) {
31			return trim($process->getOutput());
32			}
33
34			throw new \RuntimeException(
35			sprintf(
36			'The tag or commit hash could not be retrieved from "%s": %s',
37			__DIR__,
38			$process->getErrorOutput()
39			)
40			);
41			} catch (\RuntimeException $exception) {
42			throw new \RuntimeException('Process error');
43			}
44			}
45			}
46

Cecilapp / Cecil

Push — utils ( 4b317d )

Git::runGitCommand() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like