Cecil\Command\NewPage

Complexity

Total Complexity

21

Size/Duplication

Total Lines	143
Duplicated Lines	4.9 %

Coupling/Cohesion

Components	2
Dependencies	12

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	findModel()	0	20	4
A	hasEditor()	0	8	2
A	openEditor()	0	20	5
A	configure()	0	15	1
B	execute()	7	48	9

<?php
/*
 * Copyright (c) Arnaud Ligny <arnaud@ligny.org>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Cecil\Command;

use Cecil\Util\Plateform;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputDefinition;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;
use Symfony\Component\Process\Process;

class NewPage extends Command
{
    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setName('new:page')
            ->setDescription('Create a new page')
            ->setDefinition(
                new InputDefinition([
                    new InputArgument('name', InputArgument::REQUIRED, 'New page name'),
                    new InputArgument('path', InputArgument::OPTIONAL, 'If specified, use the given path as working directory'),
                    new InputOption('force', 'f', InputOption::VALUE_NONE, 'Override the file if already exist'),
                    new InputOption('open', 'o', InputOption::VALUE_NONE, 'Open editor automatically'),
                ])
            )
            ->setHelp('Create a new page file (with a default title and the current date).');
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->name = $input->getArgument('name');

The property name cannot be accessed from this context as it is declared private in class Symfony\Component\Console\Command\Command.

        $this->force = $input->getOption('force');

The property force does not exist. Did you maybe forget to declare it?

        $this->open = $input->getOption('open');

The property open does not exist. Did you maybe forget to declare it?

        try {
            // file name (without extension)
            if (false !== $extPos = strripos($this->name, '.md')) {

The property name cannot be accessed from this context as it is declared private in class Symfony\Component\Console\Command\Command.

                $this->name = substr($this->name, 0, $extPos);

The property name cannot be accessed from this context as it is declared private in class Symfony\Component\Console\Command\Command.

            }
            // path
            $fileRelativePath = $this->getBuilder($output)->getConfig()->get('content.dir').'/'.$this->name.'.md';

The property name cannot be accessed from this context as it is declared private in class Symfony\Component\Console\Command\Command.

            $filePath = $this->getPath().'/'.$fileRelativePath;

            // file already exists?
            if ($this->fs->exists($filePath) && !$this->force) {

This code seems to be duplicated across your project.

                $helper = $this->getHelper('question');
                $question = new ConfirmationQuestion(sprintf('This page already exists. Do you want to override it? [y/n]', $this->getpath()), false);
                if (!$helper->ask($input, $output, $question)) {
                    return;
                }
            }

            // create new file
            $title = $this->name;

The property name cannot be accessed from this context as it is declared private in class Symfony\Component\Console\Command\Command.

            if (false !== strrchr($this->name, '/')) {

The property name cannot be accessed from this context as it is declared private in class Symfony\Component\Console\Command\Command.

                $title = substr(strrchr($this->name, '/'), 1);

The property name cannot be accessed from this context as it is declared private in class Symfony\Component\Console\Command\Command.

            }
            $date = date('Y-m-d');
            $fileContent = str_replace(['%title%', '%date%'], [$title, $date], $this->findModel($this->name));

The property name cannot be accessed from this context as it is declared private in class Symfony\Component\Console\Command\Command.

It seems like $this->name can also be of type array<integer,string> or null; however, Cecil\Command\NewPage::findModel() does only seem to accept string, maybe add an additional type check?

            $this->fs->dumpFile($filePath, $fileContent);

            $output->writeln(sprintf('File "%s" created.', $fileRelativePath));

            // open editor?
            if ($this->open) {
                if (!$this->hasEditor()) {
                    $output->writeln('<comment>No editor configured.</comment>');
                }
                $this->openEditor($filePath);
            }
        } catch (\Exception $e) {
            throw new \Exception(sprintf($e->getMessage()));
        }

        return 0;
    }

    /**
     * Find the page model and return its content.
     *
     * @param string $name
     *
     * @return string
     */
    protected function findModel($name)

The parameter $name is not used and could be removed.

    {
        $section = strstr($this->name, '/', true);

The property name cannot be accessed from this context as it is declared private in class Symfony\Component\Console\Command\Command.

        if ($section && file_exists($model = sprintf('%s/models/%s.md', $this->getPath(), $section))) {
            return file_get_contents($model);
        }
        if (file_exists($model = sprintf('%s/models/default.md', $this->getPath()))) {
            return file_get_contents($model);
        }

        return <<<'EOT'
---
title: '%title%'
date: '%date%'
draft: true
---

_[Your content here]_
EOT;
    }

    /**
     * Editor is configured?
     *
     * @return bool
     */
    protected function hasEditor()
    {
        if ($this->builder->getConfig()->get('editor')) {

This if statement, and the following return statement can be replaced with return (bool) $this->builder->getConfig()->get('editor');.

            return true;
        }

        return false;
    }

    /**
     * Open new file in editor (if configured).
     *
     * @param string $filePath
     *
     * @return void
     */
    protected function openEditor($filePath)
    {
        if ($editor = $this->builder->getConfig()->get('editor')) {
            switch ($editor) {
                case 'typora':
                    if (Plateform::getOS() == Plateform::OS_OSX) {
                        $command = sprintf('open -a typora "%s"', $filePath);
                    }
                    break;
                default:
                    $command = sprintf('%s "%s"', $editor, $filePath);
                    break;
            }
            $process = new Process($command);

The variable $command does not seem to be defined for all execution paths leading up to this point.

$command is of type string, but the function expects a array.

            $process->run();
            if (!$process->isSuccessful()) {
                throw new \Exception(sprintf('Can\'t run "%s".', $command));
            }
        }
    }
}