OptimizeHtml::process() - Code Metrics - Inspection of "Update Builder.php" - Cecilapp/Cecil - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — optimize ( 97f596 )

by Arnaud

created 2020-01-27 13:22 UTC

OptimizeHtml::process() B

↳ Parent: OptimizeHtml

Complexity

Conditions	6
Paths	11

Size

Total Lines

Duplication

Lines	64
Ratio	100 %

Importance

Changes

Metric	Value
dl	64
loc	64
rs	8.1632
c	0
b	0
f	0
cc	6
nc	11
nop	0

How to fix Long Method

<?php
/*
 * Copyright (c) Arnaud Ligny <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Cecil\Step;

use Symfony\Component\Finder\Finder;
use WyriHaximus\HtmlCompress\Factory;

/**
 * HTML files Optimization.
 */
class OptimizeHtml extends AbstractStep

{
    const TYPE = 'html';


    /**
     * {@inheritdoc}
     */
    public function init($options)
    {
        if (false === $this->builder->getConfig()->get(sprintf('optimize.%s.enabled', self::TYPE))
            || false === $this->builder->getConfig()->get('optimize.enabled'))
        {
            $this->process = false;

            return;
        }
        if ($options['dry-run']) {
            $this->process = false;

            return;
        }
        if (is_dir($this->builder->getConfig()->getOutputPath())) {
            $this->process = true;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function process()
    {
        call_user_func_array($this->builder->getMessageCb(), ['OPTIMIZE', sprintf('Optimizing %s', self::TYPE)]);

        $extensions = $this->builder->getConfig()->get(sprintf('optimize.%s.ext', self::TYPE));
        $files = Finder::create()
            ->files()
            ->in($this->builder->getConfig()->getOutputPath())
            ->name('/\.('.implode('|', $extensions).')$/')
            ->notName('/\.min\.(' . implode('|', $extensions) . ')$/')
            ->sortByName(true);
        $max = count($files);

        if ($max <= 0) {
            $message = 'No files';
            call_user_func_array($this->builder->getMessageCb(), ['OPTIMIZE_PROGRESS', $message]);

            return;
        }

        $count = 0;
        $optimized = 0;

        // setup processor
        $parser = Factory::construct();

        /* @var $file \Symfony\Component\Finder\SplFileInfo */
        foreach ($files as $file) {
            $sizeBefore = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $sizeAfter = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $count++;

            $sizeBefore = $file->getSize();

            // process file
            $html = file_get_contents($file->getPathname());
            $htmlCompressed = $parser->compress($html);
            \Cecil\Util::getFS()->dumpFile($file->getPathname(), $htmlCompressed);

            $sizeAfter = $file->getSize();

            $subpath = \Cecil\Util::getFS()->makePathRelative(
                $file->getPath(),
                $this->builder->getConfig()->getOutputPath()
            );
            $subpath = trim($subpath, './');
            $path = $subpath ? $subpath.'/'.$file->getFilename() : $file->getFilename();

            $message = sprintf(
                '%s: %s Ko -> %s Ko',
                $path,
                ceil($sizeBefore / 1000),
                ceil($sizeAfter / 1000)
            );
            call_user_func_array($this->builder->getMessageCb(), ['OPTIMIZE_PROGRESS', $message, $count, $max]);
            if ($sizeAfter < $sizeBefore) {
                $optimized++;
            }
        }
        if ($optimized == 0) {
            $message = 'Nothing to do';
            call_user_func_array($this->builder->getMessageCb(), ['OPTIMIZE_PROGRESS', $message]);
        }
    }
}


1		<?php
2		/*
3		* Copyright (c) Arnaud Ligny <[email protected]>
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8
9		namespace Cecil\Step;
10
11		use Symfony\Component\Finder\Finder;
12		use WyriHaximus\HtmlCompress\Factory;
13
14		/**
15		* HTML files Optimization.
16		*/
17	View Code Duplication	class OptimizeHtml extends AbstractStep
		0 ignored issues – show Duplication introduced 2020-01-27 13:24 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		{
19		const TYPE = 'html';
20
21
22		/**
23		* {@inheritdoc}
24		*/
25		public function init($options)
26		{
27		if (false === $this->builder->getConfig()->get(sprintf('optimize.%s.enabled', self::TYPE))
28		\|\| false === $this->builder->getConfig()->get('optimize.enabled'))
29		{
30		$this->process = false;
31
32		return;
33		}
34		if ($options['dry-run']) {
35		$this->process = false;
36
37		return;
38		}
39		if (is_dir($this->builder->getConfig()->getOutputPath())) {
40		$this->process = true;
41		}
42		}
43
44		/**
45		* {@inheritdoc}
46		*/
47		public function process()
48		{
49		call_user_func_array($this->builder->getMessageCb(), ['OPTIMIZE', sprintf('Optimizing %s', self::TYPE)]);
50
51		$extensions = $this->builder->getConfig()->get(sprintf('optimize.%s.ext', self::TYPE));
52		$files = Finder::create()
53		->files()
54		->in($this->builder->getConfig()->getOutputPath())
55		->name('/\.('.implode('\|', $extensions).')$/')
56		->notName('/\.min\.(' . implode('\|', $extensions) . ')$/')
57		->sortByName(true);
58		$max = count($files);
59
60		if ($max <= 0) {
61		$message = 'No files';
62		call_user_func_array($this->builder->getMessageCb(), ['OPTIMIZE_PROGRESS', $message]);
63
64		return;
65		}
66
67		$count = 0;
68		$optimized = 0;
69
70		// setup processor
71		$parser = Factory::construct();
72
73		/* @var $file \Symfony\Component\Finder\SplFileInfo */
74		foreach ($files as $file) {
75		$sizeBefore = 0;
		0 ignored issues – show Unused Code introduced 2020-01-27 13:24 UTC by Report Bug Copy Issue Report `$sizeBefore` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
76		$sizeAfter = 0;
		0 ignored issues – show Unused Code introduced 2020-01-27 13:24 UTC by Report Bug Copy Issue Report `$sizeAfter` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
77		$count++;
78
79		$sizeBefore = $file->getSize();
80
81		// process file
82		$html = file_get_contents($file->getPathname());
83		$htmlCompressed = $parser->compress($html);
84		\Cecil\Util::getFS()->dumpFile($file->getPathname(), $htmlCompressed);
85
86		$sizeAfter = $file->getSize();
87
88		$subpath = \Cecil\Util::getFS()->makePathRelative(
89		$file->getPath(),
90		$this->builder->getConfig()->getOutputPath()
91		);
92		$subpath = trim($subpath, './');
93		$path = $subpath ? $subpath.'/'.$file->getFilename() : $file->getFilename();
94
95		$message = sprintf(
96		'%s: %s Ko -> %s Ko',
97		$path,
98		ceil($sizeBefore / 1000),
99		ceil($sizeAfter / 1000)
100		);
101		call_user_func_array($this->builder->getMessageCb(), ['OPTIMIZE_PROGRESS', $message, $count, $max]);
102		if ($sizeAfter < $sizeBefore) {
103		$optimized++;
104		}
105		}
106		if ($optimized == 0) {
107		$message = 'Nothing to do';
108		call_user_func_array($this->builder->getMessageCb(), ['OPTIMIZE_PROGRESS', $message]);
109		}
110		}
111		}
112

Cecilapp / Cecil

Push — optimize ( 97f596 )

OptimizeHtml::process() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like