Image::resize() - Code Metrics - Inspection of "Clean code" - Cecilapp/Cecil - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature-images ( defc63...7ab818 )

by Arnaud

created 2020-03-17 22:30 UTC

Image::resize() B

↳ Parent: Image

Complexity

Conditions	11
Paths	32

Size

Total Lines	66
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	11
eloc	34
c	3
b	0
f	0
nc	32
nop	2
dl	0
loc	66
rs	7.3166

How to fix Long Method Complexity

<?php
/*
 * This file is part of the Cecil/Cecil package.
 *
 * Copyright (c) Arnaud Ligny <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Cecil\Assets;

use Cecil\Builder;
use Cecil\Config;
use Cecil\Exception\Exception;
use Cecil\Util;
use Intervention\Image\Exception\NotReadableException;
use Intervention\Image\ImageManagerStatic as ImageManager;

class Image
{
    /** @var Config */
    private $config;
    /** @var string */
    private $path;
    /** @var int */
    private $size;
    /** @var bool */
    private $local = true;
    /** @var string */
    private $source;
    /** @var string */
    private $destination = null;

    const CACHE_IMAGES_THUMBS_DIR = 'images/thumbs';

    public function __construct(Builder $builder)
    {
        $this->config = $builder->getConfig();
    }

    /**
     * Resize an image.
     *
     * @param string $path       Image path (relative from static/ dir or external)
     * @param int    $this->size Image new size (width)
     *
     * @return string Path to image thumbnail
     */
    public function resize(string $path, int $size): string
    {
        // is not a local image?
        if (Util::isExternalUrl($path)) {
            $this->local = false;
        }

        $this->path = '/'.ltrim($path, '/');
        $this->size = $size;
        $returnPath = '/'.self::CACHE_IMAGES_THUMBS_DIR.'/'.$this->size.$this->path;

        // source file
        if ($this->local) {
            $this->source = $this->config->getStaticPath().$this->path;
            if (!Util::getFS()->exists($this->source)) {
                throw new Exception(sprintf('Can\'t process "%s": file doesn\'t exists.', $this->source));
            }
        } else {
            $this->source = $path;
            if (!Util::isUrlFileExists($this->source)) {
                throw new Exception(sprintf('Can\'t process "%s": remonte file doesn\'t exists.', $this->source));
            }
        }

        // images cache path
        $this->cachePath = $this->config->getCachePath().'/'.self::CACHE_IMAGES_THUMBS_DIR.'/';


        // is size is already OK?
        list($width, $height) = getimagesize($this->source);
        if ($width <= $this->size && $height <= $this->size) {
            return $this->path;
        }

        // if GD extension is not installed: can't process
        if (!extension_loaded('gd')) {
            throw new Exception('GD extension is required to use images resize.');
        }

        $this->destination = $this->cachePath.$this->size.$this->path;

        if (Util::getFS()->exists($this->destination)) {
            return $returnPath;
        }

        // image object
        try {
            $img = ImageManager::make($this->source);
            $img->resize($this->size, null, function (\Intervention\Image\Constraint $constraint) {
                $constraint->aspectRatio();
                $constraint->upsize();
            });
        } catch (NotReadableException $e) {
            throw new Exception(sprintf('Cannot get image "%s"', $this->path));
        }

        // return data:image for external image
        if (!$this->local) {
            return (string) $img->encode('data-url');
        }

        // save file
        Util::getFS()->mkdir(dirname($this->destination));
        $img->save($this->destination);

        // return new path
        return $returnPath;
    }
}


1			<?php
2			/*
3			* This file is part of the Cecil/Cecil package.
4			*
5			* Copyright (c) Arnaud Ligny <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace Cecil\Assets;
12
13			use Cecil\Builder;
14			use Cecil\Config;
15			use Cecil\Exception\Exception;
16			use Cecil\Util;
17			use Intervention\Image\Exception\NotReadableException;
18			use Intervention\Image\ImageManagerStatic as ImageManager;
19
20			class Image
21			{
22			/** @var Config */
23			private $config;
24			/** @var string */
25			private $path;
26			/** @var int */
27			private $size;
28			/** @var bool */
29			private $local = true;
30			/** @var string */
31			private $source;
32			/** @var string */
33			private $destination = null;
34
35			const CACHE_IMAGES_THUMBS_DIR = 'images/thumbs';
36
37			public function __construct(Builder $builder)
38			{
39			$this->config = $builder->getConfig();
40			}
41
42			/**
43			* Resize an image.
44			*
45			* @param string $path Image path (relative from static/ dir or external)
46			* @param int $this->size Image new size (width)
47			*
48			* @return string Path to image thumbnail
49			*/
50			public function resize(string $path, int $size): string
51			{
52			// is not a local image?
53			if (Util::isExternalUrl($path)) {
54			$this->local = false;
55			}
56
57			$this->path = '/'.ltrim($path, '/');
58			$this->size = $size;
59			$returnPath = '/'.self::CACHE_IMAGES_THUMBS_DIR.'/'.$this->size.$this->path;
60
61			// source file
62			if ($this->local) {
63			$this->source = $this->config->getStaticPath().$this->path;
64			if (!Util::getFS()->exists($this->source)) {
65			throw new Exception(sprintf('Can\'t process "%s": file doesn\'t exists.', $this->source));
66			}
67			} else {
68			$this->source = $path;
69			if (!Util::isUrlFileExists($this->source)) {
70			throw new Exception(sprintf('Can\'t process "%s": remonte file doesn\'t exists.', $this->source));
71			}
72			}
73
74			// images cache path
75			$this->cachePath = $this->config->getCachePath().'/'.self::CACHE_IMAGES_THUMBS_DIR.'/';
			0 ignored issues – show Bug Best Practice introduced 2020-03-14 21:02 UTC by Report Bug Copy Issue Report The property `cachePath` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
76
77			// is size is already OK?
78			list($width, $height) = getimagesize($this->source);
79			if ($width <= $this->size && $height <= $this->size) {
80			return $this->path;
81			}
82
83			// if GD extension is not installed: can't process
84			if (!extension_loaded('gd')) {
85			throw new Exception('GD extension is required to use images resize.');
86			}
87
88			$this->destination = $this->cachePath.$this->size.$this->path;
89
90			if (Util::getFS()->exists($this->destination)) {
91			return $returnPath;
92			}
93
94			// image object
95			try {
96			$img = ImageManager::make($this->source);
97			$img->resize($this->size, null, function (\Intervention\Image\Constraint $constraint) {
98			$constraint->aspectRatio();
99			$constraint->upsize();
100			});
101			} catch (NotReadableException $e) {
102			throw new Exception(sprintf('Cannot get image "%s"', $this->path));
103			}
104
105			// return data:image for external image
106			if (!$this->local) {
107			return (string) $img->encode('data-url');
108			}
109
110			// save file
111			Util::getFS()->mkdir(dirname($this->destination));
112			$img->save($this->destination);
113
114			// return new path
115			return $returnPath;
116			}
117			}
118

Cecilapp / Cecil

Push — feature-images ( defc63...7ab818 )

Image::resize() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like