| Conditions | 11 |
| Paths | 14 |
| Total Lines | 74 |
| Code Lines | 40 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 149 | protected function createMenusFromPages(): void |
||
| 150 | { |
||
| 151 | $filteredPages = $this->builder->getPages()->filter(function (Page $page) { |
||
| 152 | return $page->hasVariable('menu') |
||
| 153 | && $page->getVariable('published') === true |
||
| 154 | && \in_array($page->getVariable('language', $this->config->getLanguageDefault()), array_column($this->config->getLanguages(), 'code')); |
||
| 155 | }); |
||
| 156 | |||
| 157 | $total = \count($filteredPages); |
||
| 158 | $count = 0; |
||
| 159 | /** @var \Cecil\Collection\Page\Page $page */ |
||
| 160 | foreach ($filteredPages as $page) { |
||
| 161 | $count++; |
||
| 162 | $language = $page->getVariable('language', $this->config->getLanguageDefault()); |
||
| 163 | /** |
||
| 164 | * Array case. |
||
| 165 | * |
||
| 166 | * case 1: |
||
| 167 | * menu: [main, navigation] |
||
| 168 | * case 2: |
||
| 169 | * menu: |
||
| 170 | * main: |
||
| 171 | * weight: 999 |
||
| 172 | */ |
||
| 173 | if (\is_array($page->getVariable('menu'))) { |
||
| 174 | foreach ($page->getVariable('menu') as $key => $value) { |
||
| 175 | $menuName = $key; |
||
| 176 | $properties = $value; |
||
| 177 | if (\is_int($key)) { |
||
| 178 | $menuName = $value; |
||
| 179 | $properties = null; |
||
| 180 | } |
||
| 181 | if (!\is_string($menuName)) { |
||
| 182 | $this->builder->getLogger()->error(\sprintf('Menu\'s name of page "%s" must be a string, not "%s"', $page->getId(), PrintLogger::format($menuName)), ['progress' => [$count, $total]]); |
||
| 183 | continue; |
||
| 184 | } |
||
| 185 | $item = (new Entry($page->getIdWithoutLang())) |
||
| 186 | ->setName($page->getVariable('title')) |
||
| 187 | ->setUrl((new PageRenderer($this->builder, $page))->getPath()); |
||
| 188 | if (isset($properties['weight'])) { |
||
| 189 | $item->setWeight((int) $properties['weight']); |
||
| 190 | } |
||
| 191 | // add Menu if not exists |
||
| 192 | if (!$this->menus[$language]->has($menuName)) { |
||
| 193 | $this->menus[$language]->add(new Menu($menuName)); |
||
| 194 | } |
||
| 195 | /** @var \Cecil\Collection\Menu\Menu $menu */ |
||
| 196 | $menu = $this->menus[$language]->get($menuName); |
||
| 197 | $menu->add($item); |
||
| 198 | |||
| 199 | $message = \sprintf('Page menu entry "%s (%s) > %s" created {name: %s, weight: %s}', $menu->getId(), $language, $item->getId(), $item->getName(), $properties['weight'] ?? 'N/A'); |
||
| 200 | $this->builder->getLogger()->info($message, ['progress' => [$count, $total]]); |
||
| 201 | } |
||
| 202 | continue; |
||
| 203 | } |
||
| 204 | /** |
||
| 205 | * String case. |
||
| 206 | * |
||
| 207 | * e.g.: |
||
| 208 | * menu: main |
||
| 209 | */ |
||
| 210 | $item = (new Entry($page->getIdWithoutLang())) |
||
| 211 | ->setName($page->getVariable('title')) |
||
| 212 | ->setUrl((new PageRenderer($this->builder, $page))->getPath()); |
||
| 213 | // add Menu if not exists |
||
| 214 | if (!$this->menus[$language]->has($page->getVariable('menu'))) { |
||
| 215 | $this->menus[$language]->add(new Menu($page->getVariable('menu'))); |
||
| 216 | } |
||
| 217 | /** @var \Cecil\Collection\Menu\Menu $menu */ |
||
| 218 | $menu = $this->menus[$language]->get($page->getVariable('menu')); |
||
| 219 | $menu->add($item); |
||
| 220 | |||
| 221 | $message = \sprintf('Page menu entry "%s (%s) > %s" created {name: %s}', $menu->getId(), $language, $item->getId(), $item->getName()); |
||
| 222 | $this->builder->getLogger()->info($message, ['progress' => [$count, $total]]); |
||
| 223 | } |
||
| 226 |