Issues in Encryption.php (master) - Issues in master - Carteni/crypto-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (65)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Encryption.php (6 issues)

Labels

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the MesCryptoBundle package.
 *
 * (c) Francesco Cartenì <http://www.multimediaexperiencestudio.it/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Mes\Security\CryptoBundle;

use Defuse\Crypto\Crypto as BaseCrypto;
use Defuse\Crypto\File as BaseCryptoFile;
use Mes\Security\CryptoBundle\Model\Key;
use Mes\Security\CryptoBundle\Model\KeyInterface;

/**
 * Class Encryption.
 */
final class Encryption extends AbstractEncryption
{
    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     */
    public function encryptWithKey($plaintext, KeyInterface $key)
    {
        return BaseCrypto::encrypt($plaintext, $this->unlockKey($key));

    }

    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     * @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
     */
    public function decryptWithKey($ciphertext, KeyInterface $key)
    {
        return BaseCrypto::decrypt($ciphertext, $this->unlockKey($key));

    }

    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\IOException
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     */
    public function encryptFileWithKey($inputFilename, $outputFilename, KeyInterface $key)
    {
        BaseCryptoFile::encryptFile($inputFilename, $outputFilename, $this->unlockKey($key));

    }

    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\IOException
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     * @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
     */
    public function decryptFileWithKey($inputFilename, $outputFilename, KeyInterface $key)
    {
        BaseCryptoFile::decryptFile($inputFilename, $outputFilename, $this->unlockKey($key));

    }

    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     */
    public function encryptWithPassword($plaintext, $password)
    {
        return BaseCrypto::encryptWithPassword($plaintext, $password);
    }

    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     * @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
     */
    public function decryptWithPassword($ciphertext, $password)
    {
        return BaseCrypto::decryptWithPassword($ciphertext, $password);
    }

    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\IOException
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     */
    public function encryptFileWithPassword($inputFilename, $outputFilename, $password)
    {
        BaseCryptoFile::encryptFileWithPassword($inputFilename, $outputFilename, $password);
    }

    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\IOException
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     * @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
     */
    public function decryptFileWithPassword($inputFilename, $outputFilename, $password)
    {
        BaseCryptoFile::decryptFileWithPassword($inputFilename, $outputFilename, $password);
    }

    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\IOException
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     */
    public function encryptResourceWithKey($inputHandle, $outputHandle, KeyInterface $key)
    {
        BaseCryptoFile::encryptResource($inputHandle, $outputHandle, $this->unlockKey($key));

    }

    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\IOException
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     * @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
     */
    public function decryptResourceWithKey($inputHandle, $outputHandle, KeyInterface $key)
    {
        BaseCryptoFile::decryptResource($inputHandle, $outputHandle, $this->unlockKey($key));

    }

    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\IOException
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     */
    public function encryptResourceWithPassword($inputHandle, $outputHandle, $password)
    {
        BaseCryptoFile::encryptResourceWithPassword($inputHandle, $outputHandle, $password);
    }

    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\IOException
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     * @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
     */
    public function decryptResourceWithPassword($inputHandle, $outputHandle, $password)
    {
        BaseCryptoFile::decryptResourceWithPassword($inputHandle, $outputHandle, $password);
    }

    /**
     * @param Key|KeyInterface $key The KeyInterface instance to unlock used for Defuse encryption system
     *
     * @return \Defuse\Crypto\Key|\Defuse\Crypto\KeyProtectedByPassword The Defuse key
     */
    private function unlockKey(Key $key)
    {
        return $key->unlock()
                   ->getRawKey();
    }
}


1		<?php
2
3		/*
4		* This file is part of the MesCryptoBundle package.
5		*
6		* (c) Francesco Cartenì <http://www.multimediaexperiencestudio.it/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Mes\Security\CryptoBundle;
13
14		use Defuse\Crypto\Crypto as BaseCrypto;
15		use Defuse\Crypto\File as BaseCryptoFile;
16		use Mes\Security\CryptoBundle\Model\Key;
17		use Mes\Security\CryptoBundle\Model\KeyInterface;
18
19		/**
20		* Class Encryption.
21		*/
22		final class Encryption extends AbstractEncryption
23		{
24		/**
25		* {@inheritdoc}
26		*
27		* @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
28		*/
29	2	public function encryptWithKey($plaintext, KeyInterface $key)
30		{
31	2	return BaseCrypto::encrypt($plaintext, $this->unlockKey($key));
		0 ignored issues – show Compatibility introduced 2017-03-16 08:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$key` of type `object<Mes\Security\Cryp...dle\Model\KeyInterface>` is not a sub-type of `object<Mes\Security\CryptoBundle\Model\Key>`. It seems like you assume a concrete implementation of the interface `Mes\Security\CryptoBundle\Model\KeyInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
32		}
33
34		/**
35		* {@inheritdoc}
36		*
37		* @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
38		* @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
39		*/
40	5	public function decryptWithKey($ciphertext, KeyInterface $key)
41		{
42	5	return BaseCrypto::decrypt($ciphertext, $this->unlockKey($key));
		0 ignored issues – show Compatibility introduced 2017-03-16 08:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$key` of type `object<Mes\Security\Cryp...dle\Model\KeyInterface>` is not a sub-type of `object<Mes\Security\CryptoBundle\Model\Key>`. It seems like you assume a concrete implementation of the interface `Mes\Security\CryptoBundle\Model\KeyInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
43		}
44
45		/**
46		* {@inheritdoc}
47		*
48		* @throws \Defuse\Crypto\Exception\IOException
49		* @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
50		*/
51	1	public function encryptFileWithKey($inputFilename, $outputFilename, KeyInterface $key)
52		{
53	1	BaseCryptoFile::encryptFile($inputFilename, $outputFilename, $this->unlockKey($key));
		0 ignored issues – show Compatibility introduced 2017-05-12 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$key` of type `object<Mes\Security\Cryp...dle\Model\KeyInterface>` is not a sub-type of `object<Mes\Security\CryptoBundle\Model\Key>`. It seems like you assume a concrete implementation of the interface `Mes\Security\CryptoBundle\Model\KeyInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
54	1	}
55
56		/**
57		* {@inheritdoc}
58		*
59		* @throws \Defuse\Crypto\Exception\IOException
60		* @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
61		* @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
62		*/
63	1	public function decryptFileWithKey($inputFilename, $outputFilename, KeyInterface $key)
64		{
65	1	BaseCryptoFile::decryptFile($inputFilename, $outputFilename, $this->unlockKey($key));
		0 ignored issues – show Compatibility introduced 2017-05-12 16:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$key` of type `object<Mes\Security\Cryp...dle\Model\KeyInterface>` is not a sub-type of `object<Mes\Security\CryptoBundle\Model\Key>`. It seems like you assume a concrete implementation of the interface `Mes\Security\CryptoBundle\Model\KeyInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
66	1	}
67
68		/**
69		* {@inheritdoc}
70		*
71		* @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
72		*/
73	1	public function encryptWithPassword($plaintext, $password)
74		{
75	1	return BaseCrypto::encryptWithPassword($plaintext, $password);
76		}
77
78		/**
79		* {@inheritdoc}
80		*
81		* @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
82		* @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
83		*/
84	2	public function decryptWithPassword($ciphertext, $password)
85		{
86	2	return BaseCrypto::decryptWithPassword($ciphertext, $password);
87		}
88
89		/**
90		* {@inheritdoc}
91		*
92		* @throws \Defuse\Crypto\Exception\IOException
93		* @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
94		*/
95	1	public function encryptFileWithPassword($inputFilename, $outputFilename, $password)
96		{
97	1	BaseCryptoFile::encryptFileWithPassword($inputFilename, $outputFilename, $password);
98	1	}
99
100		/**
101		* {@inheritdoc}
102		*
103		* @throws \Defuse\Crypto\Exception\IOException
104		* @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
105		* @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
106		*/
107	2	public function decryptFileWithPassword($inputFilename, $outputFilename, $password)
108		{
109	2	BaseCryptoFile::decryptFileWithPassword($inputFilename, $outputFilename, $password);
110	1	}
111
112		/**
113		* {@inheritdoc}
114		*
115		* @throws \Defuse\Crypto\Exception\IOException
116		* @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
117		*/
118	2	public function encryptResourceWithKey($inputHandle, $outputHandle, KeyInterface $key)
119		{
120	2	BaseCryptoFile::encryptResource($inputHandle, $outputHandle, $this->unlockKey($key));
		0 ignored issues – show Compatibility introduced 2017-05-16 17:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$key` of type `object<Mes\Security\Cryp...dle\Model\KeyInterface>` is not a sub-type of `object<Mes\Security\CryptoBundle\Model\Key>`. It seems like you assume a concrete implementation of the interface `Mes\Security\CryptoBundle\Model\KeyInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
121	1	}
122
123		/**
124		* {@inheritdoc}
125		*
126		* @throws \Defuse\Crypto\Exception\IOException
127		* @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
128		* @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
129		*/
130	1	public function decryptResourceWithKey($inputHandle, $outputHandle, KeyInterface $key)
131		{
132	1	BaseCryptoFile::decryptResource($inputHandle, $outputHandle, $this->unlockKey($key));
		0 ignored issues – show Compatibility introduced 2017-05-16 17:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$key` of type `object<Mes\Security\Cryp...dle\Model\KeyInterface>` is not a sub-type of `object<Mes\Security\CryptoBundle\Model\Key>`. It seems like you assume a concrete implementation of the interface `Mes\Security\CryptoBundle\Model\KeyInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
133	1	}
134
135		/**
136		* {@inheritdoc}
137		*
138		* @throws \Defuse\Crypto\Exception\IOException
139		* @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
140		*/
141	1	public function encryptResourceWithPassword($inputHandle, $outputHandle, $password)
142		{
143	1	BaseCryptoFile::encryptResourceWithPassword($inputHandle, $outputHandle, $password);
144	1	}
145
146		/**
147		* {@inheritdoc}
148		*
149		* @throws \Defuse\Crypto\Exception\IOException
150		* @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
151		* @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
152		*/
153	1	public function decryptResourceWithPassword($inputHandle, $outputHandle, $password)
154		{
155	1	BaseCryptoFile::decryptResourceWithPassword($inputHandle, $outputHandle, $password);
156	1	}
157
158		/**
159		* @param Key\|KeyInterface $key The KeyInterface instance to unlock used for Defuse encryption system
160		*
161		* @return \Defuse\Crypto\Key\|\Defuse\Crypto\KeyProtectedByPassword The Defuse key
162		*/
163	12	private function unlockKey(Key $key)
164		{
165	12	return $key->unlock()
166	11	->getRawKey();
167		}
168		}
169

Carteni / crypto-bundle

Issues (65)

Security Analysis no request data

Encryption.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like