Carteni / crypto-bundle

Encryption.php

<?php

/*
 * This file is part of the MesCryptoBundle package.
 *
 * (c) Francesco Cartenì <http://www.multimediaexperiencestudio.it/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Mes\Security\CryptoBundle;

use Defuse\Crypto\Crypto as BaseCrypto;
use Mes\Security\CryptoBundle\Model\Key;
use Mes\Security\CryptoBundle\Model\KeyInterface;

/**
 * Class Encryption.
 */
final class Encryption extends AbstractEncryption
{
    /**
     * {@inheritdoc}
     *
     * @throw \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     */
    public function encrypt($plaintext, KeyInterface $key)
    {
        return BaseCrypto::encrypt($plaintext, $this->unlockKey($key));

$key of type object<Mes\Security\CryptoBundle\Model\KeyInterface> is not a sub-type of object<Mes\Security\CryptoBundle\Model\Key>. It seems like you assume a concrete implementation of the interface Mes\Security\CryptoBundle\Model\KeyInterface to be always present.

It seems like $this->unlockKey($key) targeting Mes\Security\CryptoBundle\Encryption::unlockKey() can also be of type object<Defuse\Crypto\KeyProtectedByPassword>; however, Defuse\Crypto\Crypto::encrypt() does only seem to accept object<Defuse\Crypto\Key>, maybe add an additional type check?

    }

    /**
     * {@inheritdoc}
     *
     * @throws \Defuse\Crypto\Exception\EnvironmentIsBrokenException
     * @throws \Defuse\Crypto\Exception\WrongKeyOrModifiedCiphertextException
     */
    public function decrypt($ciphertext, KeyInterface $key)
    {
        return BaseCrypto::decrypt($ciphertext, $this->unlockKey($key));

$key of type object<Mes\Security\CryptoBundle\Model\KeyInterface> is not a sub-type of object<Mes\Security\CryptoBundle\Model\Key>. It seems like you assume a concrete implementation of the interface Mes\Security\CryptoBundle\Model\KeyInterface to be always present.

It seems like $this->unlockKey($key) targeting Mes\Security\CryptoBundle\Encryption::unlockKey() can also be of type object<Defuse\Crypto\KeyProtectedByPassword>; however, Defuse\Crypto\Crypto::decrypt() does only seem to accept object<Defuse\Crypto\Key>, maybe add an additional type check?

    }

    /**
     * @param Key|KeyInterface $key
     *
     * @return \Defuse\Crypto\Key|\Defuse\Crypto\KeyProtectedByPassword
     */
    private function unlockKey(Key $key)
    {
        return $key->unlock()
                   ->getRawKey();
    }
}