CapMousse / React-Restify

src/Runner.php

<?php

namespace CapMousse\ReactRestify;

use React\EventLoop\Factory;
use React\Socket\Server as SocketServer;
use React\Http\Server as HttpServer;

class Runner
{
    private $app;

    public function __construct($app)
    {
        $this->app = $app;
    }

    public function listen($port, $host = '127.0.0.1')

The parameter $port is not used and could be removed.

The parameter $host is not used and could be removed.

    {
        $loop = Factory::create();
        $this->register($loop);

The call to register() misses a required argument $port.

        $loop->run();
    }
    
    public function register($loop, $port, $host = '127.0.0.1')
    {
        $socket = new SocketServer($loop);
        $http = new HttpServer($socket);

        $http->on('request', $this->app);
        echo("Server running on {$host}:{$port}\n");

        $socket->listen($port, $host);
    }
}