Server::__invoke() - Code Metrics - Inspection of "Add helper for listen" - CapMousse/React-Restify - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (a445f1)

by Jérémy

created 2017-02-13 23:26 UTC

Server::__invoke() B

↳ Parent: Server

Complexity

Conditions	2
Paths	2

Size

Total Lines	24
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
dl	0
loc	24
rs	8.9713
c	2
b	1
f	0
cc	2
eloc	16
nc	2
nop	2

<?php

namespace CapMousse\ReactRestify;

use React\Http\Request as HttpRequest;
use React\Http\Response as HttpResponse;

class Server
{
    /**
     * Name of the server
     * @var string
     */
    public $name = "ReactRestify";

    /**
     * Version of the API
     * @var null
     */
    public $version = null;

    /**
     * @var \React\Restify\Router
     */
    private $router;

    /**
     * @var string
     */
    private $allowOrigin = "*";

    /**
     * @param null $name
     * @param null $version
     */
    public function __construct($name = null, $version = null)
    {
        if (null !== $name) {
            $this->name = $name;
        }

        if (null !== $version) {
            $this->version = $version;
        }

        $this->router = new Routing\Router();


        $this->initEvents();
    }

    /**
     * Parse request from user
     *
     * @param \React\Http\Request  $HttpRequest
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param \React\Http\Response $HttpResponse
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __invoke(HttpRequest $httpRequest, HttpResponse $httpResponse)
    {
        $start = microtime(true);

        $request = new Http\Request($httpRequest);
        $response = new Http\Response($httpResponse, $this->name, $this->version);

        try {
            $this->router->launch($request, $response, function() use ($request, $response, $start) {
                $end = microtime(true) - $start;

                $response->addHeader("X-Response-Time", $end);
                $response->addHeader("Date", date(DATE_RFC822));
                $response->addHeader("Access-Control-Request-Method", "POST, GET, PUT, DEL");
                $response->addHeader("Access-Control-Allow-Origin", $this->allowOrigin);

                $response->end();
            });
        } catch (\Exception $e) {
            $response->write($e->getMessage());
            $response->setStatus(500);
            $response->end();
        }
    }

    /**
     * Create a new group of route
     * @param String   $prefix   prefix of the routes
     * @param Callable $callback
     *
     * @return \CapMousse\ReactRestify\Routing\Routes
     */
    public function group($prefix, $callback)
    {
        return $this->router->addGroup($prefix, $callback);
    }

    /**
     * The the Access-Control-Allow-Origin header
     *
     * @param string $origin
     */
    public function setAccessControlAllowOrigin($origin)
    {
        $this->allowOrigin = $origin;
    }

    /**
     * Init default event catch
     *
     * @return void
     */
    private function initEvents()
    {
        $this->router->on('NotFound', function($request, $response, $next) {
            $response->write('Not found');
            $response->setStatus(404);

            $next();
        });

        $this->router->on('MethodNotAllowed', function($request, $response, $next) {
            $response->write('Method Not Allowed');
            $response->setStatus(405);

            $next();
        });

        $this->router->on('error', function ($request, $response, $error, $next) {
            $response->write($error);
            $response->write("\n".$request->getContent());
            $response->setStatus(500);

            $next();
        });
    }

    /**
     * Manual router event manager
     * @param String   $event
     * @param Callable $callback
     */
    public function on($event, $callback)
    {
        $this->router->removeAllListeners($event);
        $this->router->on($event, $callback);
    }

    /**
     * Create runner instance
     * @param  Int    $port
     * @param  String $host
     * @return Server
     */
    public function listen($port, $host = "127.0.0.1")
    {
        $runner = new Runner($this);
        $runner->listen($port, $host);

        return $this;
    }

    /**
     * @param string $name      method to call
     * @param array  $arguments
     */
    public function __call($name, $arguments)
    {
        return $this->router->addRoute($name, $arguments[0], $arguments[1]);
    }
}


1			<?php
2
3			namespace CapMousse\ReactRestify;
4
5			use React\Http\Request as HttpRequest;
6			use React\Http\Response as HttpResponse;
7
8			class Server
9			{
10			/**
11			* Name of the server
12			* @var string
13			*/
14			public $name = "ReactRestify";
15
16			/**
17			* Version of the API
18			* @var null
19			*/
20			public $version = null;
21
22			/**
23			* @var \React\Restify\Router
24			*/
25			private $router;
26
27			/**
28			* @var string
29			*/
30			private $allowOrigin = "*";
31
32			/**
33			* @param null $name
34			* @param null $version
35			*/
36			public function __construct($name = null, $version = null)
37			{
38			if (null !== $name) {
39			$this->name = $name;
40			}
41
42			if (null !== $version) {
43			$this->version = $version;
44			}
45
46			$this->router = new Routing\Router();
			0 ignored issues – show Documentation Bug introduced 2017-02-13 23:29 UTC by Report Bug Copy Issue Report It seems like `new \CapMousse\ReactRestify\Routing\Router()` of type `object<CapMousse\ReactRestify\Routing\Router>` is incompatible with the declared type `object<React\Restify\Router>` of property `$router`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
47
48			$this->initEvents();
49			}
50
51			/**
52			* Parse request from user
53			*
54			* @param \React\Http\Request $HttpRequest
			0 ignored issues – show Documentation introduced 2017-02-13 23:29 UTC by Report Bug Copy Issue Report There is no parameter named `$HttpRequest`. Did you maybe mean `$httpRequest`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
55			* @param \React\Http\Response $HttpResponse
			0 ignored issues – show Documentation introduced 2017-02-13 23:29 UTC by Report Bug Copy Issue Report There is no parameter named `$HttpResponse`. Did you maybe mean `$httpResponse`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
56			*/
57			public function __invoke(HttpRequest $httpRequest, HttpResponse $httpResponse)
58			{
59			$start = microtime(true);
60
61			$request = new Http\Request($httpRequest);
62			$response = new Http\Response($httpResponse, $this->name, $this->version);
63
64			try {
65			$this->router->launch($request, $response, function() use ($request, $response, $start) {
66			$end = microtime(true) - $start;
67
68			$response->addHeader("X-Response-Time", $end);
69			$response->addHeader("Date", date(DATE_RFC822));
70			$response->addHeader("Access-Control-Request-Method", "POST, GET, PUT, DEL");
71			$response->addHeader("Access-Control-Allow-Origin", $this->allowOrigin);
72
73			$response->end();
74			});
75			} catch (\Exception $e) {
76			$response->write($e->getMessage());
77			$response->setStatus(500);
78			$response->end();
79			}
80			}
81
82			/**
83			* Create a new group of route
84			* @param String $prefix prefix of the routes
85			* @param Callable $callback
86			*
87			* @return \CapMousse\ReactRestify\Routing\Routes
88			*/
89			public function group($prefix, $callback)
90			{
91			return $this->router->addGroup($prefix, $callback);
92			}
93
94			/**
95			* The the Access-Control-Allow-Origin header
96			*
97			* @param string $origin
98			*/
99			public function setAccessControlAllowOrigin($origin)
100			{
101			$this->allowOrigin = $origin;
102			}
103
104			/**
105			* Init default event catch
106			*
107			* @return void
108			*/
109			private function initEvents()
110			{
111			$this->router->on('NotFound', function($request, $response, $next) {
112			$response->write('Not found');
113			$response->setStatus(404);
114
115			$next();
116			});
117
118			$this->router->on('MethodNotAllowed', function($request, $response, $next) {
119			$response->write('Method Not Allowed');
120			$response->setStatus(405);
121
122			$next();
123			});
124
125			$this->router->on('error', function ($request, $response, $error, $next) {
126			$response->write($error);
127			$response->write("\n".$request->getContent());
128			$response->setStatus(500);
129
130			$next();
131			});
132			}
133
134			/**
135			* Manual router event manager
136			* @param String $event
137			* @param Callable $callback
138			*/
139			public function on($event, $callback)
140			{
141			$this->router->removeAllListeners($event);
142			$this->router->on($event, $callback);
143			}
144
145			/**
146			* Create runner instance
147			* @param Int $port
148			* @param String $host
149			* @return Server
150			*/
151			public function listen($port, $host = "127.0.0.1")
152			{
153			$runner = new Runner($this);
154			$runner->listen($port, $host);
155
156			return $this;
157			}
158
159			/**
160			* @param string $name method to call
161			* @param array $arguments
162			*/
163			public function __call($name, $arguments)
164			{
165			return $this->router->addRoute($name, $arguments[0], $arguments[1]);
166			}
167			}
168

CapMousse / React-Restify

GitHub Access Token became invalid

Branch — master (a445f1)

Server::__invoke() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like