Request::parseData() - Code Metrics - Inspection of "Refactoring" - CapMousse/React-Restify - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev ( 790a5f...fc84f2 )

by Jérémy

created 2017-02-17 09:43 UTC

Request::parseData() B

↳ Parent: Request

Complexity

Conditions	4
Paths	2

Size

Total Lines	24
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	24
rs	8.6845
cc	4
eloc	13
nc	2
nop	0

<?php

namespace CapMousse\ReactRestify\Http;

use React\Http\Request as ReactHttpRequest;
use CapMousse\ReactRestify\Evenement\EventEmitter;

class Request extends EventEmitter
{
    /** @var \React\Http\Request */
    public $httpRequest;

    /** @var mixed */
    private $content;

    /** @var array */
    private $data = [];

    /**
     * @param ReactHttpRequest $httpRequest
     */
    public function __construct(ReactHttpRequest $httpRequest)
    {
        $this->httpRequest = $httpRequest;
    }

    /**
     * Set the raw data of the request
     * @param mixed $content
     */
    public function setContent($content)
    {
        $this->content = $content;
    }

    /**
     * Set the raw data of the request
     * @return mixed
     */
    public function getContent()
    {
        return $this->content;
    }

    /**
     * Get formated headers
     * @return array
     */
    public function getHeaders()
    {
        $headers = array_change_key_case($this->httpRequest->getHeaders(), CASE_LOWER);
        $headers = array_map(function ($value) {
            return strtolower($value);
        }, $headers);

        return $headers;
    }

    /**
     * Parse request data
     * @return void
     */
    public function parseData()
    {
        $headers = $this->getHeaders();

        if (!in_array($this->httpRequest->getMethod(), ['PUT', 'POST'])) {
            return $this->emit('end');
        }

        $this->httpRequest->on('data', function($data) use ($headers, &$dataResult) {
            $dataResult .= $data;

            if (isset($headers["Content-Length"])) {
                if (strlen($dataResult) == $headers["Content-Length"]) {
                    $this->httpRequest->close();
                }
            } else {
                $this->httpRequest->close();
            }
        });

        $this->httpRequest->on('end', function() use (&$dataResult) {
            $this->onEnd($dataResult);     
        });
    }

    private function onEnd($dataResult)
    {
        if ($dataResult === null) return $this->emit('end');

        if ($this->isJson()) $this->paseJson($dataResult);

        else $this->parseStr($dataResult);
    }

    /**
     * Parse querystring
     * @param  string $dataString
     * @return void
     */
    private function parseStr($dataString)
    {
        $data = [];
        parse_str($dataString, $data);

        $this->setContent($dataString);
        $this->setData($data);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->emit('end');
    }

    /**
     * Parse json string
     * @param  string $jsonString 
     * @return void
     */
    private function parseJson($jsonString)
    {
        $jsonData = json_decode($jsonString, true);

        if ($jsonData === null) {
            $this->emit('error', [json_last_error_msg()]);
            return;
        }

        $this->setContent($jsonString);
        $this->setData($jsonData);
        $this->emit('end');
    }

    /**
     * Check if current request is a json request
     * @return boolean
     */
    public function isJson()
    {
        $header = $this->getHeaders();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        return isset($headers['content-type']) && $headers['content-type'] == 'application/json';

    }

    /**
     * Set the data array
     * @param array $data array of data
     */
    public function setData($data)
    {
        $this->data = array_merge($data, $this->data);
    }

    /**
     * Get the data array
     * @return array
     */
    public function getData()
    {
        return $this->data;
    }

    public function __get($name)
    {
        return isset($this->data[$name]) ? $this->data[$name] : false;
    }

    public function __set($name, $value)
    {
        $this->data[$name] = $value;
    }
}


1			<?php
2
3			namespace CapMousse\ReactRestify\Http;
4
5			use React\Http\Request as ReactHttpRequest;
6			use CapMousse\ReactRestify\Evenement\EventEmitter;
7
8			class Request extends EventEmitter
9			{
10			/** @var \React\Http\Request */
11			public $httpRequest;
12
13			/** @var mixed */
14			private $content;
15
16			/** @var array */
17			private $data = [];
18
19			/**
20			* @param ReactHttpRequest $httpRequest
21			*/
22			public function __construct(ReactHttpRequest $httpRequest)
23			{
24			$this->httpRequest = $httpRequest;
25			}
26
27			/**
28			* Set the raw data of the request
29			* @param mixed $content
30			*/
31			public function setContent($content)
32			{
33			$this->content = $content;
34			}
35
36			/**
37			* Set the raw data of the request
38			* @return mixed
39			*/
40			public function getContent()
41			{
42			return $this->content;
43			}
44
45			/**
46			* Get formated headers
47			* @return array
48			*/
49			public function getHeaders()
50			{
51			$headers = array_change_key_case($this->httpRequest->getHeaders(), CASE_LOWER);
52			$headers = array_map(function ($value) {
53			return strtolower($value);
54			}, $headers);
55
56			return $headers;
57			}
58
59			/**
60			* Parse request data
61			* @return void
62			*/
63			public function parseData()
64			{
65			$headers = $this->getHeaders();
66
67			if (!in_array($this->httpRequest->getMethod(), ['PUT', 'POST'])) {
68			return $this->emit('end');
69			}
70
71			$this->httpRequest->on('data', function($data) use ($headers, &$dataResult) {
72			$dataResult .= $data;
73
74			if (isset($headers["Content-Length"])) {
75			if (strlen($dataResult) == $headers["Content-Length"]) {
76			$this->httpRequest->close();
77			}
78			} else {
79			$this->httpRequest->close();
80			}
81			});
82
83			$this->httpRequest->on('end', function() use (&$dataResult) {
84			$this->onEnd($dataResult);
85			});
86			}
87
88			private function onEnd($dataResult)
89			{
90			if ($dataResult === null) return $this->emit('end');
91
92			if ($this->isJson()) $this->paseJson($dataResult);
			0 ignored issues – show Bug introduced 2017-02-17 09:44 UTC by Report Bug Copy Issue Report The method `paseJson()` does not exist on `CapMousse\ReactRestify\Http\Request`. Did you maybe mean `parseJson()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
93			else $this->parseStr($dataResult);
94			}
95
96			/**
97			* Parse querystring
98			* @param string $dataString
99			* @return void
100			*/
101			private function parseStr($dataString)
102			{
103			$data = [];
104			parse_str($dataString, $data);
105
106			$this->setContent($dataString);
107			$this->setData($data);
			0 ignored issues – show Bug introduced 2017-02-17 09:44 UTC by Report Bug Copy Issue Report It seems like `$data` can also be of type `null`; however, `CapMousse\ReactRestify\Http\Request::setData()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
108			$this->emit('end');
109			}
110
111			/**
112			* Parse json string
113			* @param string $jsonString
114			* @return void
115			*/
116			private function parseJson($jsonString)
117			{
118			$jsonData = json_decode($jsonString, true);
119
120			if ($jsonData === null) {
121			$this->emit('error', [json_last_error_msg()]);
122			return;
123			}
124
125			$this->setContent($jsonString);
126			$this->setData($jsonData);
127			$this->emit('end');
128			}
129
130			/**
131			* Check if current request is a json request
132			* @return boolean
133			*/
134			public function isJson()
135			{
136			$header = $this->getHeaders();
			0 ignored issues – show Unused Code introduced 2017-02-17 09:44 UTC by Report Bug Copy Issue Report `$header` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
137
138			return isset($headers['content-type']) && $headers['content-type'] == 'application/json';
			0 ignored issues – show Bug introduced 2017-02-17 09:44 UTC by Report Bug Copy Issue Report The variable `$headers` does not exist. Did you mean `$header`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
139			}
140
141			/**
142			* Set the data array
143			* @param array $data array of data
144			*/
145			public function setData($data)
146			{
147			$this->data = array_merge($data, $this->data);
148			}
149
150			/**
151			* Get the data array
152			* @return array
153			*/
154			public function getData()
155			{
156			return $this->data;
157			}
158
159			public function __get($name)
160			{
161			return isset($this->data[$name]) ? $this->data[$name] : false;
162			}
163
164			public function __set($name, $value)
165			{
166			$this->data[$name] = $value;
167			}
168			}
169

CapMousse / React-Restify

GitHub Access Token became invalid

Push — dev ( 790a5f...fc84f2 )

Request::parseData() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like