CakeDC / cakephp-api

src/Service/Auth/Authenticate/TokenAuthenticate.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
      *
      * @param ServerRequest $request Cake request object.
      * @param Response $response Cake response object.
-     * @return mixed
+     * @return boolean
      */
     public function authenticate(ServerRequest $request, Response $response)
     {

src/Service/Action/Extension/CrudRelationsExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
     /**
      * @param CrudAction $action An Action instance.
      * @param Query $query A Query instance.
-     * @return mixed
+     * @return Query
      */
     protected function _attachAssociations(CrudAction $action, Query $query)
     {

src/Service/Auth/Authorize/SimpleRbacAuthorize.php

Doc Comments +4 added lines, -4 removed lines

@@ -140,7 +140,7 @@ 
      * Set a default role if no role is provided
      *
      * @param array $user user data
-     * @param Request $request request
+     * @param ServerRequest $request request
      * @return bool
      */
     public function authorize($user, ServerRequest $request)
@@ -162,7 +162,7 @@ 
      *
      * @param array $user current user array
      * @param string $role effective role for the current user
-     * @param Request $request request
+     * @param ServerRequest $request request
      * @return bool true if there is a match in permissions
      */
     protected function _checkRules(array $user, $role, ServerRequest $request)
@@ -184,8 +184,8 @@ 
      * @param array $permission configuration
      * @param array $user current user
      * @param string $role effective user role
-     * @param Request $request request
-     * @return bool if rule matched, null if rule not matched
+     * @param ServerRequest $request request
+     * @return boolean|null if rule matched, null if rule not matched
      */
     protected function _matchRule($permission, $user, $role, $request)
     {

src/Service/Locator/LocatorAwareTrait.php

Doc Comments +2 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
      * If no parameters are passed, it will return the currently used locator.
      *
      * @param \CakeDC\Api\Service\Locator\LocatorInterface|null $serviceLocator LocatorInterface instance.
-     * @return \CakeDC\Api\Service\Locator\LocatorInterface
+     * @return \Cake\ORM\Locator\LocatorInterface
      * @deprecated 3.6.0 Use getTableLocator()/setTableLocator() instead.
      */
     public function serviceLocator(LocatorInterface $serviceLocator = null)
@@ -50,7 +50,7 @@ 
     /**
      * Sets the table locator.
      *
-     * @param \Cake\ORM\Locator\LocatorInterface $tableLocator LocatorInterface instance.
+     * @param LocatorInterface $tableLocator LocatorInterface instance.
      * @return $this
      */
     public function setTableLocator(LocatorInterface $tableLocator)

Unused Use Statements -2 removed lines

@@ -11,8 +11,6 @@
 
 namespace CakeDC\Api\Service\Locator;
 
-use CakeDC\Api\Service\ServiceRegistry;
-
 /**
  * Contains method for setting and accessing LocatorInterface instance
  */

src/Service/Locator/ServiceLocator.php

Doc Comments +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
      * Stores a list of options to be used when instantiating an object
      * with a matching alias.
      *
-     * @param string|array $alias Name of the alias or array to completely overwrite current config.
+     * @param string $alias Name of the alias or array to completely overwrite current config.
      * @param array|null $options list of options for the alias
      * @return $this
      * @throws \RuntimeException When you attempt to configure an existing table instance.

tests/TestCase/Integration/Service/Action/Extension/CursorPaginationExtensionTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -162,7 +162,7 @@
     }
 
     /**
-     * @param $count
+     * @param integer $count
      */
     protected function _addData($count)
     {

tests/TestCase/Service/ServiceRegistryTest.php

Unused Use Statements -2 removed lines

@@ -16,8 +16,6 @@
 use CakeDC\Api\TestSuite\TestCase;
 use CakeDC\Api\Test\ConfigTrait;
 use CakeDC\Api\Test\FixturesTrait;
-use Cake\Http\Response;
-use Cake\Http\ServerRequest;
 
 class ServiceRegistryTest extends TestCase
 {

src/Service/Action/Auth/ResetPasswordRequestAction.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use CakeDC\Api\Exception\ValidationException;
 use CakeDC\Api\Service\Action\Action;
-use CakeDC\Users\Controller\Component\UsersAuthComponent;
 use CakeDC\Users\Controller\Traits\CustomUsersTableTrait;
 use CakeDC\Users\Exception\UserNotActiveException;
 use CakeDC\Users\Exception\UserNotFoundException;

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
     /**
      * Execute action.
      *
-     * @return mixed
+     * @return string
      * @throws Exception
      */
     public function execute()

src/Service/Action/Auth/ValidateAccountRequestAction.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use CakeDC\Api\Exception\ValidationException;
 use CakeDC\Api\Service\Action\Action;
-use CakeDC\Users\Controller\Component\UsersAuthComponent;
 use CakeDC\Users\Controller\Traits\CustomUsersTableTrait;
 use CakeDC\Users\Exception\UserAlreadyActiveException;
 use CakeDC\Users\Exception\UserNotFoundException;

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
     /**
      * Execute action.
      *
-     * @return mixed
+     * @return string
      * @throws Exception
      */
     public function execute()