DeleteActionTest::testValidatesEntity() - Code Metrics - Inspection of "3.4" - CakeDC/cakephp-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#40)

unknown

created 2018-02-26 16:10 UTC

DeleteActionTest::testValidatesEntity() A

↳ Parent: DeleteActionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	0
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php
/**
 * Copyright 2016 - 2017, Cake Development Corporation (http://cakedc.com)
 *
 * Licensed under The MIT License
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright Copyright 2016 - 2017, Cake Development Corporation (http://cakedc.com)
 * @license MIT License (http://www.opensource.org/licenses/mit-license.php)
 */

namespace CakeDC\Api\Test\TestCase\Service\Action\Collection;

use CakeDC\Api\Exception\ValidationException;
use CakeDC\Api\Service\Action\Collection\DeleteAction;
use CakeDC\Api\Service\ServiceRegistry;
use CakeDC\Api\TestSuite\TestCase;
use CakeDC\Api\Test\ConfigTrait;
use CakeDC\Api\Test\FixturesTrait;
use Cake\ORM\TableRegistry;

class DeleteActionTest extends TestCase
{
    use ConfigTrait;
    use FixturesTrait;

    /**
     * @var DeleteAction
     */
    public $Action;

    /**
     * setUp method
     *
     * @return void
     */
    public function setUp()
    {
        parent::setUp();
    }

    /**
     * tearDown method
     *
     * @return void
     */
    public function tearDown()
    {
        ServiceRegistry::clear();
        unset($this->Service, $this->Action, $this->request);
        parent::tearDown();
    }

    /**
     * @return void
     */
    public function testExecuteSuccess()
    {
        $ArticlesTable = TableRegistry::get('Articles');
        $initialCount = $ArticlesTable->find()->count();
        $this->_initializeAction([
            ['id' => 1],
            ['id' => 2]
        ]);

        $this->Action->execute();
        $finalCount = $ArticlesTable->find()->count();
        $this->assertEquals(-2, $finalCount - $initialCount, 'We should have added 2 new articles');
    }

    /**
     * @return void
     * @expectedException \CakeDC\Api\Exception\ValidationException
     */
    public function testValidationPostNotArray()
    {
        $this->_initializeAction(
            ['id' => 1]
        );
        $this->Action->execute();
    }

    /**
     * @return void
     * @expectedException \CakeDC\Api\Exception\ValidationException
     */
    public function testValidationPostEmpty()
    {
        $this->_initializeAction();
        $this->Action->execute();
    }

    /**
     * @return void
     * @expectedException \CakeDC\Api\Exception\ValidationException
     */
    public function testValidationPostString()
    {
        $this->_initializeAction('something');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->Action->execute();
    }

    /**
     * @return void
     * @expectedException \CakeDC\Api\Exception\ValidationException
     * @expectedExceptionMessage Validation failed
     */
    public function testExecuteValidationEntityNotValid()
    {
        $this->_initializeAction([
            ['not-id' => 'something'],
            ['blank' => new \ArrayObject()]
        ]);

        $this->Action->execute();
    }

    /**
     * @return void
     */
    public function testValidatesEntity()
    {
        $this->_initializeAction([
            ['id' => 1],
            ['id' => 7]
        ]);

        $this->assertTrue($this->Action->validates());
    }

    /**
     * @return void
     */
    public function testValidatesEntityNotValid()
    {
        $this->_initializeAction([
            ['id' => 1],
            ['id' => '']
        ]);

        try {
            $this->Action->validates();
            $this->fail('ValidationException was expected');
        } catch (ValidationException $ex) {
            $this->assertSame([
                // note the index here is important, first entity (0) is valid
                1 => [
                    'id' => [
                        '_empty' => 'Missing id'
                    ]
                ]
            ], $ex->getValidationErrors());
        }
    }

    protected function _initializeAction($post = [])
    {
        $this->_initializeRequest([
            'params' => [
                'service' => 'articlesCollection',
            ],
            'post' => $post,
        ], 'POST');
        $options = [
            'version' => null,
            'service' => null,
            'request' => $this->request,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'response' => $this->response,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'baseUrl' => '/articles_collection/collection/delete'
        ];
        $this->Service = ServiceRegistry::get($this->request['service'], $options);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->Action = new DeleteAction([
            'service' => $this->Service,
        ]);
        $this->Action->setTable(TableRegistry::get('Articles'));
    }
}


1			<?php
2			/**
3			* Copyright 2016 - 2017, Cake Development Corporation (http://cakedc.com)
4			*
5			* Licensed under The MIT License
6			* Redistributions of files must retain the above copyright notice.
7			*
8			* @copyright Copyright 2016 - 2017, Cake Development Corporation (http://cakedc.com)
9			* @license MIT License (http://www.opensource.org/licenses/mit-license.php)
10			*/
11
12			namespace CakeDC\Api\Test\TestCase\Service\Action\Collection;
13
14			use CakeDC\Api\Exception\ValidationException;
15			use CakeDC\Api\Service\Action\Collection\DeleteAction;
16			use CakeDC\Api\Service\ServiceRegistry;
17			use CakeDC\Api\TestSuite\TestCase;
18			use CakeDC\Api\Test\ConfigTrait;
19			use CakeDC\Api\Test\FixturesTrait;
20			use Cake\ORM\TableRegistry;
21
22			class DeleteActionTest extends TestCase
23			{
24			use ConfigTrait;
25			use FixturesTrait;
26
27			/**
28			* @var DeleteAction
29			*/
30			public $Action;
31
32			/**
33			* setUp method
34			*
35			* @return void
36			*/
37			public function setUp()
38			{
39			parent::setUp();
40			}
41
42			/**
43			* tearDown method
44			*
45			* @return void
46			*/
47			public function tearDown()
48			{
49			ServiceRegistry::clear();
50			unset($this->Service, $this->Action, $this->request);
51			parent::tearDown();
52			}
53
54			/**
55			* @return void
56			*/
57			public function testExecuteSuccess()
58			{
59			$ArticlesTable = TableRegistry::get('Articles');
60			$initialCount = $ArticlesTable->find()->count();
61			$this->_initializeAction([
62			['id' => 1],
63			['id' => 2]
64			]);
65
66			$this->Action->execute();
67			$finalCount = $ArticlesTable->find()->count();
68			$this->assertEquals(-2, $finalCount - $initialCount, 'We should have added 2 new articles');
69			}
70
71			/**
72			* @return void
73			* @expectedException \CakeDC\Api\Exception\ValidationException
74			*/
75			public function testValidationPostNotArray()
76			{
77			$this->_initializeAction(
78			['id' => 1]
79			);
80			$this->Action->execute();
81			}
82
83			/**
84			* @return void
85			* @expectedException \CakeDC\Api\Exception\ValidationException
86			*/
87			public function testValidationPostEmpty()
88			{
89			$this->_initializeAction();
90			$this->Action->execute();
91			}
92
93			/**
94			* @return void
95			* @expectedException \CakeDC\Api\Exception\ValidationException
96			*/
97			public function testValidationPostString()
98			{
99			$this->_initializeAction('something');
			0 ignored issues – show Documentation introduced 2018-02-26 16:21 UTC by Report Bug Copy Issue Report `'something'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
100			$this->Action->execute();
101			}
102
103			/**
104			* @return void
105			* @expectedException \CakeDC\Api\Exception\ValidationException
106			* @expectedExceptionMessage Validation failed
107			*/
108			public function testExecuteValidationEntityNotValid()
109			{
110			$this->_initializeAction([
111			['not-id' => 'something'],
112			['blank' => new \ArrayObject()]
113			]);
114
115			$this->Action->execute();
116			}
117
118			/**
119			* @return void
120			*/
121			public function testValidatesEntity()
122			{
123			$this->_initializeAction([
124			['id' => 1],
125			['id' => 7]
126			]);
127
128			$this->assertTrue($this->Action->validates());
129			}
130
131			/**
132			* @return void
133			*/
134			public function testValidatesEntityNotValid()
135			{
136			$this->_initializeAction([
137			['id' => 1],
138			['id' => '']
139			]);
140
141			try {
142			$this->Action->validates();
143			$this->fail('ValidationException was expected');
144			} catch (ValidationException $ex) {
145			$this->assertSame([
146			// note the index here is important, first entity (0) is valid
147			1 => [
148			'id' => [
149			'_empty' => 'Missing id'
150			]
151			]
152			], $ex->getValidationErrors());
153			}
154			}
155
156			protected function _initializeAction($post = [])
157			{
158			$this->_initializeRequest([
159			'params' => [
160			'service' => 'articlesCollection',
161			],
162			'post' => $post,
163			], 'POST');
164			$options = [
165			'version' => null,
166			'service' => null,
167			'request' => $this->request,
			0 ignored issues – show Bug introduced 2018-02-26 16:21 UTC by Report Bug Copy Issue Report The property `request` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
168			'response' => $this->response,
			0 ignored issues – show Bug introduced 2016-11-15 19:48 UTC by Report Bug Copy Issue Report The property `response` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
169			'baseUrl' => '/articles_collection/collection/delete'
170			];
171			$this->Service = ServiceRegistry::get($this->request['service'], $options);
			0 ignored issues – show Bug introduced 2016-11-14 17:33 UTC by Report Bug Copy Issue Report The property `Service` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
172
173			$this->Action = new DeleteAction([
174			'service' => $this->Service,
175			]);
176			$this->Action->setTable(TableRegistry::get('Articles'));
177			}
178			}
179

CakeDC / cakephp-api

Pull Request — master (#40)

DeleteActionTest::testValidatesEntity() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like