CakeDC / cakephp-api

tests/TestCase/Service/Renderer/XmlRendererTest.php

Doc Comments +3 added lines

@@ -152,6 +152,9 @@
         $renderer->error($error);
     }
 
+    /**
+     * @param string $text
+     */
     protected function _xmlMessage($text)
     {
         return '<?xml version="1.0" encoding="UTF-8"?>' . "\n" . $text . "\n";

src/Service/Action/Auth/ResetPasswordAction.php

Doc Comments +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
     /**
      * Execute action.
      *
-     * @return mixed
+     * @return string|null
      * @throws Exception
      */
     public function execute()

src/Service/Action/CrudDeleteAction.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
     /**
      * Execute action.
      *
-     * @return mixed
+     * @return boolean
      */
     public function action($tag_id)
     {

tests/TestCase/Service/Action/CrudDeleteActionTest.php

Doc Comments +3 added lines

@@ -101,6 +101,9 @@
         $this->Action->execute();
     }
 
+    /**
+     * @param integer $id
+     */
     protected function _initializeAction($id, $post = [])
     {
         $this->_initializeController([

tests/TestCase/Service/ServiceRegistryTest.php

Unused Use Statements -2 removed lines

@@ -19,8 +19,6 @@
 use CakeDC\Api\Test\ConfigTrait;
 use CakeDC\Api\Test\FixturesTrait;
 use Cake\Controller\Controller;
-use Cake\Network\Request;
-use Cake\Network\Response;
 use CakeDC\Api\TestSuite\TestCase;
 
 class ServiceTest extends TestCase

src/Service/Action/CrudAction.php

Doc Comments +4 added lines, -4 removed lines

@@ -128,7 +128,7 @@ 
      *
      * @param EntityInterface $entity An Entity instance.
      * @param array $data Entity data.
-     * @return \Cake\Datasource\EntityInterface|mixed
+     * @return EntityInterface
      */
     protected function _patchEntity($entity, $data)
     {
@@ -162,7 +162,7 @@ 
     /**
      * Returns single entity by id.
      *
-     * @param mixed $primaryKey Primary key.
+     * @param string $primaryKey Primary key.
      * @return \Cake\Collection\Collection
      */
     protected function _getEntity($primaryKey)
@@ -211,7 +211,7 @@ 
     /**
      * Model id getter.
      *
-     * @return mixed|string
+     * @return string
      */
     public function id()
     {
@@ -231,7 +231,7 @@ 
     /**
      * Parent id getter.
      *
-     * @return mixed|string
+     * @return string
      */
     public function parentId()
     {

tests/TestCase/Service/ServiceTest.php

Unused Use Statements -1 removed lines

@@ -18,7 +18,6 @@
 use CakeDC\Api\Service\ServiceRegistry;
 use CakeDC\Api\Test\ConfigTrait;
 use CakeDC\Api\Test\FixturesTrait;
-use Cake\Controller\Controller;
 use CakeDC\Api\TestSuite\TestCase;
 
 class ServiceTest extends TestCase

src/Middleware/ApiMiddleware.php

Unused Use Statements -3 removed lines

@@ -7,11 +7,8 @@
 use Cake\Core\Configure;
 use Cake\Http\RequestTransformer;
 use Cake\Http\ResponseTransformer;
-use Cake\Routing\Exception\RedirectException;
-use Cake\Routing\Router;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
-use Zend\Diactoros\Response\RedirectResponse;
 
 /**
  * Applies routing rules to the request and creates the controller

src/Service/Service.php

Doc Comments +3 added lines, -2 removed lines

@@ -319,7 +319,7 @@ 
      * Build router settings.
      * This implementation build action map for resource routes based on Service actions.
      *
-     * @return array
+     * @return callable
      */
     public function routerDefaultOptions()
     {
@@ -538,6 +538,7 @@ 
     }
 
     /**
+     * @param Result $value
      * @return \CakeDC\Api\Service\Action\Result
      */
     public function result($value = null)
@@ -559,7 +560,7 @@ 
      * Fill up response and stop execution.
      *
      * @param Result $result A Result instance.
-     * @return Response
+     * @return \Cake\Network\Response
      */
     public function respond($result = null)
     {