LocatorAwareTrait::setTableLocator() - Code Metrics - Inspection of "Merge branch 'develop'" - CakeDC/cakephp-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e5acb2...2b13b1 )

by Evgeny

created 2018-04-20 17:10 UTC

LocatorAwareTrait::setTableLocator() A

↳ Parent: LocatorAwareTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	6
ccs	0
cts	3
cp	0
crap	2
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * Copyright 2016 - 2018, Cake Development Corporation (http://cakedc.com)
 *
 * Licensed under The MIT License
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright Copyright 2016 - 2018, Cake Development Corporation (http://cakedc.com)
 * @license MIT License (http://www.opensource.org/licenses/mit-license.php)
 */

namespace CakeDC\Api\Service\Locator;

use CakeDC\Api\Service\ServiceRegistry;

/**
 * Contains method for setting and accessing LocatorInterface instance
 */
trait LocatorAwareTrait
{

    /**
     * Service locator instance
     *
     * @var \CakeDC\Api\Service\Locator\LocatorInterface
     */
    protected $_serviceLocator;

    /**
     * Sets the service locator.
     * If no parameters are passed, it will return the currently used locator.
     *
     * @param \CakeDC\Api\Service\Locator\LocatorInterface|null $serviceLocator LocatorInterface instance.
     * @return \CakeDC\Api\Service\Locator\LocatorInterface
     * @deprecated 3.6.0 Use getTableLocator()/setTableLocator() instead.
     */
    public function serviceLocator(LocatorInterface $serviceLocator = null)

    {
        deprecationWarning(
            get_called_class() . '::tableLocator() is deprecated. ' .
            'Use getTableLocator()/setTableLocator() instead.'
        );
        if ($tableLocator !== null) {
            $this->setTableLocator($tableLocator);

        }

        return $this->getTableLocator();
    }

    /**
     * Sets the table locator.
     *
     * @param \Cake\ORM\Locator\LocatorInterface $tableLocator LocatorInterface instance.
     * @return $this
     */
    public function setTableLocator(LocatorInterface $tableLocator)
    {
        $this->_tableLocator = $tableLocator;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this;
    }

    /**
     * Gets the table locator.
     *
     * @return \Cake\ORM\Locator\LocatorInterface
     */
    public function getTableLocator()
    {
        if (!$this->_tableLocator) {
            $this->_tableLocator = TableRegistry::getTableLocator();
        }

        return $this->_tableLocator;
    }
}


1			<?php
2			/**
3			* Copyright 2016 - 2018, Cake Development Corporation (http://cakedc.com)
4			*
5			* Licensed under The MIT License
6			* Redistributions of files must retain the above copyright notice.
7			*
8			* @copyright Copyright 2016 - 2018, Cake Development Corporation (http://cakedc.com)
9			* @license MIT License (http://www.opensource.org/licenses/mit-license.php)
10			*/
11
12			namespace CakeDC\Api\Service\Locator;
13
14			use CakeDC\Api\Service\ServiceRegistry;
15
16			/**
17			* Contains method for setting and accessing LocatorInterface instance
18			*/
19			trait LocatorAwareTrait
20			{
21
22			/**
23			* Service locator instance
24			*
25			* @var \CakeDC\Api\Service\Locator\LocatorInterface
26			*/
27			protected $_serviceLocator;
28
29			/**
30			* Sets the service locator.
31			* If no parameters are passed, it will return the currently used locator.
32			*
33			* @param \CakeDC\Api\Service\Locator\LocatorInterface\|null $serviceLocator LocatorInterface instance.
34			* @return \CakeDC\Api\Service\Locator\LocatorInterface
35			* @deprecated 3.6.0 Use getTableLocator()/setTableLocator() instead.
36			*/
37			public function serviceLocator(LocatorInterface $serviceLocator = null)
			0 ignored issues – show Unused Code introduced 2018-04-20 17:18 UTC by Report Bug Copy Issue Report The parameter `$serviceLocator` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
38			{
39			deprecationWarning(
40			get_called_class() . '::tableLocator() is deprecated. ' .
41			'Use getTableLocator()/setTableLocator() instead.'
42			);
43			if ($tableLocator !== null) {
44			$this->setTableLocator($tableLocator);
			0 ignored issues – show Bug introduced 2018-04-20 17:18 UTC by Report Bug Copy Issue Report The variable `$tableLocator` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
45			}
46
47			return $this->getTableLocator();
48			}
49
50			/**
51			* Sets the table locator.
52			*
53			* @param \Cake\ORM\Locator\LocatorInterface $tableLocator LocatorInterface instance.
54			* @return $this
55			*/
56			public function setTableLocator(LocatorInterface $tableLocator)
57			{
58			$this->_tableLocator = $tableLocator;
			0 ignored issues – show Bug introduced 2018-04-20 17:18 UTC by Report Bug Copy Issue Report The property `_tableLocator` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
59
60			return $this;
61			}
62
63			/**
64			* Gets the table locator.
65			*
66			* @return \Cake\ORM\Locator\LocatorInterface
67			*/
68			public function getTableLocator()
69			{
70			if (!$this->_tableLocator) {
71			$this->_tableLocator = TableRegistry::getTableLocator();
72			}
73
74			return $this->_tableLocator;
75			}
76			}
77

CakeDC / cakephp-api

Push — master ( e5acb2...2b13b1 )

LocatorAwareTrait::setTableLocator() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like