CakeDC / cakephp-api

src/Service/Action/Auth/RegisterAction.php

Unused Use Statements -2 removed lines

@@ -16,11 +16,9 @@
 use CakeDC\Users\Controller\Component\UsersAuthComponent;
 use CakeDC\Users\Controller\Traits\CustomUsersTableTrait;
 use CakeDC\Users\Controller\Traits\RegisterTrait;
-use CakeDC\Users\Exception\UserNotFoundException;
 use Cake\Core\Configure;
 use Cake\Datasource\EntityInterface;
 use Cake\Utility\Hash;
-use Cake\Validation\Validator;
 
 /**
  * Class RegisterAction

src/Service/Action/Auth/ValidateAccountAction.php

Doc Comments +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
     /**
      * Execute action.
      *
-     * @return mixed
+     * @return string|null
      * @throws Exception
      */
     public function execute()

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use CakeDC\Api\Exception\ValidationException;
 use CakeDC\Api\Service\Action\Action;
-use CakeDC\Users\Controller\Component\UsersAuthComponent;
 use CakeDC\Users\Controller\Traits\CustomUsersTableTrait;
 use CakeDC\Users\Exception\TokenExpiredException;
 use CakeDC\Users\Exception\UserAlreadyActiveException;

src/Service/Action/CrudAction.php

Doc Comments +7 added lines, -7 removed lines

@@ -114,7 +114,7 @@ 
     /**
      * Builds new entity instance.
      *
-     * @return \Cake\Collection\Collection
+     * @return EntityInterface
      */
     protected function _newEntity()
     {
@@ -128,7 +128,7 @@ 
      *
      * @param EntityInterface $entity An Entity instance.
      * @param array $data Entity data.
-     * @return \Cake\Datasource\EntityInterface|mixed
+     * @return EntityInterface
      */
     protected function _patchEntity($entity, $data)
     {
@@ -162,7 +162,7 @@ 
     /**
      * Returns single entity by id.
      *
-     * @param mixed $primaryKey Primary key.
+     * @param string $primaryKey Primary key.
      * @return \Cake\Collection\Collection
      */
     protected function _getEntity($primaryKey)
@@ -197,7 +197,7 @@ 
      * Save entity.
      *
      * @param EntityInterface $entity An Entity instance.
-     * @return mixed
+     * @return EntityInterface
      */
     protected function _save($entity)
     {
@@ -211,7 +211,7 @@ 
     /**
      * Model id getter.
      *
-     * @return mixed|string
+     * @return string
      */
     public function id()
     {
@@ -221,7 +221,7 @@ 
     /**
      * Model id field name getter.
      *
-     * @return mixed|string
+     * @return string
      */
     public function idName()
     {
@@ -231,7 +231,7 @@ 
     /**
      * Parent id getter.
      *
-     * @return mixed|string
+     * @return string
      */
     public function parentId()
     {

src/Service/Action/CrudEditAction.php

Doc Comments +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
     /**
      * Execute action.
      *
-     * @return mixed
+     * @return \Cake\Datasource\EntityInterface
      */
     public function execute()
     {

src/Service/Action/Extension/CrudRelationsExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -105,7 +105,7 @@
     /**
      * @param Action $action An Action instance.
      * @param Query $query A Query instance.
-     * @return mixed
+     * @return Query
      */
     protected function _attachAssociations(Action $action, Query $query)
     {

src/Service/Auth/Authenticate/BaseAuthenticate.php

Doc Comments +1 added lines, -1 removed lines

@@ -214,7 +214,7 @@
      * systems like basic and digest auth.
      *
      * @param \Cake\Network\Request $request Request object.
-     * @return mixed Either false or an array of user information
+     * @return boolean Either false or an array of user information
      */
     public function getUser(Request $request)
     {

src/Service/Auth/Authorize/SimpleRbacAuthorize.php

Doc Comments +1 added lines, -1 removed lines

@@ -185,7 +185,7 @@
      * @param array $user current user
      * @param string $role effective user role
      * @param Request $request request
-     * @return bool if rule matched, null if rule not matched
+     * @return boolean|null if rule matched, null if rule not matched
      */
     protected function _matchRule($permission, $user, $role, $request)
     {

src/Service/Service.php

Doc Comments +2 added lines, -2 removed lines

@@ -339,7 +339,7 @@ 
      * Build router settings.
      * This implementation build action map for resource routes based on Service actions.
      *
-     * @return array
+     * @return callable
      */
     public function routerDefaultOptions()
     {
@@ -570,7 +570,7 @@ 
      * Fill up response and stop execution.
      *
      * @param Result $result A Result instance.
-     * @return Response
+     * @return \Cake\Network\Response|null
      */
     public function respond($result = null)
     {

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 use Cake\Core\Configure;
 use Cake\Datasource\Exception\RecordNotFoundException;
 use Cake\Http\Client\Response;
-use Cake\Network\Exception\UnauthorizedException;
 use Cake\Routing\RouteBuilder;
 use Cake\Utility\Hash;
 use Cake\Utility\Inflector;

src/Service/Utility/ReverseRouting.php

Doc Comments +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
      *
      * @param Action $action An Action instance.
      * @param callable $beforeReverse Callback.
-     * @return array
+     * @return string|null
      */
     public function indexPath(Action $action, $beforeReverse = null)
     {
@@ -85,7 +85,7 @@ 
      * @param string $parentName Action name.
      * @param Action $action An Action instance.
      * @param string $type Type of action.
-     * @return array
+     * @return string
      */
     public function parentViewPath($parentName, $action, $type)
     {