ApiMiddleware - Code Metrics - Inspection of "Merge pull request #2 from CakeDC/feature/middlewa..." - CakeDC/cakephp-api - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( b12f23...9cc857 )

by Evgeny

created 2016-11-14 22:18 UTC

ApiMiddleware A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	9

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	78
rs	10
c	1
b	0
f	0
wmc	6
lcom	0
cbo	9

1 Method

Rating	Name	Duplication	Size	Complexity
B	__invoke()	0	68	6

<?php

namespace CakeDC\Api\Middleware;

use Cake\Core\Configure;
use Cake\Routing\Exception\RedirectException;
use Cake\Routing\Router;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Zend\Diactoros\Response\RedirectResponse;
use Cake\Http\RequestTransformer;
use Cake\Http\ResponseTransformer;

use CakeDC\Api\Service\ConfigReader;
use CakeDC\Api\Service\ServiceRegistry;

/**
 * Applies routing rules to the request and creates the controller
 * instance if possible.
 */
class ApiMiddleware
{

    /**
     * @param \Psr\Http\Message\ServerRequestInterface $request The request.
     * @param \Psr\Http\Message\ResponseInterface $response The response.
     * @param callable $next The next middleware to call.
     * @return \Psr\Http\Message\ResponseInterface A response.
     */
    public function __invoke(ServerRequestInterface $request, ResponseInterface $response, $next)
    {
		$prefix = 'api';
		$useVersioning = Configure::read('Api.useVersioning');
		if ($useVersioning) {
			$versionPrefix = Configure::read('Api.versionPrefix');
			$expr = '#/' . $prefix . '/(?<version>' . $versionPrefix . '\d+)' . '/' . '(?<service>[^/?]+)' . '(?<base>/?.*)#';
		} else {
			$expr = '#/' . $prefix . '/' . '(?<service>[^/?]+)' . '(?<base>/?.*)#';
		}
		$path = $request->getUri()->getPath();
		// print_r($expr);

		// print_r($path);

		// exit;
		if(preg_match($expr, $path, $matches)) {
			
			$cakeRequest = RequestTransformer::toCake($request);
			$cakeResponse = ResponseTransformer::toCake($response); 			
			// debug($matches);

			$version = isset($matches['version']) ? $matches['version'] : null;
			$service = $matches['service'];
			// $base = $matches['base'];

			$url = '/' . $service;
			if (!empty($matches['base'])) {
				$url .= $matches['base'];
			}
			$options = [
				'service' => $service,
				'version' => $version,
				'request' => $cakeRequest,
				'response' => $cakeResponse,
				'baseUrl' => $url,
			];
			// print_r($u);

			try {
				$options += (new ConfigReader())->serviceOptions($service, $version);
				$Service = ServiceRegistry::get($service, $options);
				$result = $Service->dispatch();

				$cakeResponse = $Service->respond($result);
			} catch (Exception $e) {

				$cakeResponse->statusCode(400);
				$cakeResponse->body($e->getMessage());
			}
			return ResponseTransformer::toPsr($cakeResponse); 
			// return $response;
		}
        // try {
            // Router::setRequestContext($request);

            // $params = (array)$request->getAttribute('params', []);

            // if (empty($params['controller'])) {

                // $path = $request->getUri()->getPath();

                // $request = $request->withAttribute('params', Router::parse($path, $request->getMethod()));

            // }
        // } catch (RedirectException $e) {

            // return new RedirectResponse(

                // $e->getMessage(),

                // $e->getCode(),

                // $response->getHeaders()

            // );
        // }
		
		// $path = $request->getUri()->getPath();

		// debug(Configure::read('Api'));

		// debug($path);


        return $next($request, $response);
    }
}


1			<?php
2
3			namespace CakeDC\Api\Middleware;
4
5			use Cake\Core\Configure;
6			use Cake\Routing\Exception\RedirectException;
7			use Cake\Routing\Router;
8			use Psr\Http\Message\ResponseInterface;
9			use Psr\Http\Message\ServerRequestInterface;
10			use Zend\Diactoros\Response\RedirectResponse;
11			use Cake\Http\RequestTransformer;
12			use Cake\Http\ResponseTransformer;
13
14			use CakeDC\Api\Service\ConfigReader;
15			use CakeDC\Api\Service\ServiceRegistry;
16
17			/**
18			* Applies routing rules to the request and creates the controller
19			* instance if possible.
20			*/
21			class ApiMiddleware
22			{
23
24			/**
25			* @param \Psr\Http\Message\ServerRequestInterface $request The request.
26			* @param \Psr\Http\Message\ResponseInterface $response The response.
27			* @param callable $next The next middleware to call.
28			* @return \Psr\Http\Message\ResponseInterface A response.
29			*/
30			public function __invoke(ServerRequestInterface $request, ResponseInterface $response, $next)
31			{
32			$prefix = 'api';
33			$useVersioning = Configure::read('Api.useVersioning');
34			if ($useVersioning) {
35			$versionPrefix = Configure::read('Api.versionPrefix');
36			$expr = '#/' . $prefix . '/(?<version>' . $versionPrefix . '\d+)' . '/' . '(?<service>[^/?]+)' . '(?<base>/?.*)#';
37			} else {
38			$expr = '#/' . $prefix . '/' . '(?<service>[^/?]+)' . '(?<base>/?.*)#';
39			}
40			$path = $request->getUri()->getPath();
41			// print_r($expr);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
42			// print_r($path);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
43			// exit;
44			if(preg_match($expr, $path, $matches)) {
45
46			$cakeRequest = RequestTransformer::toCake($request);
47			$cakeResponse = ResponseTransformer::toCake($response);
48			// debug($matches);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
49			$version = isset($matches['version']) ? $matches['version'] : null;
50			$service = $matches['service'];
51			// $base = $matches['base'];
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
52			$url = '/' . $service;
53			if (!empty($matches['base'])) {
54			$url .= $matches['base'];
55			}
56			$options = [
57			'service' => $service,
58			'version' => $version,
59			'request' => $cakeRequest,
60			'response' => $cakeResponse,
61			'baseUrl' => $url,
62			];
63			// print_r($u);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
64			try {
65			$options += (new ConfigReader())->serviceOptions($service, $version);
66			$Service = ServiceRegistry::get($service, $options);
67			$result = $Service->dispatch();
68
69			$cakeResponse = $Service->respond($result);
70			} catch (Exception $e) {
			0 ignored issues – show Bug introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report The class `CakeDC\Api\Middleware\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
71			$cakeResponse->statusCode(400);
72			$cakeResponse->body($e->getMessage());
73			}
74			return ResponseTransformer::toPsr($cakeResponse);
75			// return $response;
76			}
77			// try {
78			// Router::setRequestContext($request);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
79			// $params = (array)$request->getAttribute('params', []);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `65%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
80			// if (empty($params['controller'])) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `79%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
81			// $path = $request->getUri()->getPath();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
82			// $request = $request->withAttribute('params', Router::parse($path, $request->getMethod()));
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
83			// }
84			// } catch (RedirectException $e) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
85			// return new RedirectResponse(
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
86			// $e->getMessage(),
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
87			// $e->getCode(),
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
88			// $response->getHeaders()
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
89			// );
90			// }
91
92			// $path = $request->getUri()->getPath();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
93			// debug(Configure::read('Api'));
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
94			// debug($path);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-14 22:21 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
95
96			return $next($request, $response);
97			}
98			}
99

CakeDC / cakephp-api

Push — master ( b12f23...9cc857 )

ApiMiddleware A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like