ServiceTest - Code Metrics - Inspection of "(feat) remove controller usage from tests and serv..." - CakeDC/cakephp-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8ec403...fa21f3 )

by Evgeny

created 2016-11-15 19:45 UTC

ServiceTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	229
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
dl	0
loc	229
rs	10
c	2
b	0
f	0
wmc	9
lcom	1
cbo	9

9 Methods

Rating	Name	Size	Complexity
A	setUp()	4	1
A	tearDown()	5	1
A	testConstructWithoutAdapter()	10	1
A	testConstructWithRendererAsParameter()	11	1
A	testActionNotFound()	22	1
B	testActionInitialize()	24	1
B	testNestedActionInitialize()	29	1
B	testInitializeActionStoredAsExistsClass()	28	1
B	testInitializeActionByServiceConfigMap()	33	1

<?php
/**
 * Copyright 2016, Cake Development Corporation (http://cakedc.com)
 *
 * Licensed under The MIT License
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright Copyright 2016, Cake Development Corporation (http://cakedc.com)
 * @license MIT License (http://www.opensource.org/licenses/mit-license.php)
 */

namespace CakeDC\Api\Test\App\Service;

use Cake\Core\Configure;
use CakeDC\Api\Service\ConfigReader;
use CakeDC\Api\Service\FallbackService;
use CakeDC\Api\Service\Service;
use CakeDC\Api\Service\ServiceRegistry;
use CakeDC\Api\Test\ConfigTrait;
use CakeDC\Api\Test\FixturesTrait;
use Cake\Controller\Controller;
use CakeDC\Api\TestSuite\TestCase;

class ServiceTest extends TestCase
{

    use ConfigTrait;
    use FixturesTrait;

    /**
     * setUp method
     *
     * @return void
     */
    public function setUp()
    {
        parent::setUp();
    }

    /**
     * tearDown method
     *
     * @return void
     */
    public function tearDown()
    {
        ServiceRegistry::clear();
        parent::tearDown();
    }

    /**
     * Test construct
     *
     * @return void
     * expectedException \CakeDC\Api\Service\Exception\MissingAdapterException
     */
    public function testConstructWithoutAdapter()
    {
        $this->_initializeRequest();
        $this->Service = new FallbackService([
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'service' => 'authors',
            'request' => $this->request,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'response' => $this->response,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'baseUrl' => '/authors'
        ]);
    }

    /**
     * Test construct
     *
     * @return void
     */
    public function testConstructWithRendererAsParameter()
    {
        $this->_initializeRequest();
        $this->Service = new FallbackService([
            'service' => 'authors',
            'request' => $this->request,
            'response' => $this->response,
            'baseUrl' => '/authors',
            'rendererClass' => 'CakeDC/Api.Raw'
        ]);
    }


    /**
     * Test load value method
     *
     * @return void
     * @expectedException \Cake\Routing\Exception\MissingRouteException
     */
    public function testActionNotFound()
    {
        $this->_initializeRequest([
            'params' => [
                'service' => 'authors',
            ]
        ], 'DELETE');
        $service = $this->request['service'];
        $options = [
            'version' => null,
            'service' => $service,
            'request' => $this->request,
            'response' => $this->response,
            'baseUrl' => '/authors'
        ];
        $Service = ServiceRegistry::get($service, $options);
        $this->assertTrue($Service instanceof Service);
        $this->assertEquals('authors', $Service->name());

        $this->assertTextEquals('/authors', $Service->baseUrl());
        $action = $Service->buildAction();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    /**
     * Test load value method
     *
     * @return void
     */
    public function testActionInitialize()
    {
        $this->_initializeRequest([
            'params' => [
                'service' => 'authors',
            ]
        ]);
        $service = $this->request['service'];
        $options = [
            'version' => null,
            'service' => $service,
            'request' => $this->request,
            'response' => $this->response,
            'baseUrl' => '/authors'
        ];
        $Service = ServiceRegistry::get($service, $options);
        $this->assertTrue($Service instanceof Service);
        $this->assertEquals('authors', $Service->name());

        $this->assertTextEquals('/authors', $Service->baseUrl());
        $action = $Service->buildAction();
        $this->assertEquals('authors', $action->service()->name());
        $this->assertEquals('authors', $action->table()->table());
    }

    /**
     * Test nested action generation.
     *
     * @return void
     */
    public function testNestedActionInitialize()
    {
        $this->_initializeRequest([
            'params' => [
                'service' => 'authors',
                'pass' => [
                    '1',
                    'articles'
                ]
            ]
        ]);
        $service = $this->request['service'];
        $options = [
            'version' => null,
            'service' => $service,
            'request' => $this->request,
            'response' => $this->response,
            'baseUrl' => '/authors/1/articles',
        ];
        $Service = ServiceRegistry::get($service, $options);
        $this->assertTrue($Service instanceof Service);
        $this->assertTextEquals('/authors/1/articles', $Service->baseUrl());
        $action = $Service->buildAction();
        $this->assertEquals('1', $action->parentId());
        $this->assertEquals('author_id', $action->parentIdName());
        $this->assertEquals('articles', $action->service()->name());
        $this->assertEquals('authors', $action->service()->parent()->name());
        $this->assertEquals('articles', $action->table()->table());
    }

    /**
     * Test nested action generation.
     *
     * @return void
     */
    public function testInitializeActionStoredAsExistsClass()
    {
        $this->_initializeRequest([
            'params' => [
                'service' => 'articles',
                'pass' => [
                    'tag',
                    '1'
                ],
                'post' => [
                    'tag_id' => 1
                ]
            ]
        ], 'PUT');
        $service = $this->request['service'];
        $options = [
            'version' => null,
            'service' => $service,
            'request' => $this->request,
            'response' => $this->response,
            'baseUrl' => '/articles/tag/1',
        ];
        $Service = ServiceRegistry::get($service, $options);
        $this->assertTrue($Service instanceof Service);
        $this->assertTextEquals('/articles/tag/1', $Service->baseUrl());
        $action = $Service->buildAction();
        $this->assertEquals('CakeDC\Api\Test\App\Service\Action\ArticlesTagAction', get_class($action));
    }

    /**
     * Test nested action generation.
     *
     * @return void
     */
    public function testInitializeActionByServiceConfigMap()
    {
        $actionClass = 'CakeDC\Api\Test\App\Service\Action\Author\IndexAction';
        $this->_addSettingByPath('Service.authors.options', [
            'classMap' => [
                'index' => $actionClass
            ]
        ]);
        $config = require(CONFIG . 'api.php');
        Configure::write($config);
        $this->_initializeRequest([
            'params' => [
                'service' => 'authors',
                'pass' => [],
            ]
        ], 'GET');
        $service = $this->request['service'];
        $version = null;
        $options = [
            'version' => $version,
            'service' => $service,
            'request' => $this->request,
            'response' => $this->response,
            'baseUrl' => '/authors'
        ];
        $options += (new ConfigReader())->serviceOptions($service, $version);
        $Service = ServiceRegistry::get($service, $options);
        $this->assertTrue($Service instanceof Service);
        $this->assertTextEquals('/authors', $Service->baseUrl());
        $action = $Service->buildAction();
        $this->assertEquals($actionClass, get_class($action));
        $this->assertTextEquals('custom action applied', $action->process());
    }
}


1			<?php
2			/**
3			* Copyright 2016, Cake Development Corporation (http://cakedc.com)
4			*
5			* Licensed under The MIT License
6			* Redistributions of files must retain the above copyright notice.
7			*
8			* @copyright Copyright 2016, Cake Development Corporation (http://cakedc.com)
9			* @license MIT License (http://www.opensource.org/licenses/mit-license.php)
10			*/
11
12			namespace CakeDC\Api\Test\App\Service;
13
14			use Cake\Core\Configure;
15			use CakeDC\Api\Service\ConfigReader;
16			use CakeDC\Api\Service\FallbackService;
17			use CakeDC\Api\Service\Service;
18			use CakeDC\Api\Service\ServiceRegistry;
19			use CakeDC\Api\Test\ConfigTrait;
20			use CakeDC\Api\Test\FixturesTrait;
21			use Cake\Controller\Controller;
22			use CakeDC\Api\TestSuite\TestCase;
23
24			class ServiceTest extends TestCase
25			{
26
27			use ConfigTrait;
28			use FixturesTrait;
29
30			/**
31			* setUp method
32			*
33			* @return void
34			*/
35			public function setUp()
36			{
37			parent::setUp();
38			}
39
40			/**
41			* tearDown method
42			*
43			* @return void
44			*/
45			public function tearDown()
46			{
47			ServiceRegistry::clear();
48			parent::tearDown();
49			}
50
51			/**
52			* Test construct
53			*
54			* @return void
55			* expectedException \CakeDC\Api\Service\Exception\MissingAdapterException
56			*/
57			public function testConstructWithoutAdapter()
58			{
59			$this->_initializeRequest();
60			$this->Service = new FallbackService([
			0 ignored issues – show Bug introduced 2016-11-14 17:33 UTC by Report Bug Copy Issue Report The property `Service` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
61			'service' => 'authors',
62			'request' => $this->request,
			0 ignored issues – show Bug introduced 2016-11-15 19:48 UTC by Report Bug Copy Issue Report The property `request` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
63			'response' => $this->response,
			0 ignored issues – show Bug introduced 2016-11-15 19:48 UTC by Report Bug Copy Issue Report The property `response` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
64			'baseUrl' => '/authors'
65			]);
66			}
67
68			/**
69			* Test construct
70			*
71			* @return void
72			*/
73			public function testConstructWithRendererAsParameter()
74			{
75			$this->_initializeRequest();
76			$this->Service = new FallbackService([
77			'service' => 'authors',
78			'request' => $this->request,
79			'response' => $this->response,
80			'baseUrl' => '/authors',
81			'rendererClass' => 'CakeDC/Api.Raw'
82			]);
83			}
84
85
86			/**
87			* Test load value method
88			*
89			* @return void
90			* @expectedException \Cake\Routing\Exception\MissingRouteException
91			*/
92			public function testActionNotFound()
93			{
94			$this->_initializeRequest([
95			'params' => [
96			'service' => 'authors',
97			]
98			], 'DELETE');
99			$service = $this->request['service'];
100			$options = [
101			'version' => null,
102			'service' => $service,
103			'request' => $this->request,
104			'response' => $this->response,
105			'baseUrl' => '/authors'
106			];
107			$Service = ServiceRegistry::get($service, $options);
108			$this->assertTrue($Service instanceof Service);
109			$this->assertEquals('authors', $Service->name());
110
111			$this->assertTextEquals('/authors', $Service->baseUrl());
112			$action = $Service->buildAction();
			0 ignored issues – show Unused Code introduced 2016-11-14 17:33 UTC by Report Bug Copy Issue Report `$action` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
113			}
114
115			/**
116			* Test load value method
117			*
118			* @return void
119			*/
120			public function testActionInitialize()
121			{
122			$this->_initializeRequest([
123			'params' => [
124			'service' => 'authors',
125			]
126			]);
127			$service = $this->request['service'];
128			$options = [
129			'version' => null,
130			'service' => $service,
131			'request' => $this->request,
132			'response' => $this->response,
133			'baseUrl' => '/authors'
134			];
135			$Service = ServiceRegistry::get($service, $options);
136			$this->assertTrue($Service instanceof Service);
137			$this->assertEquals('authors', $Service->name());
138
139			$this->assertTextEquals('/authors', $Service->baseUrl());
140			$action = $Service->buildAction();
141			$this->assertEquals('authors', $action->service()->name());
142			$this->assertEquals('authors', $action->table()->table());
143			}
144
145			/**
146			* Test nested action generation.
147			*
148			* @return void
149			*/
150			public function testNestedActionInitialize()
151			{
152			$this->_initializeRequest([
153			'params' => [
154			'service' => 'authors',
155			'pass' => [
156			'1',
157			'articles'
158			]
159			]
160			]);
161			$service = $this->request['service'];
162			$options = [
163			'version' => null,
164			'service' => $service,
165			'request' => $this->request,
166			'response' => $this->response,
167			'baseUrl' => '/authors/1/articles',
168			];
169			$Service = ServiceRegistry::get($service, $options);
170			$this->assertTrue($Service instanceof Service);
171			$this->assertTextEquals('/authors/1/articles', $Service->baseUrl());
172			$action = $Service->buildAction();
173			$this->assertEquals('1', $action->parentId());
174			$this->assertEquals('author_id', $action->parentIdName());
175			$this->assertEquals('articles', $action->service()->name());
176			$this->assertEquals('authors', $action->service()->parent()->name());
177			$this->assertEquals('articles', $action->table()->table());
178			}
179
180			/**
181			* Test nested action generation.
182			*
183			* @return void
184			*/
185			public function testInitializeActionStoredAsExistsClass()
186			{
187			$this->_initializeRequest([
188			'params' => [
189			'service' => 'articles',
190			'pass' => [
191			'tag',
192			'1'
193			],
194			'post' => [
195			'tag_id' => 1
196			]
197			]
198			], 'PUT');
199			$service = $this->request['service'];
200			$options = [
201			'version' => null,
202			'service' => $service,
203			'request' => $this->request,
204			'response' => $this->response,
205			'baseUrl' => '/articles/tag/1',
206			];
207			$Service = ServiceRegistry::get($service, $options);
208			$this->assertTrue($Service instanceof Service);
209			$this->assertTextEquals('/articles/tag/1', $Service->baseUrl());
210			$action = $Service->buildAction();
211			$this->assertEquals('CakeDC\Api\Test\App\Service\Action\ArticlesTagAction', get_class($action));
212			}
213
214			/**
215			* Test nested action generation.
216			*
217			* @return void
218			*/
219			public function testInitializeActionByServiceConfigMap()
220			{
221			$actionClass = 'CakeDC\Api\Test\App\Service\Action\Author\IndexAction';
222			$this->_addSettingByPath('Service.authors.options', [
223			'classMap' => [
224			'index' => $actionClass
225			]
226			]);
227			$config = require(CONFIG . 'api.php');
228			Configure::write($config);
229			$this->_initializeRequest([
230			'params' => [
231			'service' => 'authors',
232			'pass' => [],
233			]
234			], 'GET');
235			$service = $this->request['service'];
236			$version = null;
237			$options = [
238			'version' => $version,
239			'service' => $service,
240			'request' => $this->request,
241			'response' => $this->response,
242			'baseUrl' => '/authors'
243			];
244			$options += (new ConfigReader())->serviceOptions($service, $version);
245			$Service = ServiceRegistry::get($service, $options);
246			$this->assertTrue($Service instanceof Service);
247			$this->assertTextEquals('/authors', $Service->baseUrl());
248			$action = $Service->buildAction();
249			$this->assertEquals($actionClass, get_class($action));
250			$this->assertTextEquals('custom action applied', $action->process());
251			}
252			}
253

CakeDC / cakephp-api

Push — master ( 8ec403...fa21f3 )

ServiceTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

Duplication Side-by-Side

Filter issues like