for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
/**
* CakeCMS Core
*
* This file is part of the of the simple cms based on CakePHP 3.
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
* @package Core
* @license MIT
* @copyright MIT License http://www.opensource.org/licenses/mit-license.php
* @link https://github.com/CakeCMS/Core".
* @author Sergey Kalistratov <[email protected]>
*/
namespace Core\Toolbar;
use Cake\Utility\Hash;
* Class ToolbarItemAction
* @package Core\Toolbar
class ToolbarItemAction extends ToolbarItem
{
* Fetch button id.
* @return string
* @SuppressWarnings("unused")
public function fetchItem()
list ($source, $title, $action, $options) = func_get_args();
$source
list($first,,$third)
This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.
list(...)
Consider the following code example.
<?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c;
Only the variables $a and $c are used. There was no need to assign $b.
$a
$c
$b
Instead, the list call could have been.
list($a,, $c) = returnThreeValues();
return $this->_view->Form->button($title, Hash::merge([
'icon' => 'trash',
'data-action' => $action,
'button' => 'red lighten-2',
'class' => 'jsProcessDelete',
], (array) $options));
}
CakeCMS /
Core
This checks looks for assignemnts to variables using the
list(...)function, where not all assigned variables are subsequently used.Consider the following code example.
Only the variables
$aand$care used. There was no need to assign$b.Instead, the list call could have been.