Community\Controller\Admin\UsersController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	128
Duplicated Lines	10.94 %

Coupling/Cohesion

Components	2
Dependencies	12

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	add()	0	36	4
B	edit()	14	25	3
A	index()	0	10	1
A	initialize()	0	5	1
A	process()	0	5	1

<?php
/**
 * CakeCMS Community
 *
 * This file is part of the of the simple cms based on CakePHP 3.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @package     Community
 * @license     MIT
 * @copyright   MIT License http://www.opensource.org/licenses/mit-license.php
 * @link        https://github.com/CakeCMS/Community".
 * @author      Sergey Kalistratov <kalistratov.s.m@gmail.com>
 */

namespace Community\Controller\Admin;

use Community\Token;
use Core\Event\EventManager;
use Community\Model\Entity\User;
use Community\Model\Table\UsersTable;
use Cake\ORM\Exception\RolledbackTransactionException;
use Cake\Datasource\Exception\RecordNotFoundException;
use Cake\Datasource\Exception\InvalidPrimaryKeyException;

/**
 * Class UsersController
 *
 * @package Community\Controller\Admin
 * @property UsersTable $Users
 */
class UsersController extends AppController
{

    /**
     * Add action.
     *
     * @return \Cake\Http\Response|null
     *
     * @throws \Cake\ORM\Exception\RolledbackTransactionException
     */
    public function add()
    {
        $user = $this->Users->newEntity();
        if ($this->request->is('post')) {
            $user = $this->Users->patchEntity($user, $this->request->getData());

            if ($user->get('notify') === '1') {
                $user->set('token', Token::generate());
            }

            EventManager::trigger('Admin.Controller.User.Add.BeforeSave', $this, [
                'user' => $user
            ]);

            if ($result = $this->Users->save($user)) {
                EventManager::trigger('Admin.Controller.User.Add.AfterSave', $this, [
                    'user' => $result
                ]);

                $this->Flash->success(__d('community', 'The user {0} has been saved.', sprintf(
                    '<strong>«%s»</strong>',
                    $result->get('login')
                )));

                return $this->App->redirect(['apply' => ['action' => 'edit', $result->id]]);

Accessing id on the interface Cake\Datasource\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            } else {
                $this->Flash->error(__d('community', 'User could not be updated. Please, try again.'));
            }
        }

        $groups = $this->Users->Groups->getTreeList();

        $this
            ->set(compact('user', 'groups'))
            ->set('page_title', __d('community', 'Profiles: Add new user'));
    }

    /**
     * Edit action.
     *
     * @param null|int $id
     * @return \Cake\Http\Response|null
     *
     * @throws RecordNotFoundException
     * @throws InvalidPrimaryKeyException
     * @throws RolledbackTransactionException
     */
    public function edit($id = null)
    {
        /** @var User $user */
        $user = $this->Users->get($id);
        $groups = $this->Users->Groups->getTreeList();

        if ($this->request->is(['patch', 'post', 'put'])) {

This code seems to be duplicated across your project.

            $group = $this->Users->patchEntity($user, $this->request->getData());
            if ($result = $this->Users->save($group)) {
                $this->Flash->success(__d('community', 'The user {0} has been saved.', sprintf(
                    '<strong>«%s»</strong>',
                    $result->get('login')
                )));
                return $this->App->redirect([
                    'apply' => ['action' => 'edit', $result->id]

Accessing id on the interface Cake\Datasource\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

                ]);
            } else {
                $this->Flash->error(__d('community', 'User could not be updated. Please, try again.'));
            }
        }

        $this
            ->set(compact('user', 'groups'))
            ->set('page_title', __d('community', 'Profiles: Edit user - {0}', $user->name));
    }

    /**
     * Index action.
     *
     * @return void
     *
     * @throws \RuntimeException
     */
    public function index()
    {
        $query = $this->Users
            ->find('search', $this->Users->filterParams($this->request->getQueryParams()))
            ->contain('Groups');

        $this
            ->set('users', $this->paginate($query))

It seems like $query defined by $this->Users->find('search', $this->Users->filterParams($this->request->getQueryParams()))->contain('Groups') on line 124 can also be of type array; however, Cake\Controller\Controller::paginate() does only seem to accept object<Cake\ORM\Table>|string|object<Cake\ORM\Query>|null, maybe add an additional type check?

            ->set('page_title', __d('community', 'Profiles: User list'));
    }

    /**
     * Initialization hook method.
     *
     * Implement this method to avoid having to overwrite
     * the constructor and call parent.
     *
     * @return void
     *
     * @throws \Cake\Core\Exception\Exception
     */
    public function initialize()
    {
        parent::initialize();
        $this->Security->setConfig('unlockedFields', ['password', 'password_confirm']);
    }

    /**
     * Process action.
     *
     * @return \Cake\Http\Response|null
     */
    public function process()
    {
        list($action, $ids) = $this->Process->getRequestVars($this->name);
        return $this->Process->make($this->Users, $action, $ids);

It seems like $action defined by $this->Process->getRequestVars($this->name) on line 156 can also be of type array or null; however, Core\Controller\Component\ProcessComponent::make() does only seem to accept string, maybe add an additional type check?

    }
}