Community\Event\UserEventHandler

Complexity

Total Complexity

8

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	implementedEvents()	0	8	1
A	onSuccessActivate()	0	6	1
A	onModelBeforeSave()	0	5	1
A	onModelAfterSave()	0	11	4
A	_getMailer()	0	4	1

<?php
/**
 * CakeCMS Community
 *
 * This file is part of the of the simple cms based on CakePHP 3.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @package     Community
 * @license     MIT
 * @copyright   MIT License http://www.opensource.org/licenses/mit-license.php
 * @link        https://github.com/CakeCMS/Community".
 * @author      Sergey Kalistratov <kalistratov.s.m@gmail.com>
 */

namespace Community\Event;

use Cake\Event\Event;
use JBZoo\Utils\Filter;
use Community\Notify\Email;
use Community\Model\Entity\User;
use Cake\Datasource\EntityInterface;
use Cake\Event\EventListenerInterface;

/**
 * Class UserEventHandler
 *
 * @package Community\Event
 */
class UserEventHandler implements EventListenerInterface
{

    /**
     * Returns a list of events this object is implementing.
     *
     * @return  array
     */
    public function implementedEvents()
    {
        return [
            'Model.User.afterSave'             => 'onModelAfterSave',
            'Model.User.beforeSave'            => 'onModelBeforeSave',
            'Controller.Users.successActivate' => 'onSuccessActivate'
        ];
    }

    /**
     * On success user activation profile.
     *
     * @param   Event $event
     *
     * @return  void
     */
    public function onSuccessActivate(Event $event)
    {
        /** @var User|bool $user */
        $user = $event->getData('user');
        $this->_getMailer($user)->sendActivationMessage();

It seems like $user defined by $event->getData('user') on line 57 can also be of type boolean; however, Community\Event\UserEventHandler::_getMailer() does only seem to accept object<Cake\Datasource\EntityInterface>, maybe add an additional type check?

    }

    /**
     * Global before save user data.
     *
     * @param   Event $event
     *
     * @return  void
     */
    public function onModelBeforeSave(Event $event)
    {
        /** @var User $user */
        $user = $event->getData('user');

$user is not used, you could remove the assignment.

    }

    /**
     * Global after save user data.
     *
     * @param   Event $event
     *
     * @return  void
     *
     * TODO : Use return when send message?
     */
    public function onModelAfterSave(Event $event)
    {
        /** @var User|bool $user */
        $user = $event->getData('user');

        if ($user instanceof EntityInterface) {
            if ($user->isNew() && Filter::bool($user->get('notify'))) {
                $this->_getMailer($user)->sendCreateMessage();
            }
        }
    }

    /**
     * Get mailer object.
     *
     * @param   EntityInterface $entity
     * @return  Email
     */
    protected function _getMailer(EntityInterface $entity)
    {
        return new Email($entity);

$entity is of type object<Cake\Datasource\EntityInterface>, but the function expects a object<Cake\ORM\Entity>|array.

    }
}