Community\Controller\Admin\GroupsController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	133
Duplicated Lines	8.27 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	add()	0	20	3
A	down()	0	4	1
A	edit()	11	20	3
A	index()	0	5	1
A	initialize()	0	9	1
A	process()	0	5	1
A	up()	0	4	1

<?php
/**
 * CakeCMS Community
 *
 * This file is part of the of the simple cms based on CakePHP 3.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @package     Community
 * @license     MIT
 * @copyright   MIT License http://www.opensource.org/licenses/mit-license.php
 * @link        https://github.com/CakeCMS/Community".
 * @author      Sergey Kalistratov <kalistratov.s.m@gmail.com>
 */

namespace Community\Controller\Admin;

use Cake\Datasource\Exception\InvalidPrimaryKeyException;
use Cake\Datasource\Exception\RecordNotFoundException;
use Community\Model\Entity\Group;
use Community\Model\Table\GroupsTable;
use Core\Controller\Component\MoveComponent;
use Core\Controller\Component\ProcessComponent;
use Cake\ORM\Exception\RolledbackTransactionException;

/**
 * Class GroupsController
 *
 * @package     Community\Controller\Admin
 * @property    GroupsTable $Groups
 * @property    MoveComponent $Move
 * @property    ProcessComponent $Process
 */
class GroupsController extends AppController
{

    /**
     * Edit action.
     *
     * @return  mixed
     *
     * @throws  RolledbackTransactionException
     * @throws  \Aura\Intl\Exception
     */
    public function add()
    {
        $group = $this->Groups->newEntity();
        if ($this->request->is('post')) {
            $group  = $this->Groups->patchEntity($group, $this->request->getData());

It seems like $this->request->getData() targeting Cake\Http\ServerRequest::getData() can also be of type null or string; however, Cake\ORM\Table::patchEntity() does only seem to accept array, maybe add an additional type check?

            $result = $this->Groups->save($group);
            if ($result) {
                $this->Flash->success(__d('community', 'The group has been saved.'));
                return $this->App->redirect([
                    'apply' => ['action' => 'edit', $result->id],
                ]);
            } else {
                $this->Flash->error(__d('community', 'The group could not be saved. Please, try again.'));
            }
        }

        $parents = $this->Groups->getTreeList();
        $this->set(compact('group', 'parents'));
        $this->set('page_title', __d('community', 'Add new group'));
    }

    /**
     * Move down group action.
     *
     * @param   int $id Group id.
     * @return  \Cake\Http\Response|null
     */
    public function down($id)
    {
        return $this->Move->down($this->Groups, $id);
    }

    /**
     * Edit action.
     *
     * @param   int $id Group id.
     * @return  \Cake\Http\Response|null
     *
     * @throws  RecordNotFoundException
     * @throws  InvalidPrimaryKeyException
     * @throws  RolledbackTransactionException
     * @throws  \Aura\Intl\Exception
     */
    public function edit($id)
    {
        /** @var Group $group */
        $group = $this->Groups->get($id, ['contain' => []]);
        if ($this->request->is(['patch', 'post', 'put'])) {

This code seems to be duplicated across your project.

            $group = $this->Groups->patchEntity($group, $this->request->getData());

It seems like $this->request->getData() targeting Cake\Http\ServerRequest::getData() can also be of type null or string; however, Cake\ORM\Table::patchEntity() does only seem to accept array, maybe add an additional type check?

            if ($result = $this->Groups->save($group)) {
                $this->Flash->success(__d('community', 'The group has been updated.'));
                return $this->App->redirect([
                    'apply' => ['action' => 'edit', $result->id]
                ]);
            } else {
                $this->Flash->error(__d('community', 'The group could not be updated. Please, try again.'));
            }
        }

        $parents = $this->Groups->getTreeList();
        $this->set(compact('group', 'parents'));
        $this->set('page_title', __d('community', 'Edit group: {0}', $group->name));

Accessing name on the interface Cake\Datasource\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    /**
     * Index action.
     *
     * @return  void
     *
     * @throws  \Aura\Intl\Exception
     */
    public function index()
    {
        $this->set('groups', $this->Groups->getTreeList());
        $this->set('page_title', __d('community', 'User group list'));
    }

    /**
     * Initialization hook method.
     *
     * @return  void
     *
     * @throws  \Aura\Intl\Exception
     * @throws  \JBZoo\Utils\Exception
     * @throws  \Cake\Core\Exception\Exception When trying to set a key that is invalid.
     */
    public function initialize()
    {
        parent::initialize();

        $this->Move->setConfig('messages', [
            'success' => __d('community', 'Group has been moved'),
            'error'   => __d('community', 'Group could not been moved')
        ]);
    }

    /**
     * Process action.
     *
     * @return  \Cake\Http\Response|null
     *
     * @throws  \Aura\Intl\Exception
     */
    public function process()
    {
        list($action, $ids) = $this->Process->getRequestVars($this->name);
        return $this->Process->make($this->Groups, $action, $ids);

It seems like $action defined by $this->Process->getRequestVars($this->name) on line 150 can also be of type array or null; however, Core\Controller\Component\ProcessComponent::make() does only seem to accept string, maybe add an additional type check?

    }

    /**
     * Move up group action.
     *
     * @param   int $id Group id.
     * @return  \Cake\Http\Response|null
     *
     * @SuppressWarnings(PHPMD.ShortMethodName)
     */
    public function up($id)
    {
        return $this->Move->up($this->Groups, $id);
    }
}