FormHelper - Code Metrics - Inspection of "Add FormHelper and form templates" - CakeCMS/Backend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 885df8...d7de07 )

by Cheren

created 2016-08-30 18:55 UTC

FormHelper A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	3
Bugs	0	Features	3

Metric	Value
wmc	3
c	3
b	0
f	3
lcom	1
cbo	2
dl	0
loc	46
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
B	switcher()	0	25	3

<?php
/**
 * CakeCMS Backend
 *
 * This file is part of the of the simple cms based on CakePHP 3.
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @package   Backend
 * @license   MIT
 * @copyright MIT License http://www.opensource.org/licenses/mit-license.php
 * @link      https://github.com/CakeCMS/Backend".
 * @author    Sergey Kalistratov <[email protected]>
 */

namespace Backend\View\Helper;

use Core\View\Helper\FormHelper as CoreFormHelper;

/**
 * Class FormHelper
 *
 * @package Backend\View\Helper
 */
class FormHelper extends CoreFormHelper
{

    /**
    * List of helpers used by this helper.
    *
    * @var array
    */
    public $helpers = [
        'Url'  => ['className' => 'Core.Url'],
        'Html' => ['className' => 'Backend.Html'],
    ];

    /**
     * Form switcher.
     *
     * @param string $fieldName
     * @param array $options
     * @return string
     */
    public function switcher($fieldName, array $options = [])
    {
        $input = parent::checkbox($fieldName, $options);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

        $options += [
            'before' => __d('backend', 'Off'),
            'after'  => __d('backend', 'On')
        ];

        $title = (isset($options['title'])) ? $options['title'] : $fieldName;

        if (!empty($title)) {
            $title = $this->Html->div('switch-title', $title);
        }

        $content = $this->formatTemplate(__FUNCTION__, [
            'input'  => $input,
            'lever'  => '<span class="lever"></span>',
            'before' => $options['before'],
            'after'  => $options['after'],
            'title'  => $title,
        ]);

        return $content;
    }
}


1			<?php
2			/**
3			* CakeCMS Backend
4			*
5			* This file is part of the of the simple cms based on CakePHP 3.
6			* For the full copyright and license information, please view the LICENSE
7			* file that was distributed with this source code.
8			*
9			* @package Backend
10			* @license MIT
11			* @copyright MIT License http://www.opensource.org/licenses/mit-license.php
12			* @link https://github.com/CakeCMS/Backend".
13			* @author Sergey Kalistratov <[email protected]>
14			*/
15
16			namespace Backend\View\Helper;
17
18			use Core\View\Helper\FormHelper as CoreFormHelper;
19
20			/**
21			* Class FormHelper
22			*
23			* @package Backend\View\Helper
24			*/
25			class FormHelper extends CoreFormHelper
26			{
27
28			/**
29			* List of helpers used by this helper.
30			*
31			* @var array
32			*/
33			public $helpers = [
34			'Url' => ['className' => 'Core.Url'],
35			'Html' => ['className' => 'Backend.Html'],
36			];
37
38			/**
39			* Form switcher.
40			*
41			* @param string $fieldName
42			* @param array $options
43			* @return string
44			*/
45			public function switcher($fieldName, array $options = [])
46			{
47			$input = parent::checkbox($fieldName, $options);
			0 ignored issues – show Comprehensibility Bug introduced 2016-08-30 18:58 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`checkbox()` instead of `switcher()`). Are you sure this is correct? If so, you might want to change this to `$this->checkbox()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
48
49			$options += [
50			'before' => __d('backend', 'Off'),
51			'after' => __d('backend', 'On')
52			];
53
54			$title = (isset($options['title'])) ? $options['title'] : $fieldName;
55
56			if (!empty($title)) {
57			$title = $this->Html->div('switch-title', $title);
58			}
59
60			$content = $this->formatTemplate(__FUNCTION__, [
61			'input' => $input,
62			'lever' => '<span class="lever"></span>',
63			'before' => $options['before'],
64			'after' => $options['after'],
65			'title' => $title,
66			]);
67
68			return $content;
69			}
70			}
71

CakeCMS / Backend

Push — master ( 885df8...d7de07 )

FormHelper A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like