RecursiveFileListing::recursiveScan() - Code Metrics - Inspection of "temp dir creation" - CSFCloud/php-utils - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 939a6b...8ca850 )

by Bence

created 2018-04-30 16:34 UTC

RecursiveFileListing::recursiveScan() B

↳ Parent: RecursiveFileListing

Complexity

Conditions	7
Paths	6

Size

Total Lines	11
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	7

Importance

Changes

Metric	Value
cc	7
eloc	9
nc	6
nop	1
dl	0
loc	11
ccs	10
cts	10
cp	1
crap	7
rs	8.2222
c	0
b	0
f	0

<?php

namespace CSFCloud;

use Exception;

class RecursiveFileListing {

    private $root_dir;
    private $files;
    private $filters = [];

    public function __construct(string $dir) {
        if (!is_dir($dir)) {
            throw new Exception("Directory required");
        }

        $this->root_dir = $dir;
    }

    public function addFilter(string $regex) {
        $this->filters[] = $regex;
    }

    public function clearFilters() {
        $this->filters = [];
    }

    public function scan() : array {
        $this->files = [];
        $this->recursiveScan($this->root_dir);
        sort($this->files);
        return $this->files;
    }

    private function recursiveScan(string $dir) {
        $files = scandir($dir);
        foreach ($files as $filename) {
            if ($filename !== "." && $filename !== "..") {
                $file_path = $dir . "/" . $filename;
                if (is_file($file_path)) {
                    if ($this->isFileOk($file_path)) {
                        $this->files[] = $file_path;
                    }
                } else if (is_dir($file_path)) {
                    $this->recursiveScan($file_path);
                }
            }
        }
    }

    private function isFileOk(string $path) : bool {
        if (count($this->filters) == 0) {
            return true;
        }

        foreach ($this->filters as $filter) {
            if (preg_match($filter, $path)) {
                return true;
            }
        }

        return false;
    }

}


1		<?php
2
3		namespace CSFCloud;
4
5		use Exception;
6
7		class RecursiveFileListing {
8
9		private $root_dir;
10		private $files;
11		private $filters = [];
12
13	12	public function __construct(string $dir) {
14	12	if (!is_dir($dir)) {
15	3	throw new Exception("Directory required");
16		}
17
18	9	$this->root_dir = $dir;
19	9	}
20
21	6	public function addFilter(string $regex) {
22	6	$this->filters[] = $regex;
23	6	}
24
25	3	public function clearFilters() {
26	3	$this->filters = [];
27	3	}
28
29	9	public function scan() : array {
30	9	$this->files = [];
31	9	$this->recursiveScan($this->root_dir);
32	9	sort($this->files);
33	9	return $this->files;
34		}
35
36	9	private function recursiveScan(string $dir) {
37	9	$files = scandir($dir);
38	9	foreach ($files as $filename) {
39	9	if ($filename !== "." && $filename !== "..") {
40	9	$file_path = $dir . "/" . $filename;
41	9	if (is_file($file_path)) {
42	9	if ($this->isFileOk($file_path)) {
43	9	$this->files[] = $file_path;
44		}
45	9	} else if (is_dir($file_path)) {
46	9	$this->recursiveScan($file_path);
47		}
48		}
49		}
50	9	}
51
52	9	private function isFileOk(string $path) : bool {
53	9	if (count($this->filters) == 0) {
54	6	return true;
55		}
56
57	3	foreach ($this->filters as $filter) {
58	3	if (preg_match($filter, $path)) {
59	3	return true;
60		}
61		}
62
63	3	return false;
64		}
65
66		}
67

CSFCloud / php-utils

Push — master ( 939a6b...8ca850 )

RecursiveFileListing::recursiveScan() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like