vat_validator.js ➔ ... ➔ ??? - Code Metrics - Inspection of "Update Vat rates (#181)" - SolidInvoice/SolidInvoice - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2f6de4...35da10 )

by Pierre

created 2017-07-19 19:07 UTC

vat_validator.js ➔ ... ➔ ??? A

↳ Parent: vat_validator.js ➔ ... ➔ .attach

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

define(['jquery', 'routing'], ($, Routing) => {

    return {
        attach(element, input) {

            let $el = $(element),

                $input = $(input);

            $input.on('change', () => {

                if ('' === $input.val()) {
                    $input
                        .closest('.form-group')
                        .removeClass('has-success has-error')

                }
            });

            $el.on('click', (e) => {

                e.preventDefault();
                let original = $el.html();


                $el.html('<i class="fa fa-spin fa-refresh"></i>');

                $.ajax({
                    'url' : Routing.generate('_tax_number_validate'),
                    'data': {'vat_number': $input.val()},
                    'method': 'POST'
                }).done((result) => {

                    $input
                        .closest('.form-group')
                        .removeClass('has-success has-error')
                        .addClass(result.valid ? 'has-success' : 'has-error');
                }).always(() => {

                    $el.html(original);
                });
            });
        }
    };
});

1			define(['jquery', 'routing'], ($, Routing) => {
			0 ignored issues – show Configuration introduced 2017-07-18 18:24 UTC by Report Bug Copy Issue Report 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6'). Generally using ECMAScript 6 specific syntax is fine if you are sure that it is already supported by all engines which are supposed to run this code. Further Reading: JSHint esnext option Draft Specification for ES.next (ECMA-262 Ed. 6) Loading history...
2			return {
3			attach(element, input) {
			0 ignored issues – show Backwards Compatibility introduced 2017-07-18 18:24 UTC by Report Bug Copy Issue Report 'concise methods' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz). Loading history...
4			let $el = $(element),
			0 ignored issues – show Backwards Compatibility introduced 2017-07-18 18:24 UTC by Report Bug Copy Issue Report 'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz). Loading history...
5			$input = $(input);
6
7			$input.on('change', () => {
			0 ignored issues – show Configuration introduced 2017-07-18 18:24 UTC by Report Bug Copy Issue Report 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6'). Generally using ECMAScript 6 specific syntax is fine if you are sure that it is already supported by all engines which are supposed to run this code. Further Reading: JSHint esnext option Draft Specification for ES.next (ECMA-262 Ed. 6) Loading history...
8			if ('' === $input.val()) {
9			$input
10			.closest('.form-group')
11			.removeClass('has-success has-error')
			0 ignored issues – show Coding Style introduced 2017-07-18 18:24 UTC by Report Bug Copy Issue Report There should be a semicolon. Requirement of semicolons purely is a coding style issue since JavaScript has specific rules about semicolons which are followed by all browsers. Further Readings: An Open Letter to JavaScript Leaders Regarding Semicolons by Isaac Schlueter JavaScript Semicolon Insertion Loading history...
12			}
13			});
14
15			$el.on('click', (e) => {
			0 ignored issues – show Configuration introduced 2017-07-18 18:24 UTC by Report Bug Copy Issue Report 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6'). Generally using ECMAScript 6 specific syntax is fine if you are sure that it is already supported by all engines which are supposed to run this code. Further Reading: JSHint esnext option Draft Specification for ES.next (ECMA-262 Ed. 6) Loading history...
16			e.preventDefault();
17			let original = $el.html();
			0 ignored issues – show Backwards Compatibility introduced 2017-07-18 18:24 UTC by Report Bug Copy Issue Report 'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz). Loading history...
18
19			$el.html('<i class="fa fa-spin fa-refresh"></i>');
20
21			$.ajax({
22			'url' : Routing.generate('_tax_number_validate'),
23			'data': {'vat_number': $input.val()},
24			'method': 'POST'
25			}).done((result) => {
			0 ignored issues – show Configuration introduced 2017-07-18 18:24 UTC by Report Bug Copy Issue Report 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6'). Generally using ECMAScript 6 specific syntax is fine if you are sure that it is already supported by all engines which are supposed to run this code. Further Reading: JSHint esnext option Draft Specification for ES.next (ECMA-262 Ed. 6) Loading history...
26			$input
27			.closest('.form-group')
28			.removeClass('has-success has-error')
29			.addClass(result.valid ? 'has-success' : 'has-error');
30			}).always(() => {
			0 ignored issues – show Configuration introduced 2017-07-18 18:24 UTC by Report Bug Copy Issue Report 'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6'). Generally using ECMAScript 6 specific syntax is fine if you are sure that it is already supported by all engines which are supposed to run this code. Further Reading: JSHint esnext option Draft Specification for ES.next (ECMA-262 Ed. 6) Loading history...
31			$el.html(original);
32			});
33			});
34			}
35			};
36			});

SolidInvoice / SolidInvoice

Scrutinizer GitHub App not installed

Push — master ( 2f6de4...35da10 )

vat_validator.js ➔ ... ➔ ??? A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like