Python.LocalDB.test_LocalDBQuery.UT_LocalDBCreate.test_SubjectUpdate() - Code Metrics - Inspection of "Major update" - CNBP/DICOMTransit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Yang

created 2018-09-20 19:35 UTC

UT_LocalDBCreate.test_SubjectUpdate() B

↳ Parent: Python.LocalDB.test_LocalDBQuery

Complexity

Conditions

Size

Total Lines	61
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	40
nop	0
dl	0
loc	61
rs	8.92
c	0
b	0
f	0

How to fix Long Method

import sqlite3
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
from pathlib import Path
import logging
import os
import sys
from LocalDB.query import LocalDB_query

from LocalDB.create_CNBP import LocalDB_createCNBP

from dotenv import load_dotenv
import unittest


logging.basicConfig(stream=sys.stdout, level=logging.INFO)


class UT_LocalDBCreate(unittest.TestCase):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

    @staticmethod
    def test_CreateSubject():
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        logger = logging.getLogger('UT_CreateSubject')
        PathString = "TestCNBPQuery.sqlite"


        # if SQL already exist, quit script.
        SQLPath = Path(PathString)


        # check if path is a file and exist.
        if SQLPath.is_file():
            logger.info('Test SQLite database file already exist. Gonna mess with it!')
            ''''Delete current database! During testing only'''

            os.remove(PathString)

        # Create the database
        assert LocalDB_createCNBP.database(PathString)
        logger.info('Test SQLite database successfully created. Gonna mess with it!')

        tableName = 'id_table'  # All CNBP database should have this table name.

        MRNColumn = "MRN"


        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 291033)
        logger.info('Test SQLite database successfully inserted with mock records. Gonna check!')

        # Populate the table with some fake records.
        ConnectedDatabase = sqlite3.connect(PathString)

        c = ConnectedDatabase.cursor()

        c.execute(
            'SELECT * FROM {tablename} WHERE {columnname}="{columnvalue}"'.
                format(tablename=tableName, columnname=MRNColumn,columnvalue=291033))

        ResultRows = c.fetchall()


        assert len(ResultRows) > 0


        # Closing the connection to the database file
        ConnectedDatabase.close()

        # Remove test data base created
        os.remove(PathString)

        return True

    @staticmethod
    def test_CheckSubjectExist():
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        logger = logging.getLogger('UT_CheckSubjectExist')
        PathString = "TestCNBPQuery.sqlite"


        # if SQL already exist, quit script.
        SQLPath = Path(PathString)


        # check if path is a file and exist.
        if SQLPath.is_file():
            logger.info('Test SQLite database file already exist. Gonna mess with it!')
            ''''Delete current database! During testing only'''

            os.remove(PathString)

        # Create the database
        assert LocalDB_createCNBP.database(PathString)
        logger.info('Test SQLite database successfully created. Gonna mess with it!')

        tableName = 'id_table'  # All CNBP database should have this table name.

        MRNColumn = "MRN"

        CNBPIDColumn = "CNBPID"


        # Populate the table with some fake records.
        ConnectedDatabase = sqlite3.connect(PathString)

        c = ConnectedDatabase.cursor()

        c.execute("INSERT INTO {tn} ({mrn},{cnbpid}) VALUES (291010,'CNBP0010001')".
                  format(tn=tableName, mrn=MRNColumn, cnbpid=CNBPIDColumn))
        c.execute("INSERT INTO {tn} ({mrn},{cnbpid}) VALUES (292010,'CNBP0020001')".
                  format(tn=tableName, mrn=MRNColumn, cnbpid=CNBPIDColumn))
        c.execute("INSERT INTO {tn} ({mrn},{cnbpid}) VALUES (295010,'CNBP0010001')".
                  format(tn=tableName, mrn=MRNColumn, cnbpid=CNBPIDColumn))
        c.execute("INSERT INTO {tn} ({mrn},{cnbpid}) VALUES (297120,'CNBP0030001')".
                  format(tn=tableName, mrn=MRNColumn, cnbpid=CNBPIDColumn))
        c.execute("INSERT INTO {tn} ({mrn},{cnbpid}) VALUES (291310,'CNBP0510001')".
                  format(tn=tableName, mrn=MRNColumn, cnbpid=CNBPIDColumn))
        ConnectedDatabase.commit()
        ConnectedDatabase.close()

        logger.info('Test SQLite database successfully inserted with mock records. Gonna mess with it!')


        # Create on Connecting to the database file
        assert(LocalDB_query.check_value(PathString, tableName, "MRN", 291010))

        assert(LocalDB_query.check_value(PathString, tableName, "CNBPID", "CNBP0010001"))


        # Remove test data base created
        os.remove(PathString)

        return True

    @staticmethod
    def test_CreateSubjectCheckExist():
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        logger = logging.getLogger('UT_CreateAndCheck')
        PathString = "TestCNBPQuery.sqlite"


        # if SQL already exist, quit script.
        SQLPath = Path(PathString)


        # check if path is a file and exist.
        if SQLPath.is_file():
            logger.info('Test SQLite database file already exist. Gonna mess with it!')
            ''''Delete current database! During testing only'''

            os.remove(PathString)

        # Create the database
        assert LocalDB_createCNBP.database(PathString)
        logger.info('Test SQLite database successfully created. Gonna mess with it!')

        tableName = 'id_table'  # All CNBP database should have this table name.

        MRNColumn = "MRN"


        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 2918210)
        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 23452346)
        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 2345234)
        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 273411)
        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 364573)
        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 7424141)

        success, _ = LocalDB_query.check_value(PathString, tableName, MRNColumn, 7129112)
        assert not success

        success, _ = LocalDB_query.check_value(PathString, tableName, MRNColumn, 2918210)
        assert success

        success, _ = LocalDB_query.check_value(PathString, tableName, MRNColumn, 712921)
        assert not success

        success, _ = LocalDB_query.check_value(PathString, tableName, MRNColumn, 742)
        assert not success

        success, _ = LocalDB_query.check_value(PathString, tableName, MRNColumn, 364573)
        assert success

        logger.info('Tested SQLIte database entry. ')

        # Remove test data base created
        os.remove(PathString)

        return True

    @staticmethod
    def test_SubjectUpdate():
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        logger = logging.getLogger('UT_CreateAndCheck')
        PathString = "TestCNBPQuery.sqlite"


        # if SQL already exist, quit script.
        SQLPath = Path(PathString)


        # check if path is a file and exist.
        if SQLPath.is_file():
            logger.info('Test SQLite database file already exist. Gonna mess with it!')
            ''''Delete current database! During testing only'''

            os.remove(PathString)

        # Create the database
        assert LocalDB_createCNBP.database(PathString)
        logger.info('Test SQLite database successfully created. Gonna mess with it!')

        tableName = 'id_table'  # All CNBP database should have this table name.

        MRNColumn = "MRN"

        CNBPIDColumn = "CNBPID"


        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 2918210)
        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 23452346)
        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 2345234)
        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 273411)
        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 364573)
        LocalDB_query.create_entry(PathString, tableName, MRNColumn, 7424141)

        success = load_dotenv()
        if not success:
            raise ImportError("Credential .env NOT FOUND! Please ensure .env is set with all the necessary credentials!")


        Prefix = os.getenv("institutionID")


        LocalDB_query.update_entry(PathString, tableName, MRNColumn, 7424141, CNBPIDColumn, Prefix + "0010001")

        LocalDB_query.update_entry(PathString, tableName, MRNColumn, 2345234, CNBPIDColumn, Prefix + "0010002")

        LocalDB_query.update_entry(PathString, tableName, MRNColumn, 2918210, CNBPIDColumn, Prefix + "0010003")

        LocalDB_query.update_entry(PathString, tableName, MRNColumn, 273411, CNBPIDColumn, Prefix + "0010004")


        success, _ = LocalDB_query.check_value(PathString, tableName, CNBPIDColumn, 'CNBPID0010006')
        assert not success

        success, _ = LocalDB_query.check_value(PathString, tableName, CNBPIDColumn, Prefix + "0010001")

        assert success

        success, _ = LocalDB_query.check_value(PathString, tableName, CNBPIDColumn, 55555)
        assert not success

        success, _ = LocalDB_query.check_value(PathString, tableName, CNBPIDColumn, 742)
        assert not success

        success, _ = LocalDB_query.check_value(PathString, tableName, CNBPIDColumn, Prefix + "0010003")

        assert success

        logger.info('Tested SQLIte database entry. ')

        # Remove test data base created
        os.remove(PathString)

        return True

if __name__ == '__main__':
    UT_LocalDBCreate.test_SubjectUpdate()


1			import sqlite3
			0 ignored issues – show Coding Style Naming introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The name `test_LocalDBQuery` does not conform to the module naming conventions (`(([a-z_][a-z0-9_]*)\|([A-Z][a-zA-Z0-9]+))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			from pathlib import Path
3			import logging
4			import os
5			import sys
6			from LocalDB.query import LocalDB_query
			0 ignored issues – show Bug introduced 2018-09-12 21:17 UTC by Report Bug Copy Issue Report The name `query` does not seem to exist in module `LocalDB`. Loading history... introduced 2018-09-12 21:17 UTC by Report Bug Copy Issue Report Unable to import 'LocalDB.query' Loading history...
7			from LocalDB.create_CNBP import LocalDB_createCNBP
			0 ignored issues – show Bug introduced 2018-09-12 21:17 UTC by Report Bug Copy Issue Report The name `create_CNBP` does not seem to exist in module `LocalDB`. Loading history... introduced 2018-09-12 21:17 UTC by Report Bug Copy Issue Report Unable to import 'LocalDB.create_CNBP' Loading history...
8			from dotenv import load_dotenv
9			import unittest
			0 ignored issues – show introduced 2018-09-12 21:17 UTC by Report Bug Copy Issue Report standard import "import unittest" should be placed before "from LocalDB.query import LocalDB_query" Loading history...
10
11			logging.basicConfig(stream=sys.stdout, level=logging.INFO)
12
13
14			class UT_LocalDBCreate(unittest.TestCase):
			0 ignored issues – show Coding Style Naming introduced 2018-09-12 21:17 UTC by Report Bug Copy Issue Report The name `UT_LocalDBCreate` does not conform to the class naming conventions (`[A-Z_][a-zA-Z0-9]+$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-09-12 21:17 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-09-12 21:17 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
15
16			@staticmethod
17			def test_CreateSubject():
			0 ignored issues – show Coding Style Naming introduced 2018-09-12 21:17 UTC by Report Bug Copy Issue Report The name `test_CreateSubject` does not conform to the method naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-09-12 21:17 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
18			logger = logging.getLogger('UT_CreateSubject')
19			PathString = "TestCNBPQuery.sqlite"
			0 ignored issues – show Coding Style Naming introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The name `PathString` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
20
21			# if SQL already exist, quit script.
22			SQLPath = Path(PathString)
			0 ignored issues – show Coding Style Naming introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The name `SQLPath` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
23
24			# check if path is a file and exist.
25			if SQLPath.is_file():
26			logger.info('Test SQLite database file already exist. Gonna mess with it!')
27			''''Delete current database! During testing only'''
			0 ignored issues – show Unused Code introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report This string statement has no effect and could be removed. Loading history...
28			os.remove(PathString)
29
30			# Create the database
31			assert LocalDB_createCNBP.database(PathString)

CNBP / DICOMTransit

Pull Request — master (#3)

UT_LocalDBCreate.test_SubjectUpdate() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like