Python.LocalDB.create

Complexity

Total Complexity

8

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	LocalDB_create.database()	0	64	8

import sys

This module should have a docstring.

import sqlite3
import logging
from pathlib import Path
from LocalDB.schema import CNBP_blueprint

The name schema does not seem to exist in module LocalDB.

Unable to import 'LocalDB.schema'

# This file database a SQLite local database for CNBP requirement.
# Creation: 2018-07-11T160228EST
# Author: Yang Ding


logging.basicConfig(stream=sys.stdout, level=logging.INFO)
logger = logging.getLogger('database')

The name logger does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

class LocalDB_create:

The name LocalDB_create does not conform to the class naming conventions ([A-Z_][a-zA-Z0-9]+$).

This class should have a docstring.

The variable __class__ seems to be unused.

    @staticmethod
    def database(PathString, TableName, KeyFieldString, ColumnsNameTypeList):

The name PathString does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The name TableName does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The name KeyFieldString does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The name ColumnsNameTypeList does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        """
        Create the local database based on schema.
        :param PathString:
        :param TableName:
        :param KeyFieldString:
        :param ColumnsNameTypeList:
        :return:
        """


        # if SQL already exist, quit script.
        SQLPath = Path(PathString)

The name SQLPath does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        # check if path is a fiela nd exist.
        if SQLPath.is_file():
            logger.info('SQLite database file already exist. Not gonna mess with it!')
            return False
        '''Delete current database! During testing only'''

This string statement has no effect and could be removed.

        '''os.remove(sqliteFile)
        logger.info('DEBUG: database file already exist. Deleted it!')'''

This string statement has no effect and could be removed.

        #Create the PRIMARY KEY column.
        KeyFieldType = CNBP_blueprint.keyfield_type  # column data type

The name KeyFieldType does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        #Try to connect the database to start the process:

        try:
            # Create on Connecting to the database file
            ConnectedDatabase = sqlite3.connect(PathString)

The name ConnectedDatabase does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            c = ConnectedDatabase.cursor()

The name c does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            logger.info('Creating PRIMARY KEY DBKEY column in database.')

            # Creating a new SQLite table with DBKey column (inspired by: https://sebastianraschka.com/Articles/2014_sqlite_in_python_tutorial.html)

This line is too long as per the coding-style (148/100).

            c.execute('CREATE TABLE {tn} ({nf} {ft} PRIMARY KEY)'.format(tn=TableName, nf=KeyFieldString, ft=KeyFieldType))

This line is too long as per the coding-style (123/100).

            logger.info('PRIMARY KEY DBKEY column successfully created in database.')

            logger.info('Creating secondary columns in database.')

            # Adding accessory columns via a loop
            for column in ColumnsNameTypeList:
                if (column[1] != "TEXT" and
                    column[1] != "REAL" and

Wrong continued indentation before block (add 4 spaces).

                    column[1] != "BLOB" and

Wrong continued indentation before block (add 4 spaces).

                    #column[1] != "NULL" and

Wrong continued indentation before block (add 4 spaces).

                    column[1] != "INTEGER"):

Wrong continued indentation before block (add 4 spaces).

                    continue  # skip iteration is the data type is not specified properly.
                else:
                    c.execute("ALTER TABLE {tn} ADD COLUMN '{cn}' {ct}".format(tn=TableName, cn=column[0], ct=column[1]))

This line is too long as per the coding-style (121/100).

            logger.info('Secondary columns created in database.')

            # Committing changes and closing the connection to the database file
            ConnectedDatabase.commit()
            ConnectedDatabase.close()
        except Exception as e:

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            logger.info(e)
            logger.info('SQLite database creation/update issue, suspect schema non-compliant SQLite database. Did you corrupt this SQLite database somehow?')

This line is too long as per the coding-style (157/100).

            raise IOError
        return True