Python.Integration.orthanc_to_DICOMs

Complexity

Total Complexity

8

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes

0

2 Functions

Rating	Name	Duplication	Size	Complexity
A	step2_dicom2LORIS()	0	2	1
B	step1_orthanc2DICOM()	0	42	7

from orthanc.query import orthanc_query

The name orthanc_to_DICOMs does not conform to the module naming conventions ((([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$).

This module should have a docstring.

Unable to import 'orthanc.query'

from LORIS.helper import LORIS_helper

Unable to import 'LORIS.helper'

import os

standard import "import os" should be placed before "from orthanc.query import orthanc_query"

import logging

standard import "import logging" should be placed before "from orthanc.query import orthanc_query"

def step1_orthanc2DICOM(data_folder_path):

The name step1_orthanc2DICOM does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    """
    The purpose of this function is to connect to orthanc, retrieve a list of subjects, download each one in turn and unzip them somewhere.

This line is too long as per the coding-style (139/100).

    :return: whether it succeeded, and if succeeded, a list of all folders.
    """
    logger = logging.getLogger("Step1: Orthanc to DICOM files")

    # Input check
    if not os.path.exists(data_folder_path) or not os.path.isdir(data_folder_path):
        logger.info("Bad data folder path")
        return False, None

    # Query Orthanc for all subjects
    reseponse_code, list_subjects = orthanc_query.getOrthanc("patients/")
    if not LORIS_helper.is_response_success(reseponse_code, 200):
        logger.info("Could not connect to Orthanc.")
        return False, None

    all_subject_folder_paths = []

    # For all subjects, unzip them somewhere.
    for subject in list_subjects:

        status, zip_file = orthanc_query.getPatientZipOrthanc(subject)

        # Checks for output from getPatientZipOrthanc
        if not LORIS_helper.is_response_success(status, 200):
            logger.info("Could not get patient zip files from Orthanc")
            return False, None
        if not os.path.exists(zip_file):
            logger.info("Could not locate saved zip files after dowwnloading from Orthanc")
            return False, None

        # Create a directory based on the zip file, which has UUID as name and guarnteed to be unique.

This line is too long as per the coding-style (102/100).

        file, ext = os.path.splitext(zip_file)

The variable ext seems to be unused.

        final_folder_name = data_folder_path + file
        os.mkdir(final_folder_name)
        orthanc_query.flatUnZip(zip_file, final_folder_name) #files are guarnteed to be unique and no overwrite of each other. .

This line is too long as per the coding-style (128/100).

        # Keep track of path extracted to for subsequent processing.
        all_subject_folder_paths.append(final_folder_name)
    return True, all_subject_folder_paths

def step2_dicom2LORIS(folder_paths):

The name step2_dicom2LORIS does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The argument folder_paths seems to be unused.

    """
    Within each folder, verify they all have the same PatientID.
    :param folder_paths:
    :return:
    """

Trailing newlines