Python.DICOM.validate.DICOM_validate.path()

Complexity

Conditions

10

Size

Total Lines	57
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

import sys
    @staticmethod
    def path(dir_path):
        """
        Some basic information of the participants must be consistent across the files, such as the SCAN DATE (assuming they are not scanning across MIDNIGHT POINT)

This line is too long as per the coding-style (164/100).

        Birthday date, subject name, etc MUST BE CONSISTENT across a SINGLE subject's folder, RIGHT!

        :param dir_path:
        :return:
        """
        logger = logging.getLogger(__name__)


        # Input check
        if not os.path.exists(dir_path) or not os.path.isdir(dir_path):
            logger.info("Bad data folder path")
            return False

        files = os.listdir(dir_path)

        # Used to record the first encountered patientID and name, and will check against subsequent folder for same matching information.

This line is too long as per the coding-style (138/100).

        global PatientID, PatientName

The name PatientID does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

The name PatientName does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

Global variable 'PatientID' undefined at the module level

Global variable 'PatientName' undefined at the module level

        validated_DICOM_files = []

The name validated_DICOM_files does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        from DICOM.elements import DICOM_elements

Unable to import 'DICOM.elements'

        logger.info("Checking individual dicom files for patient info consistencies")

        # Check individual DICOM file for consistencies.
        for file in tqdm(files):

            # Skip current file if they are not DICOM files.
            isDICOM, _ = DICOM_validate.file(file)

The name isDICOM does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            if not isDICOM:
                continue

            # Record first instance of patient ID and patient name.
            if PatientID is None and PatientName is None:

The variable PatientID was used before it was assigned.

The variable PatientName was used before it was assigned.

                Success, PatientID = DICOM_elements.retrieve(files[0], "PatientID")

The name Success does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

                Success, PatientName = DICOM_elements.retrieve(files[0], "PatientName")

The name Success does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

                # raise issue if not successful
                if not Success:
                    logger.info("DICOME meta data retrieval failure.")
                    return False
                continue

            # Check consistencies across folders in terms of patient ID, NAME.
            CurrentPatientID = DICOM_elements.retrieve(file, "PatientID")

The name CurrentPatientID does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            CurrentPatientName = DICOM_elements.retrieve(file, "PatientName")

The name CurrentPatientName does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            if not (PatientID == CurrentPatientID) or not (PatientName == CurrentPatientName):

There is an unnecessary parenthesis after not.

                logger.info("PatientID or Name mismatch from the dicom archive. .")
                return False

            validated_DICOM_files.append(file)

        return True, validated_DICOM_files