Python.LocalDB.create.LocalDBCreate()

Complexity

Conditions

8

Size

Total Lines	62
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

#This file create a SQLite local database for CNBP requirement.
def LocalDBCreate(PathString, TableName, KeyFieldString, ColumnsNameTypeList):

The name LocalDBCreate does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The name PathString does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The name TableName does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The name KeyFieldString does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The name ColumnsNameTypeList does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    """
    Create the local database based on sceham.
    :param PathString:
    :param TableName:
    :param KeyFieldString:
    :param ColumnsNameTypeList:
    :return:
    """


    # if SQL already exist, quit script.
    SQLPath = Path(PathString)

The name SQLPath does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    # check if path is a fiela nd exist.
    if SQLPath.is_file():
        logger.info('SQLite database file already exist. Not gonna mess with it!')
        return False
        '''Delete current database! During testing only'''

This code does not seem to be reachable.

This string statement has no effect and could be removed.

        '''os.remove(sqliteFile)
        logger.info('DEBUG: database file already exist. Deleted it!')'''

This string statement has no effect and could be removed.

    #Create the PRIMARY KEY column.
    KeyFieldType = CNBP_schema_keyfield_type  # column data type

The variable CNBP_schema_keyfield_type does not seem to be defined.

The name KeyFieldType does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

Undefined variable 'CNBP_schema_keyfield_type'

    #Try to connect the database to start the process:

    try:
        # Create on Connecting to the database file
        ConnectedDatabase = sqlite3.connect(PathString)

The name ConnectedDatabase does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        c = ConnectedDatabase.cursor()

The name c does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        logger.info('Creating PRIMARY KEY DBKEY column in database.')

        # Creating a new SQLite table with DBKey column (inspired by: https://sebastianraschka.com/Articles/2014_sqlite_in_python_tutorial.html)

This line is too long as per the coding-style (144/100).

        c.execute('CREATE TABLE {tn} ({nf} {ft} PRIMARY KEY)'.format(tn=TableName, nf=KeyFieldString, ft=KeyFieldType))

This line is too long as per the coding-style (119/100).

        logger.info('PRIMARY KEY DBKEY column successfully created in database.')

        logger.info('Creating secondary columns in database.')

        # Adding accessory columns via a loop
        for column in ColumnsNameTypeList:
            if (column[1] != "TEXT" and
                column[1] != "REAL" and

Wrong continued indentation before block (add 4 spaces).

                column[1] != "BLOB" and

Wrong continued indentation before block (add 4 spaces).

                #column[1] != "NULL" and

Wrong continued indentation before block (add 4 spaces).

                column[1] != "INTEGER"):

Wrong continued indentation before block (add 4 spaces).

                continue  # skip iteration is the data type is not specified properly.
            else:
                c.execute("ALTER TABLE {tn} ADD COLUMN '{cn}' {ct}".format(tn=TableName, cn=column[0], ct=column[1]))

This line is too long as per the coding-style (117/100).

        logger.info('Secondary columns created in database.')

        # Committing changes and closing the connection to the database file
        ConnectedDatabase.commit()
        ConnectedDatabase.close()
    except:
        logger.info('SQLite database creation/update issue, suspect schema non-compliant SQLite database. Did you corrupt this SQLite database somehow?')

This line is too long as per the coding-style (153/100).

        raise IOError
    return True

Final newline missing