Python.LORIS.ServerSite.ServerResponse() - Code Metrics - Inspection of "Dicom Anonymization" - CNBP/DICOMTransit - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2)

by Yang

created 2018-08-01 16:20 UTC

Python.LORIS.ServerSite.ServerResponse() A

↳ Parent: Python.LORIS.ServerSite

Complexity

Conditions

Size

Total Lines	2
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	2
dl	0
loc	2
rs	10
c	0
b	0
f	0
cc	1
nop	2

import sys
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
import os

import argparse
import getpass
import logging

logging.basicConfig(stream=sys.stdout, level=logging.INFO)



def ServerResponse(InstitutionID, protocolName):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    logger = logging.getLogger('LORISServerResponse')


    #Resolved protocolname to CNBPID pattern.


    #if "protocol"









if __name__ == '__main__':


    parser = argparse.ArgumentParser(description=__doc__)

    parser.add_argument('-u', '--user', dest='email', type=str, help='Username/Email used for login')

    parser.add_argument('-p', '--production', dest='production', action='store_true', help='Example of boolean arg')

    parser.add_argument('-o', '--option', dest='option', type=str, help='Example of str arg')

    parser.add_argument('file', metavar='file', type=str, help='Example of a positional argument')

    args = parser.parse_args()

    logger.info('--------------')


    # Never ask for a password in command-line. Manually ask for it here
    password = getpass.getpass()


    logger.info('Hello World!')



1		import sys
		0 ignored issues – show Coding Style introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2		import os
		0 ignored issues – show Unused Code introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The import `os` seems to be unused. Loading history...
3		import argparse
4		import getpass
5		import logging
6
7		logging.basicConfig(stream=sys.stdout, level=logging.INFO)
8
9
10
11		def ServerResponse(InstitutionID, protocolName):
		0 ignored issues – show Coding Style Naming introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The name `ServerResponse` does not conform to the function naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style Naming introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The name `InstitutionID` does not conform to the argument naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style Naming introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The name `protocolName` does not conform to the argument naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The argument `protocolName` seems to be unused. Loading history... Unused Code introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The argument `InstitutionID` seems to be unused. Loading history...
12		logger = logging.getLogger('LORISServerResponse')
		0 ignored issues – show Unused Code introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The variable `logger` seems to be unused. Loading history...
13
14		#Resolved protocolname to CNBPID pattern.
15
16
17		#if "protocol"
18
19
20
21
22
23
24
25
26
27	View Code Duplication	if __name__ == '__main__':
		0 ignored issues – show Duplication introduced 2018-07-26 18:31 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
28
29		parser = argparse.ArgumentParser(description=__doc__)
		0 ignored issues – show Coding Style Naming introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The name `parser` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
30		parser.add_argument('-u', '--user', dest='email', type=str, help='Username/Email used for login')
		0 ignored issues – show Coding Style introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report This line is too long as per the coding-style (101/100). This check looks for lines that are too long. You can specify the maximum line length. Loading history...
31		parser.add_argument('-p', '--production', dest='production', action='store_true', help='Example of boolean arg')
		0 ignored issues – show Coding Style introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report This line is too long as per the coding-style (116/100). This check looks for lines that are too long. You can specify the maximum line length. Loading history...
32		parser.add_argument('-o', '--option', dest='option', type=str, help='Example of str arg')
33
34		parser.add_argument('file', metavar='file', type=str, help='Example of a positional argument')
35
36		args = parser.parse_args()
		0 ignored issues – show Coding Style Naming introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The name `args` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
37		logger.info('--------------')
		0 ignored issues – show Comprehensibility Best Practice introduced 2018-07-26 18:31 UTC by Report Bug Copy Issue Report The variable `logger` does not seem to be defined. Loading history... Comprehensibility Best Practice introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report Undefined variable 'logger' Loading history...
38
39		# Never ask for a password in command-line. Manually ask for it here
40		password = getpass.getpass()
		0 ignored issues – show Coding Style Naming introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report The name `password` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
41
42		logger.info('Hello World!')
		0 ignored issues – show Comprehensibility Best Practice introduced 2018-07-31 12:18 UTC by Report Bug Copy Issue Report Undefined variable 'logger' Loading history...
43

CNBP / DICOMTransit

Pull Request — master (#2)

Python.LORIS.ServerSite.ServerResponse() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like