Python.orthanc.query

Complexity

Total Complexity

6

Size/Duplication

Total Lines	71
Duplicated Lines	77.46 %

Importance

Changes

0

3 Functions

Rating	Name	Duplication	Size	Complexity
A	deleteOrthanc()	18	18	2
A	postOrthanc()	19	19	2
A	getOrthanc()	18	18	2

import requests

This module should have a docstring.

import logging

standard import "import logging" should be placed before "import requests"

import os

standard import "import os" should be placed before "import requests"

import sys

standard import "import sys" should be placed before "import requests"

from dotenv import load_dotenv

logging.basicConfig(stream=sys.stdout, level=logging.INFO)
logger = logging.getLogger('Orthanc Query:')

The name logger does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

def getOrthanc(endpoint):

This code seems to be duplicated in your project.

The name getOrthanc does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    """
    Get from a Orthanc endpoint
    :param endpoint:
    :return: bool on if such PSCID (INSTITUTIONID + PROJECTID + SUBJECTID) exist already.
    """
    logger = logging.getLogger('Orthanc_get')

logger is re-defining a name which is already available in the outer-scope (previously defined on line 8).

    logger.info("Getting Orthanc endpoint: "+ endpoint + "at")
    load_dotenv()
    url = os.getenv("OrthancURL")
    updatedurl = url + endpoint
    logger.info(updatedurl)

    with requests.Session() as s:

The name s does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        r = s.get(updatedurl)

The name r does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        logger.info("Get Result:" + str(r.status_code) + r.reason)

        return r.status_code, r.json()

def postOrthanc(endpoint, data):

This code seems to be duplicated in your project.

The name postOrthanc does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    """
    Get from a Orthanc endpoint
    :param endpoint:
    :return: bool on if such PSCID (INSTITUTIONID + PROJECTID + SUBJECTID) exist already.
    """
    logger = logging.getLogger('Orthanc_post')

logger is re-defining a name which is already available in the outer-scope (previously defined on line 8).

    logger.info("Post Orthanc endpoint: "+ endpoint + "at")
    load_dotenv()
    url = os.getenv("OrthancURL")
    updatedurl = url + endpoint
    logger.info(updatedurl)

    with requests.Session() as s:

The name s does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        r = s.post(updatedurl, files=data)

The name r does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        logger.info("Post Result:" + str(r.status_code) + r.reason)

        return r.status_code, r


def deleteOrthanc(endpoint):

This code seems to be duplicated in your project.

The name deleteOrthanc does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    """
    Delete from a Orthanc endpoint
    :param endpoint:
    :return: bool on if such PSCID (INSTITUTIONID + PROJECTID + SUBJECTID) exist already.
    """
    logger = logging.getLogger('Orthanc_delete')

logger is re-defining a name which is already available in the outer-scope (previously defined on line 8).

    logger.info("Deleting Orthanc endpoint: "+ endpoint + "at")
    load_dotenv()
    url = os.getenv("OrthancURL")
    updatedurl = url + endpoint
    logger.info(updatedurl)

    with requests.Session() as s:

The name s does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        r = s.delete(updatedurl)

The name r does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        logger.info("Deletion Result:" + str(r.status_code) + r.reason)

        return r.status_code, r.json()

"""
def zipOrthanc(endpoint):
    query = orthanc_url + '/studies/' + orthanc_study_id + '/archive'
    response_study = requests.get(query, verify=False, \
                                  auth=(orthanc_user, orthanc_password))
    if response_study.status_code != 200:
        print
        'Problem retrieving study: ' + orthanc_study_id
        print
        response_study.status, response_study.reason
        continue
    print
    '   Retrieved: %s' % orthanc_study_id
    zip_content = response_study.content

    file_like_object = io.BytesIO(zip_content)
    zip_object = zipfile.ZipFile(file_like_object)
    for zip_name in zip_object.namelist():
        zip_object.extract(zip_name, some_destination_dir)
"""

This string statement has no effect and could be removed.