Python.DICOM.validate

Complexity

Total Complexity

3

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes

0

2 Functions

Rating	Name	Duplication	Size	Complexity
A	DICOM_validator()	0	19	2
A	DICOM_batchValidator()	0	2	1

import sys

This module should have a docstring.

import logging

logging.basicConfig(stream=sys.stdout, level=logging.INFO)

def DICOM_validator(file_path):

The name DICOM_validator does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    """
    validate to check if the DICOM file is an actual DICOM file.
    :param file_path:
    :return:
    """
    logger = logging.getLogger(__name__)

    global dicom

Global variable 'dicom' undefined at the module level

The name dicom does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

    dicom = None

    from pydicom.filereader import InvalidDicomError
    from pydicom.filereader import read_file
    try:
        dicom = read_file(file_path)
    except InvalidDicomError:
        logger.info(file_path + " is not a DICOM file. Skipping")
        return False, None
    return True, dicom


def DICOM_batchValidator(dir_path):

The name DICOM_batchValidator does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The argument dir_path seems to be unused.

    """
    Some basic information of the participants must be consistent across the files, such as the SCAN DATE (assuming they are not scanning across MIDNIGHT POINT)

This line is too long as per the coding-style (160/100).

    Birthday date, subject name, etc MUST BE CONSISTENT across a SINGLE subject's folder, RIGHT!

    :param dir_path:
    :return:
    """


#if __name__ == '__main__':