Python.DICOM.anonymize

Complexity

Total Complexity

5

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes

0

2 Functions

Rating	Name	Duplication	Size	Complexity
A	DICOM_anonymizer()	0	9	1
A	DICOM_anonymizer_save_as()	0	20	4

from DICOM.validate import DICOM_validator

This module should have a docstring.

Unable to import 'DICOM.validate'

from DICOM.elements import DICOM_updateElement

Unable to import 'DICOM.elements'

def DICOM_anonymizer(path, PSCID):

The name DICOM_anonymizer does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The name PSCID does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    """
    Anonymize the DICOMS to remove any identifiable information
    :param path:
    :param PSCID:
    :return:
    """

    return DICOM_anonymizer_save_as(path, PSCID, path)


def DICOM_anonymizer_save_as(path, PSCID, out_path):

The name DICOM_anonymizer_save_as does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The name PSCID does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

    """
    Anonymize the DICOMS to remove any identifiable information
    :param path:
    :param PSCID:
    :return:
    """

    success, dataset = DICOM_validator(path)

The variable dataset seems to be unused.

    if not success:
        return False

    success1, _ = DICOM_updateElement(path, "PatientID", PSCID, out_path)
    success2, _ = DICOM_updateElement(path, "PatientName", PSCID, out_path)

    if success1 and success2:

The if statement can be replaced with 'return bool(test)'

Unnecessary "else" after "return"

        return True
    else:
        return False
    return True

Final newline missing