Passed
Pull Request — master (#2)
by Yang
02:09
created

Python.oshelper.Scheduler   A

Complexity

Total Complexity 1

Size/Duplication

Total Lines 51
Duplicated Lines 31.37 %

Importance

Changes 0
Metric Value
wmc 1
eloc 23
dl 16
loc 51
rs 10
c 0
b 0
f 0

1 Function

Rating   Name   Duplication   Size   Complexity  
A DICOMMonitor() 0 11 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
import sys
0 ignored issues
show
Coding Style introduced by
This module should have a docstring.

The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods:

class SomeClass:
    def some_method(self):
        """Do x and return foo."""

If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions.

Loading history...
2
import os
0 ignored issues
show
Unused Code introduced by
The import os seems to be unused.
Loading history...
3
import argparse
4
import getpass
5
import logging
6
7
logging.basicConfig(stream=sys.stdout, level=logging.INFO)
8
9
10
11
def DICOMMonitor():
0 ignored issues
show
Coding Style Naming introduced by
The name DICOMMonitor does not conform to the function naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This check looks for invalid names for a range of different identifiers.

You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements.

If your project includes a Pylint configuration file, the settings contained in that file take precedence.

To find out more about Pylint, please refer to their site.

Loading history...
12
    '''
13
    Monitor the DICOM folders of Orthanc output.
14
    :
15
    '''
16
    logger = logging.getLogger('DICOMMonitor')
0 ignored issues
show
Unused Code introduced by
The variable logger seems to be unused.
Loading history...
17
18
    default_locations = "example path"
0 ignored issues
show
Unused Code introduced by
The variable default_locations seems to be unused.
Loading history...
19
    default_monitoring_duration = 60 #seconds
0 ignored issues
show
Unused Code introduced by
The variable default_monitoring_duration seems to be unused.
Loading history...
20
    default_DCMTK = "DCMTK path"
0 ignored issues
show
Coding Style Naming introduced by
The name default_DCMTK does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This check looks for invalid names for a range of different identifiers.

You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements.

If your project includes a Pylint configuration file, the settings contained in that file take precedence.

To find out more about Pylint, please refer to their site.

Loading history...
Unused Code introduced by
The variable default_DCMTK seems to be unused.
Loading history...
21
    default_os = "ubuntu"
0 ignored issues
show
Unused Code introduced by
The variable default_os seems to be unused.
Loading history...
22
23
    #Check for all the new batch if they contain any of the known existing DICOM string.
24
25
26
27
28
29
30
31
32
33
34
35 View Code Duplication
if __name__ == '__main__':
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated in your project.
Loading history...
36
37
    parser = argparse.ArgumentParser(description=__doc__)
0 ignored issues
show
Coding Style Naming introduced by
The name parser does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

This check looks for invalid names for a range of different identifiers.

You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements.

If your project includes a Pylint configuration file, the settings contained in that file take precedence.

To find out more about Pylint, please refer to their site.

Loading history...
38
    parser.add_argument('-u', '--user', dest='email', type=str, help='Username/Email used for login')
0 ignored issues
show
Coding Style introduced by
This line is too long as per the coding-style (101/100).

This check looks for lines that are too long. You can specify the maximum line length.

Loading history...
39
    parser.add_argument('-p', '--production', dest='production', action='store_true', help='Example of boolean arg')
0 ignored issues
show
Coding Style introduced by
This line is too long as per the coding-style (116/100).

This check looks for lines that are too long. You can specify the maximum line length.

Loading history...
40
    parser.add_argument('-o', '--option', dest='option', type=str, help='Example of str arg')
41
42
    parser.add_argument('file', metavar='file', type=str, help='Example of a positional argument')
43
44
    args = parser.parse_args()
0 ignored issues
show
Coding Style Naming introduced by
The name args does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

This check looks for invalid names for a range of different identifiers.

You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements.

If your project includes a Pylint configuration file, the settings contained in that file take precedence.

To find out more about Pylint, please refer to their site.

Loading history...
45
    logger.info('--------------')
0 ignored issues
show
Comprehensibility Best Practice introduced by
The variable logger does not seem to be defined.
Loading history...
Comprehensibility Best Practice introduced by
Undefined variable 'logger'
Loading history...
46
47
    # Never ask for a password in command-line. Manually ask for it here
48
    password = getpass.getpass()
0 ignored issues
show
Coding Style Naming introduced by
The name password does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

This check looks for invalid names for a range of different identifiers.

You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements.

If your project includes a Pylint configuration file, the settings contained in that file take precedence.

To find out more about Pylint, please refer to their site.

Loading history...
49
50
    logger.info('Hello World!')
0 ignored issues
show
Comprehensibility Best Practice introduced by
Undefined variable 'logger'
Loading history...
51